From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1D10C5952 for ; Mon, 30 Nov 2015 03:14:18 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 29 Nov 2015 18:14:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,363,1444719600"; d="scan'208";a="830525650" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 29 Nov 2015 18:14:13 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 29 Nov 2015 18:14:11 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 29 Nov 2015 18:14:10 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.193]) with mapi id 14.03.0248.002; Mon, 30 Nov 2015 10:14:09 +0800 From: "Xu, HuilongX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH v2] framework: init pexcept sessions from crb instance Thread-Index: AQHRKPId8pRFFR9Ic0WxMpr57imiRZ6z05hQ Date: Mon, 30 Nov 2015 02:14:08 +0000 Message-ID: References: <448613555-19236-1-git-send-email-yong.liu@intel.com> <1448614799-20107-1-git-send-email-yong.liu@intel.com> In-Reply-To: <1448614799-20107-1-git-send-email-yong.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2] framework: init pexcept sessions from crb instance X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 02:14:19 -0000 Hi yong,=20 Could you check Virtdut init function in ./framework/virt_dut.py? I think you need update it also. Thanks a lot > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yong Liu > Sent: Friday, November 27, 2015 5:00 PM > To: dts@dpdk.org > Subject: [dts] [PATCH v2] framework: init pexcept sessions from crb > instance >=20 > From: Marvin Liu >=20 > Dut and tester will inherit pexpect sessions from crb instance. > Session is basic componment of crb instance, should be initialized in crb > module. >=20 > Signed-off-by: Marvin Liu >=20 > diff --git a/framework/crb.py b/framework/crb.py > index fcbd7d9..1164338 100644 > --- a/framework/crb.py > +++ b/framework/crb.py > @@ -34,6 +34,8 @@ import dts > import re > import os > from settings import TIMEOUT, IXIA > +from ssh_connection import SSHConnection > +from logger import getLogger >=20 > """ > CRB (customer reference board) basic functions and handlers > @@ -48,13 +50,23 @@ class Crb(object): > CPU/PCI/NIC on the board and setup running environment for DPDK. > """ >=20 > - def __init__(self, crb, serializer): > + def __init__(self, crb, serializer, name): > self.crb =3D crb > self.read_cache =3D False > self.skip_setup =3D False > self.serializer =3D serializer > self.ports_info =3D None >=20 > + self.logger =3D getLogger(name) > + self.session =3D SSHConnection(self.get_ip_address(), name, > + self.get_password()) > + self.session.init_log(self.logger) > + self.alt_session =3D SSHConnection( > + self.get_ip_address(), > + name + '_alt', > + self.get_password()) > + self.alt_session.init_log(self.logger) > + > def send_expect(self, cmds, expected, timeout=3DTIMEOUT, > alt_session=3DFalse, verify=3DFalse): > """ > diff --git a/framework/dut.py b/framework/dut.py > index 70bd146..f5563d0 100644 > --- a/framework/dut.py > +++ b/framework/dut.py > @@ -39,7 +39,6 @@ from settings import NICS, LOG_NAME_SEP > from ssh_connection import SSHConnection > from crb import Crb > from net_device import NetDevice > -from logger import getLogger > from virt_resource import VirtResource > from utils import RED >=20 > @@ -62,19 +61,10 @@ class Dut(Crb): > PCI_DEV_CACHE_KEY =3D 'dut_pci_dev_info' >=20 > def __init__(self, crb, serializer): > - super(Dut, self).__init__(crb, serializer) > self.NAME =3D 'dut' > + super(Dut, self).__init__(crb, serializer, self.NAME) >=20 > self.host_init_flag =3D False > - self.logger =3D getLogger(self.NAME) > - self.session =3D SSHConnection(self.get_ip_address(), self.NAME, > - self.get_password()) > - self.session.init_log(self.logger) > - self.alt_session =3D SSHConnection( > - self.get_ip_address(), > - self.NAME + '_alt', > - self.get_password()) > - self.alt_session.init_log(self.logger) > self.number_of_cores =3D 0 > self.tester =3D None > self.cores =3D [] > diff --git a/framework/tester.py b/framework/tester.py > index 1f4f7ae..aeae1f8 100644 > --- a/framework/tester.py > +++ b/framework/tester.py > @@ -58,17 +58,8 @@ class Tester(Crb): > PCI_DEV_CACHE_KEY =3D 'tester_pci_dev_info' >=20 > def __init__(self, crb, serializer): > - super(Tester, self).__init__(crb, serializer) > self.NAME =3D 'tester' > - > - self.logger =3D getLogger(self.NAME) > - self.session =3D SSHConnection(self.get_ip_address(), > - self.NAME, self.get_password()) > - self.session.init_log(self.logger) > - self.alt_session =3D SSHConnection(self.get_ip_address(), > - self.NAME + '_alt', > - self.get_password()) > - self.alt_session.init_log(self.logger) > + super(Tester, self).__init__(crb, serializer, self.NAME) >=20 > self.bgProcIsRunning =3D False > self.dut =3D None > -- > 1.9.3