* [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville
@ 2015-12-01 5:59 Lijuan Tu
2015-12-01 6:12 ` Liu, Yong
2015-12-01 6:26 ` Xu, HuilongX
0 siblings, 2 replies; 3+ messages in thread
From: Lijuan Tu @ 2015-12-01 5:59 UTC (permalink / raw)
To: dts
Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
tests/TestSuite_uni_pkt.py | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index ca72e75..17c11b0 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -63,6 +63,13 @@ class TestUniPacket(TestCase):
self.dut_port = valports[0]
tester_port = self.tester.get_local_port(self.dut_port)
self.tester_iface = self.tester.get_interface(tester_port)
+ """
+ Disable vector ixgbe driver in dpdk configuration file.
+ """
+ [arch, machine, env, toolchain] = self.target.split('-')
+ self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=.*$/"
+ + "CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_%s" % env, "# ", 30)
+ self.dut.build_install_dpdk(self.target)
self.dut.send_expect(
"./%s/app/testpmd -c f -n 4 -- -i --txqflags=0x0" % self.target, "testpmd>", 20)
self.dut.send_expect("set fwd rxonly", "testpmd>")
@@ -117,7 +124,7 @@ class TestUniPacket(TestCase):
"""
if "fortville" in self.nic.lower():
outerL4Type = "(outer) L4 type: L4_NONFRAG"
- elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
+ elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower():
outerL4Type = "(outer) L4 type: Unknown"
pktType = {
@@ -135,7 +142,7 @@ class TestUniPacket(TestCase):
if "fortville" in self.nic.lower():
pktType.pop("MAC_IPihl_PKT")
pktType.pop("MAC_IPihl_SCTP_PKT")
- elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
+ elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower():
pktType.pop("MAC_IP_ICMP_PKT")
pktType.pop("MAC_IPFRAG_TCP_PKT")
@@ -148,7 +155,7 @@ class TestUniPacket(TestCase):
if "fortville" in self.nic.lower():
outerL4Type = "(outer) L4 type: L4_NONFRAG"
outerL3Type = "(outer) L3 type: IPV6_EXT_UNKNOWN"
- elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
+ elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower():
outerL4Type = "(outer) L4 type: Unknown"
outerL3Type = "(outer) L3 type: IPV6"
@@ -163,7 +170,7 @@ class TestUniPacket(TestCase):
# delete the unsupported packet based on nic type
if "fortville" in self.nic.lower():
pktType.pop("MAC_IPv6FRAG_PKT_N")
- elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
+ elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower():
pktType.pop("MAC_IPv6FRAG_PKT_F")
self.run_test(pktType)
@@ -198,7 +205,7 @@ class TestUniPacket(TestCase):
checked that whether IPv4 in IPv6 tunnel packet can be normally
detected by Niantic and i350.
"""
- if "niantic" not in self.nic.lower() and "i350" not in self.nic.lower():
+ if "niantic" not in self.nic.lower() and "powerville" not in self.nic.lower():
return
pktType = {
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville
2015-12-01 5:59 [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville Lijuan Tu
@ 2015-12-01 6:12 ` Liu, Yong
2015-12-01 6:26 ` Xu, HuilongX
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2015-12-01 6:12 UTC (permalink / raw)
To: Tu, LijuanX A, dts
Hi Lijuan,
Some comments below. Thanks.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Tuesday, December 01, 2015 1:59 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and
> rename i350 to powerville
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
> tests/TestSuite_uni_pkt.py | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
> index ca72e75..17c11b0 100644
> --- a/tests/TestSuite_uni_pkt.py
> +++ b/tests/TestSuite_uni_pkt.py
> @@ -63,6 +63,13 @@ class TestUniPacket(TestCase):
> self.dut_port = valports[0]
> tester_port = self.tester.get_local_port(self.dut_port)
> self.tester_iface = self.tester.get_interface(tester_port)
> + """
> + Disable vector ixgbe driver in dpdk configuration file.
> + """
> + [arch, machine, env, toolchain] = self.target.split('-')
> + self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=.*$/"
> + + "CONFIG_RTE_IXGBE_INC_VECTOR=n/'
> config/common_%s" % env, "# ", 30)
Not only Niantic but also Fortville need disable vector code path.
I think this suite should disable vector function based on NIC type.
> + self.dut.build_install_dpdk(self.target)
> self.dut.send_expect(
> "./%s/app/testpmd -c f -n 4 -- -i --txqflags=0x0" %
> self.target, "testpmd>", 20)
> self.dut.send_expect("set fwd rxonly", "testpmd>")
> @@ -117,7 +124,7 @@ class TestUniPacket(TestCase):
> """
> if "fortville" in self.nic.lower():
> outerL4Type = "(outer) L4 type: L4_NONFRAG"
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> outerL4Type = "(outer) L4 type: Unknown"
>
> pktType = {
> @@ -135,7 +142,7 @@ class TestUniPacket(TestCase):
> if "fortville" in self.nic.lower():
> pktType.pop("MAC_IPihl_PKT")
> pktType.pop("MAC_IPihl_SCTP_PKT")
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> pktType.pop("MAC_IP_ICMP_PKT")
> pktType.pop("MAC_IPFRAG_TCP_PKT")
>
> @@ -148,7 +155,7 @@ class TestUniPacket(TestCase):
> if "fortville" in self.nic.lower():
> outerL4Type = "(outer) L4 type: L4_NONFRAG"
> outerL3Type = "(outer) L3 type: IPV6_EXT_UNKNOWN"
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> outerL4Type = "(outer) L4 type: Unknown"
> outerL3Type = "(outer) L3 type: IPV6"
>
> @@ -163,7 +170,7 @@ class TestUniPacket(TestCase):
> # delete the unsupported packet based on nic type
> if "fortville" in self.nic.lower():
> pktType.pop("MAC_IPv6FRAG_PKT_N")
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> pktType.pop("MAC_IPv6FRAG_PKT_F")
>
> self.run_test(pktType)
> @@ -198,7 +205,7 @@ class TestUniPacket(TestCase):
> checked that whether IPv4 in IPv6 tunnel packet can be normally
> detected by Niantic and i350.
> """
> - if "niantic" not in self.nic.lower() and "i350" not in
> self.nic.lower():
> + if "niantic" not in self.nic.lower() and "powerville" not in
> self.nic.lower():
There's one excel file named "dpdk_support_test_case.xls" which has tracked whether cases support in the NIC.
I think we can remove the judging condition here.
> return
>
> pktType = {
> --
> 1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville
2015-12-01 5:59 [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville Lijuan Tu
2015-12-01 6:12 ` Liu, Yong
@ 2015-12-01 6:26 ` Xu, HuilongX
1 sibling, 0 replies; 3+ messages in thread
From: Xu, HuilongX @ 2015-12-01 6:26 UTC (permalink / raw)
To: Tu, LijuanX A, dts
Hi lijuan,
You should enable IXGB VEC PMD after you finish this test.
Thanks a lot
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Tuesday, December 01, 2015 1:59 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and
> rename i350 to powerville
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
> tests/TestSuite_uni_pkt.py | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
> index ca72e75..17c11b0 100644
> --- a/tests/TestSuite_uni_pkt.py
> +++ b/tests/TestSuite_uni_pkt.py
> @@ -63,6 +63,13 @@ class TestUniPacket(TestCase):
> self.dut_port = valports[0]
> tester_port = self.tester.get_local_port(self.dut_port)
> self.tester_iface = self.tester.get_interface(tester_port)
> + """
> + Disable vector ixgbe driver in dpdk configuration file.
> + """
> + [arch, machine, env, toolchain] = self.target.split('-')
> + self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=.*$/"
> + + "CONFIG_RTE_IXGBE_INC_VECTOR=n/'
> config/common_%s" % env, "# ", 30)
> + self.dut.build_install_dpdk(self.target)
> self.dut.send_expect(
> "./%s/app/testpmd -c f -n 4 -- -i --txqflags=0x0" %
> self.target, "testpmd>", 20)
> self.dut.send_expect("set fwd rxonly", "testpmd>")
> @@ -117,7 +124,7 @@ class TestUniPacket(TestCase):
> """
> if "fortville" in self.nic.lower():
> outerL4Type = "(outer) L4 type: L4_NONFRAG"
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> outerL4Type = "(outer) L4 type: Unknown"
>
> pktType = {
> @@ -135,7 +142,7 @@ class TestUniPacket(TestCase):
> if "fortville" in self.nic.lower():
> pktType.pop("MAC_IPihl_PKT")
> pktType.pop("MAC_IPihl_SCTP_PKT")
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> pktType.pop("MAC_IP_ICMP_PKT")
> pktType.pop("MAC_IPFRAG_TCP_PKT")
>
> @@ -148,7 +155,7 @@ class TestUniPacket(TestCase):
> if "fortville" in self.nic.lower():
> outerL4Type = "(outer) L4 type: L4_NONFRAG"
> outerL3Type = "(outer) L3 type: IPV6_EXT_UNKNOWN"
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> outerL4Type = "(outer) L4 type: Unknown"
> outerL3Type = "(outer) L3 type: IPV6"
>
> @@ -163,7 +170,7 @@ class TestUniPacket(TestCase):
> # delete the unsupported packet based on nic type
> if "fortville" in self.nic.lower():
> pktType.pop("MAC_IPv6FRAG_PKT_N")
> - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> + elif "niantic" in self.nic.lower() or "powerville" in
> self.nic.lower():
> pktType.pop("MAC_IPv6FRAG_PKT_F")
>
> self.run_test(pktType)
> @@ -198,7 +205,7 @@ class TestUniPacket(TestCase):
> checked that whether IPv4 in IPv6 tunnel packet can be normally
> detected by Niantic and i350.
> """
> - if "niantic" not in self.nic.lower() and "i350" not in
> self.nic.lower():
> + if "niantic" not in self.nic.lower() and "powerville" not in
> self.nic.lower():
> return
>
> pktType = {
> --
> 1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 6:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-01 5:59 [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville Lijuan Tu
2015-12-01 6:12 ` Liu, Yong
2015-12-01 6:26 ` Xu, HuilongX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).