Re: [dts] [PATCH V1] add fvl and niantic nic vf rss test plan

["Xu, HuilongX" <huilongx.xu@intel.com>]

Hi , 
Please see my explain below.
Thanks a  lot

> -----Original Message-----
> From: Pei, Yulong
> Sent: Thursday, January 07, 2016 5:04 PM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] add fvl and niantic nic vf rss test plan
> 
> Please see my comments below,
> 
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Thursday, January 7, 2016 2:22 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH V1] add fvl and niantic nic vf rss test plan
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  test_plans/vf_rss_test_plan.rst | 187
> ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 187 insertions(+)
>  create mode 100644 test_plans/vf_rss_test_plan.rst
> 
> diff --git a/test_plans/vf_rss_test_plan.rst
> b/test_plans/vf_rss_test_plan.rst new file mode 100644 index
> 0000000..6f6ec38
> --- /dev/null
> +++ b/test_plans/vf_rss_test_plan.rst
> @@ -0,0 +1,187 @@
> +.. Copyright (c) <2016>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +==================================================================
> +Fortville RSS full support - Support configuring hash functions
> +==================================================================
> +
> +This document provides test plan for testing the function of Fortville:
> +Support configuring hash functions.
> +
> +Prerequisites
> +-------------
> +
> +2x Intel? 82599 (Niantic) NICs (2x 10GbE full duplex optical ports per
> +NIC) 1x Fortville_eagle NIC (4x 10G) 1x Fortville_spirit NIC (2x 40G)
> +2x Fortville_spirit_single NIC (1x 40G)
> +
> +The four ports of the 82599 connect to the Fortville_eagle; The two
> +ports of Fortville_spirit connect to Fortville_spirit_single.
> +The three kinds of NICs are the target NICs. the connected NICs can
> +send packets to these three NICs using scapy.
> +
> 
> Is Prerequisites right ?
Yes, it's right, maybe I should add vm config in  prerequisites.
> 
> 
> +Network Traffic
> +---------------
> +
> +The RSS feature is designed to improve networking performance by load
> +balancing the packets received from a NIC port to multiple NIC RX
> +queues, with each queue handled by a different logical core.
> +
> +#1. The receive packet is parsed into the header fields used by the
> +hash operation (such as IP addresses, TCP port, etc.)
> +
> +#2. A hash calculation is performed. The Fortville  supports four hash
> function:
> 
> ^^^^^^^
> 
> +Toeplitz, simple XOR and their Symmetric RSS.
> +
> +#3. The seven LSBs of the hash result are used as an index into a
> +128/512 entry 'redirection table'. Each entry provides a 4-bit RSS output
> index.
> +
> +The RSS RETA update feature is designed to make RSS more flexible by
> +allowing users to define the correspondence between the seven LSBs of
> +hash result and the queue id(RSS output index) by themself.
> +
> +
> 
> #3 is fit for Fortville ?
Yes, Niantic reta entry is 128. But Fortville reta entry is 512.
> 
> 
> +Test Case:  test_rss_hash
> +========================================
> +
> +The following RX Ports/Queues configurations have to be benchmarked:
> +
> +- 1 RX port / 4 RX queues (1P/4Q)
> +
> +
> +Testpmd configuration - 4 RX/TX queues per port
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +::
> +
> +  testpmd -c 1f -n 3 -b 0000:05:00.1 -- -i --rxd=512 --txd=512
> + --burst=32 \
> +  --txpt=36 --txht=0 --txwt=0 --txfreet=32 --rxfreet=64 --txrst=32
> + --mbcache=128 \
> +  --rxq=4 --txq=4
> +
> 
> Are the params all required ?
Yes
> 
> 
> +The -n command is used to select the number of memory channels. It should
> match the number of memory channels on that setup.
> +The -b command is used to prevent the use of pic port to receive packets.
> It should match the pci number of the pci device.
> +
> 
> No need to explain -n -b.
Ok, I will delete them in next version.
> 
> +Testpmd Configuration Options
> +-----------------------------
> +
> +By default, a single logical core runs the test.
> +The CPU IDs and the number of logical cores running the test in
> +parallel can be manually set with the ``set corelist X,Y`` and the
> +``set nbcore N`` interactive commands of the ``testpmd`` application.
> +#1. got the pci device id of DUT, for example,
> +
> +./dpdk_nic_bind.py --st
> +
> +0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0
> +drv=i40e unused=
> +0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1
> +drv=i40e unused=
> +
> +#2. create 2 VFs from 2 PFs,
> +
> +echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/sriov_numvfs
> +echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/sriov_numvfs
> +./dpdk_nic_bind.py --st
> +
> +0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0
> +drv=i40e unused=
> +0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1
> +drv=i40e unused=
> +0000:81:02.0 'XL710/X710 Virtual Function' unused=
> +0000:81:0a.0 'XL710/X710 Virtual Function' unused=
> +
> +#3. detach VFs from the host, bind them to pci-stub driver,
> +
> +/sbin/modprobe pci-stub
> +
> +using `lspci -nn|grep -i ethernet` got VF device id, for example "8086
> +154c",
> +
> +echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
> +echo 0000:81:02.0 > /sys/bus/pci/devices/0000:08:02.0/driver/unbind
> +echo 0000:81:02.0 > /sys/bus/pci/drivers/pci-stub/bind
> +
> +echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
> +echo 0000:81:0a.0 > /sys/bus/pci/devices/0000:08:0a.0/driver/unbind
> +echo 0000:81:0a.0 > /sys/bus/pci/drivers/pci-stub/bind
> +
> +  or using the following more easy way,
> +
> +  virsh nodedev-detach pci_0000_81_02_0;  virsh nodedev-detach
> + pci_0000_81_0a_0;
> +
> +  ./dpdk_nic_bind.py --st
> +
> +  0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0
> + drv=i40e unused=
> +  0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1
> + drv=i40e unused=
> +  0000:81:02.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
> +  0000:81:0a.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
> +
> +  it can be seen that VFs 81:02.0 & 81:0a.0 's drv is pci-stub.
> +
> +#4. passthrough VFs 81:02.0 & 81:0a.0 to vm0, and start vm0,
> +
> +  /usr/bin/qemu-system-x86_64  -name vm0 -enable-kvm \  -cpu host -smp
> + 4 -m 2048 -drive file=/home/image/sriov-fc20-1.img -vnc :1 \  -device
> + pci-assign,host=81:02.0,id=pt_0 \  -device
> + pci-assign,host=81:0a.0,id=pt_1
> +
> +#5. login vm0, got VFs pci device id in vm0, assume they are 00:06.0 &
> +00:07.0, bind them to igb_uio driver, and then start testpmd, set it in
> +mac forward mode,
> +
> +./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
> +
> +#6. Reta Configuration.  128 reta entries configuration::
> +
> +  testpmd command: port config 0 rss reta (hash_index,queue_id)
> +
> +#7. PMD fwd only receive the packets::
> +
> +  testpmd command: set fwd rxonly
> +
> +#8. rss recived package type configuration two received packet types
> configuration::
> +
> +  testpmd command: port config 0 rss ip/udp/tcp
> 
> 
> Should test  " ip|tcp|udp|sctp|ether"
>
I will update it next version
 
> 
> Best Regards
> Yulong Pei
> 
> 
> +
> +#9. verbose configuration::
> +
> +  testpmd command: set verbose 8
> +
> +#10. start packet receive::
> +
> +  testpmd command: start
> +#11. send packet and check rx port received packet by different queue.
> +  different hash type send different packet, example hash type is ip,
> +packet src and dts ip not different
> +  sendp([Ether(dst="90:e2:ba:36:99:3c")/IP(src="192.168.0.4",
> dst="192.168.0.5")], iface="eth3")
> +  sendp([Ether(dst="90:e2:ba:36:99:3c")/IP(src="192.168.0.5",
> dst="192.168.0.4")], iface="eth3")
> +Test Case:  test_reta
> +========================================
> +   this case test hash reta table, the test steps same with
> +test_rss_hash except config hash reta table
> +#1 before send packet, config hash reta,512(niantic nic have 128 reta)
> reta entries configuration::
> +
> +     testpmd command: port config 0 rss reta (hash_index,queue_id)
> \ No newline at end of file
> --
> 1.9.3