Re: [dts] [PATCH V1 3/3] add vf rss test script

["Xu, HuilongX" <huilongx.xu@intel.com>]

Hi yulong,
Thanks a lot for you review my patch, pls check my comments.
thanks

> -----Original Message-----
> From: Pei, Yulong
> Sent: Thursday, January 14, 2016 7:52 PM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1 3/3] add vf rss test script
> 
> Hi,
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Tuesday, January 12, 2016 6:53 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH V1 3/3] add vf rss test script
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_vf_rss.py | 382
> ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 382 insertions(+)
>  create mode 100644 tests/TestSuite_vf_rss.py
> 
> diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py new
> file mode 100644 index 0000000..a59516d
> --- /dev/null
> +++ b/tests/TestSuite_vf_rss.py
> @@ -0,0 +1,382 @@
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without #
> +modification, are permitted provided that the following conditions #
> +are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS #
> +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT #
> +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR #
> +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT #
> +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, #
> +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT #
> +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, #
> +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY #
> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT #
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE #
> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +"""
> +DPDK Test suite.
> +Test RSS reta (redirection table) update function.
> +"""
> +import time
> +import random
> +import re
> +import dts
> +testQueues = [4]
> +reta_entries = []
> +reta_lines = []
> +
> +# Use scapy to send packets with different source and dest ip.
> +# and collect the hash result of five tuple and the queue id.
> +from test_case import TestCase
> +from pmd_output import PmdOutput
> +from qemu_kvm import QEMUKvm
> +
> +class TestVfRss(TestCase):
> +    def send_packet(self, itf, tran_type):
> +        """
> +        Sends packets.
> +        """
> +        global reta_lines
> +        reta_lines = []
> +        self.tester.scapy_foreground()
> +        self.tester.scapy_append('sys.path.append("./")')
> +        self.tester.scapy_append('from sctp import *')
> +        self.vm_dut_0.send_expect("start", "testpmd>")
> +        mac = self.vm_dut_0.get_mac_address(0)
> +        # send packet with different source and dest ip
> +        if tran_type == "ipv4-other":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")],
> iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv4-tcp":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IP(src="192.168.0.%d",
> dst="192.168.0.%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv4-udp":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IP(src="192.168.0.%d",
> dst="192.168.0.%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv4-sctp":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s")/IP(src="192.168.0.%d",
> dst="192.168.0.%d")/SCTP(sport=1024,dport=1025,tag=1)], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +                packet = r'sendp([Ether(dst="%s")/IP(src="192.168.0.%d",
> dst="192.168.0.%d")/SCTP(sport=1025,dport=1024,tag=1)], iface="%s")' % (
> +                    mac, i + 2, i + 1, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "l2_payload":
> +            for i in range(16):
> +                packet =
> r'sendp([Ether(src="00:00:00:00:00:%02d",dst="%s")], iface="%s")' % (
> +                    i + 1, mac, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +
> +        elif tran_type == "ipv6-other":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv6-tcp":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/TCP(sport=1024,dport=1024)], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv6-udp":
> +            for i in range(16):
> +                packet = r'sendp([Ether(dst="%s",
> src="02:00:00:00:00:00")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/UDP(sport=1024,dport=1024)], iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +        elif tran_type == "ipv6-sctp":
> +            for i in range(16):
> +                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/SCTP(sport=1024,dport=1025,tag=1)],
> iface="%s")' % (
> +                    mac, i + 1, i + 2, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/SCTP(sport=1025,dport=1024,tag=1)],
> iface="%s")' % (
> +                    mac, i + 2, i + 1, itf)
> +                self.tester.scapy_append(packet)
> +                self.tester.scapy_execute()
> +                time.sleep(.5)
> +
> +        else:
> +            print "\ntran_type error!\n"
> +
> +        #out = self.vm_dut_0.send_expect("stop", "testpmd>")
> +        out = self.vm_dut_0.get_session_output()
> +        print '*******************************************'
> +        print out
> +        if  not reta_entries:
> +           self.verify('RSS hash=' in out, 'rss faied')
> +           return
> +        lines = out.split("\r\n")
> +        out = ''
> +        reta_line = {}
> +
> +        # collect the hash result of five tuple and the queue id
> +        for line in lines:
> +            line = line.strip()
> +            if len(line) != 0 and line.startswith(("src=",)):
> +                for item in line.split("-"):
> +                    item = item.strip()
> +                    if(item.startswith("RSS hash")):
> +                        name, value = item.split("=", 1)
> +                        print name + "-" + value
> +
> +                reta_line[name.strip()] = value.strip()
> +                reta_lines.append(reta_line)
> +                reta_line = {}
> +            elif len(line) != 0 and line.strip().startswith("port "):
> +                rexp = r"port (\d)/queue (\d{1,2}): received (\d)
> packets"
> +                m = re.match(rexp, line.strip())
> +                if m:
> +                    reta_line["port"] = m.group(1)
> +                    reta_line["queue"] = m.group(2)
> +            elif len(line) != 0 and line.startswith("stop"):
> +                break
> +            else:
> +                pass
> +        self.verifyResult()
> +
> +
> +    def verifyResult(self):
> +        """
> +        Verify whether or not the result passes.
> +        """
> +
> +        global reta_lines
> +        result = []
> +        dts.results_table_add_header(
> +            ['packet index', 'hash value', 'hash index', 'queue id',
> + 'actual queue id', 'pass '])
> +
> +        i = 0
> +        for tmp_reta_line in reta_lines:
> +            status = "false"
> +            if(self.nic in ["niantic", "redrockcanyou"]):
> +                # compute the hash result of five tuple into the 7 LSBs
> value.
> +                hash_index = int(tmp_reta_line["RSS hash"], 16) % 128
> +            else:
> +                # compute the hash result of five tuple into the 7 LSBs
> value.
> +                hash_index = int(tmp_reta_line["RSS hash"], 16) % 512
> +            if(reta_entries[hash_index] == int(tmp_reta_line["queue"])):
> +                status = "true"
> +                result.insert(i, 0)
> +            else:
> +                status = "fail"
> +                result.insert(i, 1)
> +            dts.results_table_add_row(
> +                [i, tmp_reta_line["RSS hash"], hash_index,
> reta_entries[hash_index], tmp_reta_line["queue"], status])
> +            i = i + 1
> +
> +        dts.results_table_print()
> +        reta_lines = []
> +        self.verify(sum(result) == 0, "the reta update function
> + failed!")
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +
> +        #self.verify(
> +        #    self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single"],
> +        #    "NIC Unsupported: " + str(self.nic))
> 
> Can you remove above lines if it is useless?
> 
> +        self.dut_ports = self.dut.get_ports(self.nic)
> +        self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
> +        self.verify(len(self.dut_ports) >= 1, "Not enough ports
> + available")
> +
> +        self.vm0 = None
> +        self.setup_1pf_1vf_1vm_env_flag = 0
> +        self.setup_1pf_1vf_1vm_env(driver='')
> +        #self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
> +
> +        #self.pmdout = PmdOutput(self.dut)
> +
> 
> Can you remove above lines if it is useless?
> yes, I will remove it  next version.
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        #self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> +        #self.vm0_testpmd.start_testpmd(VM_CORES_MASK,param = "--rxq=4 --
> rxq=4")
> 
> Can you remove above lines if it is useless?
> yes, I will remove it next version
> +        pass
> +    def setup_1pf_1vf_1vm_env(self, driver='default'):
> +
> +        self.used_dut_port_0 = self.dut_ports[0]
> +        self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1,
> driver=driver)
> +        self.sriov_vfs_port_0 =
> + self.dut.ports_info[self.used_dut_port_0]['vfs_port']
> +
> +        try:
> +
> +            for port in self.sriov_vfs_port_0:
> +                port.bind_driver('pci-stub')
> +
> +            time.sleep(1)
> +            vf0_prot = {'opt_host': self.sriov_vfs_port_0[0].pci}
> +
> +            if driver == 'igb_uio':
> +                # start testpmd without the two VFs on the host
> +                self.host_testpmd = PmdOutput(self.dut)
> +                eal_param = '-b %(vf0)s -b %(vf1)s' % {'vf0':
> self.sriov_vfs_port_0[0].pci}
> +                self.host_testpmd.start_testpmd("1S/2C/2T",
> + eal_param=eal_param)
> +
> +            # set up VM0 ENV
> +            self.vm0 = QEMUKvm(self.dut, 'vm0', 'vf_rss')
> +            self.vm0.set_vm_device(driver='pci-assign', **vf0_prot)
> +
> +            self.vm_dut_0 = self.vm0.start()
> +            self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> +            if self.vm_dut_0 is None:
> +                raise Exception("Set up VM0 ENV failed!")
> +
> +            self.setup_1pf_1vf_1vm_env_flag = 1
> +        except Exception as e:
> +            self.destroy_1pf_1vf_1vm_env()
> +            raise Exception(e)
> +
> +    def destroy_1pf_1vf_1vm_env(self):
> +        if getattr(self, 'vm0', None):
> +            #destroy testpmd in vm0
> +            #self.vm0_testpmd.execute_cmd('stop')
> 
> Can you remove above lines if it is useless?
> yes I will remove it next version
> +            self.vm0_testpmd.execute_cmd('quit', '# ')
> +            self.vm0_testpmd = None
> +            self.vm0_dut_ports = None
> +            #destroy vm0
> +            self.vm0.stop()
> +            self.vm0 = None
> +
> +        if getattr(self, 'host_testpmd', None):
> +            self.host_testpmd.execute_cmd('quit', '# ')
> +            self.host_testpmd = None
> +
> +        if getattr(self, 'used_dut_port_0', None):
> +            self.dut.destroy_sriov_vfs_by_port(self.used_dut_port_0)
> +            port = self.dut.ports_info[self.used_dut_port_0]['port']
> +            port.bind_driver()
> +            self.used_dut_port_0 = None
> +
> +        for port_id in self.dut_ports:
> +            port = self.dut.ports_info[port_id]['port']
> +            port.bind_driver()
> +
> +        self.setup_1pf_2vf_1vm_env_flag = 0
> +
> +    def test_vf_pmdrss_reta(self):
> +
> +        # niantic kernel host driver not support this case
> +        if self.nic is 'niantic' and not self.host_testpmd:
> +            return
> +        vm0dutPorts = self.vm_dut_0.get_ports('any')
> +        localPort = self.tester.get_local_port(vm0dutPorts[0])
> +        itf = self.tester.get_interface(localPort)
> +        iptypes = ['IPV4']
> +
> +        self.vm_dut_0.kill_all()
> +
> +        # test with different rss queues
> +        for queue in testQueues:
> +
> +            self.vm0_testpmd.start_testpmd(
> +                "all", "--rxq=%d --txq=%d" % (queue, queue),
> + socket=self.ports_socket)
> +
> +            for iptype in iptypes:
> +                self.vm_dut_0.send_expect("set verbose 8", "testpmd> ")
> +                self.vm_dut_0.send_expect("set fwd rxonly", "testpmd> ")
> +                self.vm_dut_0.send_expect(
> +                    "set nbcore %d" % (queue + 1), "testpmd> ")
> +
> +                # configure the reta with specific mappings.
> +                if(self.nic in ["niantic", "redrockcanyou"]):
> +                    for i in range(128):
> +                        reta_entries.insert(i, random.randint(0, queue -
> 1))
> +                        self.vm_dut_0.send_expect(
> +                            "port config 0 rss reta (%d,%d)" % (i,
> reta_entries[i]), "testpmd> ")
> +                else:
> +                    for i in range(512):
> +                        reta_entries.insert(i, random.randint(0, queue -
> 1))
> +                        self.vm_dut_0.send_expect(
> +                            "port config 0 rss reta (%d,%d)" % (i,
> + reta_entries[i]), "testpmd> ")
> +
> +                self.send_packet(itf, iptype)
> +
> +            self.vm_dut_0.send_expect("quit", "# ", 30)
> +    def test_vf_pmdrss(self):
> +        vm0dutPorts = self.vm_dut_0.get_ports('any')
> +        localPort = self.tester.get_local_port(vm0dutPorts[0])
> +        itf = self.tester.get_interface(localPort)
> +        iptypes = {'ipv4-sctp':'ip',
> +                   'ipv4-other':'ip',
> +                   'ipv4-udp':'udp',
> +                   'ipv4-tcp':'tcp',
> +                   'ipv4-sctp':'sctp',
> +                   'ipv6-other':'ip',
> +                   'ipv6-udp':'udp',
> +                   'ipv6-tcp':'tcp',
> +                   'ipv6-sctp':'sctp',
> +                 #  'l2_payload':'ether'
> 
> Why did not include l2_payload type ?
> l2_payload hash type, it looks not support on niantic vf NIC, I will check it with development.
> +                  }
> +
> +        self.vm_dut_0.kill_all()
> +
> +        # test with different rss queues
> +        for queue in testQueues:
> +
> +            self.vm0_testpmd.start_testpmd(
> +                "all", "--rxq=%d --txq=%d" % (queue, queue),
> + socket=self.ports_socket)
> +
> +            for iptype,rsstype in iptypes.items():
> +                self.vm_dut_0.send_expect("set verbose 8", "testpmd> ")
> +                self.vm_dut_0.send_expect("set fwd rxonly", "testpmd> ")
> +                self.vm_dut_0.send_expect("port config all rss %s" %
> rsstype, "testpmd> ")
> +                self.vm_dut_0.send_expect(
> +                    "set nbcore %d" % (queue + 1), "testpmd> ")
> +
> +                self.send_packet(itf, iptype)
> +
> +            self.vm_dut_0.send_expect("quit", "# ", 30)
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        pass
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        #self.vm_dut_0.kill_all()
> 
> Can you remove above lines if it is useless?
> yes I will remove it next version
> Best Regards
> Yulong Pei
> 
> +        self.destroy_1pf_1vf_1vm_env()
> --
> 1.9.3