test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] update ixgbe nic tpid command
Date: Fri, 18 Mar 2016 07:16:31 +0000	[thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A4637B147B3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E14EC6C1F@SHSMSX103.ccr.corp.intel.com>

Hi yong,
I will update test plan next version ASAP.
Thanks  a lot 

> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, March 18, 2016 3:11 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V1] update ixgbe nic tpid command
> 
> Hi Huilong,
> Look like this case only cover inner tpid, is there any case for outer
> tpid?
> Please remember to update test plan simultaneously.
> 
> Thanks.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Friday, March 18, 2016 9:50 AM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX
> > Subject: [dts] [PATCH V1] update ixgbe nic tpid command
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  tests/TestSuite_dual_vlan.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_dual_vlan.py
> b/tests/TestSuite_dual_vlan.py
> > index 84552f5..a4ae23e 100644
> > --- a/tests/TestSuite_dual_vlan.py
> > +++ b/tests/TestSuite_dual_vlan.py
> > @@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
> >          self.verify(self.nic not in ["fortville_eagle",
> > "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC
> not
> > support tcpid " % self.nic)
> >
> >          self.mode_config(filter="on", strip="on", qinq="on")
> > -        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId,
> > "testpmd> ")
> > +        # nic only support inner model, except fortville nic
> > +        self.dut.send_expect("vlan set inner tpid 1234 %s" %
> dutRxPortId,
> > "testpmd> ")
> >          self.vlan_send_packet(outvlan, invlan)
> >
> >          out = self.get_tcpdump_package()
> >          self.verify("vlan %s" % outvlan in out, "vlan tpid disable
> error:
> > " + out)
> >          self.verify("vlan %s" % invlan in out, "vlan tpid disable
> error:
> > " + out)
> >
> > -        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId,
> > "testpmd> ")
> > +        self.dut.send_expect("vlan set inner tpid 0x8100 %s" %
> > dutRxPortId, "testpmd> ")
> >          self.vlan_send_packet(outvlan, invlan)
> >
> >          out = self.get_tcpdump_package()
> > --
> > 1.9.3

      reply	other threads:[~2016-03-18  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  1:49 xu,huilong
2016-03-18  7:10 ` Liu, Yong
2016-03-18  7:16   ` Xu, HuilongX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF2A19295B96364286FEB7F3DDA27A4637B147B3@SHSMSX101.ccr.corp.intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).