From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C37A158D6 for ; Fri, 18 Mar 2016 08:16:46 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 18 Mar 2016 00:16:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,353,1455004800"; d="scan'208";a="936606046" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 18 Mar 2016 00:16:45 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Mar 2016 00:16:41 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Mar 2016 00:16:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 15:16:32 +0800 From: "Xu, HuilongX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] update ixgbe nic tpid command Thread-Index: AQHRgLkagIMLt1K1D0SJ+oBylXjBJ59ex5xggAAC7xA= Date: Fri, 18 Mar 2016 07:16:31 +0000 Message-ID: References: <1458265788-92427-1-git-send-email-huilongx.xu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E14EC6C1F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E14EC6C1F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] update ixgbe nic tpid command X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 07:16:47 -0000 Hi yong, I will update test plan next version ASAP. Thanks a lot=20 > -----Original Message----- > From: Liu, Yong > Sent: Friday, March 18, 2016 3:11 PM > To: Xu, HuilongX; dts@dpdk.org > Cc: Xu, HuilongX > Subject: RE: [dts] [PATCH V1] update ixgbe nic tpid command >=20 > Hi Huilong, > Look like this case only cover inner tpid, is there any case for outer > tpid? > Please remember to update test plan simultaneously. >=20 > Thanks. >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > > Sent: Friday, March 18, 2016 9:50 AM > > To: dts@dpdk.org > > Cc: Xu, HuilongX > > Subject: [dts] [PATCH V1] update ixgbe nic tpid command > > > > Signed-off-by: xu,huilong > > --- > > tests/TestSuite_dual_vlan.py | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/tests/TestSuite_dual_vlan.py > b/tests/TestSuite_dual_vlan.py > > index 84552f5..a4ae23e 100644 > > --- a/tests/TestSuite_dual_vlan.py > > +++ b/tests/TestSuite_dual_vlan.py > > @@ -364,14 +364,15 @@ class TestDualVlan(TestCase): > > self.verify(self.nic not in ["fortville_eagle", > > "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC > not > > support tcpid " % self.nic) > > > > self.mode_config(filter=3D"on", strip=3D"on", qinq=3D"on") > > - self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId, > > "testpmd> ") > > + # nic only support inner model, except fortville nic > > + self.dut.send_expect("vlan set inner tpid 1234 %s" % > dutRxPortId, > > "testpmd> ") > > self.vlan_send_packet(outvlan, invlan) > > > > out =3D self.get_tcpdump_package() > > self.verify("vlan %s" % outvlan in out, "vlan tpid disable > error: > > " + out) > > self.verify("vlan %s" % invlan in out, "vlan tpid disable > error: > > " + out) > > > > - self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId, > > "testpmd> ") > > + self.dut.send_expect("vlan set inner tpid 0x8100 %s" % > > dutRxPortId, "testpmd> ") > > self.vlan_send_packet(outvlan, invlan) > > > > out =3D self.get_tcpdump_package() > > -- > > 1.9.3