From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A282858D4 for ; Wed, 10 Aug 2016 09:50:57 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 10 Aug 2016 00:50:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,498,1464678000"; d="scan'208";a="1032979413" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2016 00:50:55 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 00:50:53 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 00:50:53 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by shsmsx102.ccr.corp.intel.com ([169.254.2.147]) with mapi id 14.03.0248.002; Wed, 10 Aug 2016 15:50:50 +0800 From: "Xu, HuilongX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] update dump test suite Thread-Index: AQHR8U0em2QSWn+d5EqTTFGokJAbO6BAE10QgAAK6CD//8GyAIAB8oWw Date: Wed, 10 Aug 2016 07:50:49 +0000 Message-ID: References: <1470643881-3347-1-git-send-email-huilongx.xu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E2226B626@SHSMSX103.ccr.corp.intel.com> <57A9A8DE.9030704@intel.com> In-Reply-To: <57A9A8DE.9030704@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] update dump test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 07:50:58 -0000 Hi yong, The mempool name maybe will changed, when development want to update. Dump only a debug function, I think we only check it can dump the info. And the info by dump is normal or not decide by mempool auto test and mempo= ol struct. Thanks a lot > -----Original Message----- > From: Liu, Yong > Sent: Tuesday, August 09, 2016 5:57 PM > To: Xu, HuilongX; dts@dpdk.org > Subject: Re: [dts] [PATCH V1] update dump test suite >=20 > Huilong, > dump_ring, dump_mempool are the test cases for dpdk API which can dump > all mempools and rings. > Ideally, we need to verify dumped mempool information is the same as > added. But at least, we need to verify all added mempools and rings can > be dumped. > After running mempool autotest, there' re three mempools left, they are > "test_nocache", "test_cache", "test_stack". > We need verify the information is correct. >=20 >=20 > On 08/09/2016 01:47 PM, Xu, HuilongX wrote: > >> Only check ring number is not enough, we'd better also check expected > >> >ring name. > > The ring name only a string. The string content set by who will used > it. > > So I think we don't need check the string content. We only should > check dump can work, and get ring struct info. > > And the struct content by dpdk decision. > >> >