test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
	"Tu, LijuanX A" <lijuanx.a.tu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>
Subject: Re: [dts] [PATCH V1] update fortville vlan filte case
Date: Tue, 23 Aug 2016 07:53:09 +0000	[thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A4637B9322B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E222734A7@SHSMSX103.ccr.corp.intel.com>

Hi yong,
I am sorry, this patch from me.
FVL Nic the vlan filter and promisc use same switch. So when we test vlan filter must disable promisc. 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Tuesday, August 23, 2016 3:44 PM
> To: Tu, LijuanX A; dts@dpdk.org
> Cc: Tu, LijuanX A
> Subject: Re: [dts] [PATCH V1] update fortville vlan filte case
> 
> Lijuan, please add more information in the git log.
> We couldn't get the point that why need to disable promisc mode
> mandatory.
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> > Sent: Tuesday, August 23, 2016 2:19 PM
> > To: dts@dpdk.org
> > Cc: Tu, LijuanX A
> > Subject: [dts] [PATCH V1] update fortville vlan filte case
> >
> >     FVL nic must disabel promisc for vlan filter.
> >
> > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> > ---
> >  tests/TestSuite_vlan.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py
> > index 70a9813..43b025d 100644
> > --- a/tests/TestSuite_vlan.py
> > +++ b/tests/TestSuite_vlan.py
> > @@ -77,6 +77,7 @@ class TestVlan(TestCase):
> >
> >          if self.nic in ["fortville_eagle", "fortville_spirit",
> > "fortville_spirit_single", "fortpark_TLV"]:
> >              self.dut.send_expect("vlan set filter on %s" %
> dutRxPortId,
> > "testpmd> ")
> > +            self.dut.send_expect("set promisc all off",  "testpmd> ")
> >
> >          self.dut.send_expect("vlan set strip off %s" % dutRxPortId,
> > "testpmd> ")
> >          self.verify('Set mac packet forwarding mode' in out, "set fwd
> > rxonly error")
> > --
> > 1.9.3

  reply	other threads:[~2016-08-23  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  6:18 Lijuan Tu
2016-08-23  7:44 ` Liu, Yong
2016-08-23  7:53   ` Xu, HuilongX [this message]
2016-08-24  8:48     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF2A19295B96364286FEB7F3DDA27A4637B9322B@SHSMSX101.ccr.corp.intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).