Re: [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD

["Xu, HuilongX" <huilongx.xu@intel.com>]

Hi gang,
Pls see my comments as below.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Thursday, September 01, 2016 4:10 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] modify DTS stop_ports error on freesbd
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  framework/dut.py | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 2f4e53a..14958c9 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -237,10 +237,16 @@ class Dut(Crb):
>              if driver is not None:
>                  # unbind device driver
>                  addr_array = pci_bus.split(':')
> -                domain_id = addr_array[0]
> -                bus_id = addr_array[1]
> -                devfun_id = addr_array[2]
> -                port = GetNicObj(self, domain_id, bus_id, devfun_id)
                   1. Domain_id and bus_id is public code. 
                      You should set vale in out of if...elif.
                   2. devfun_id shoud set vale is addr_array[2] or '' 
> +                if len(addr_array) == 3:
> +                    domain_id = addr_array[0]
> +                    bus_id = addr_array[1]
> +                    devfun_id = addr_array[2]
> +                    port = GetNicObj(self, domain_id, bus_id, devfun_id)
> +                elif len(addr_array) == 2:
> +                    domain_id = addr_array[0]
> +                    bus_id = addr_array[1]
> +                    port = GetNicObj(self, domain_id, bus_id, '')
> +
>                  port.stop()
> 
>      def restore_interfaces_linux(self):
> --
> 1.9.3