test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage machine
Date: Thu, 29 Sep 2016 07:20:25 +0000	[thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A46661912BC@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <57ECB941.7030107@intel.com>

Yes,
Set hugepage will failed in FreeBSD, but not influence the case exec in FreeBSD.
I think maybe we can rework hugepage config on dts framework next time.
Thanks a  lot  

> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, September 29, 2016 2:49 PM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage
> machine
> 
> 
> 
> On 09/21/2016 01:28 PM, xu,huilong wrote:
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >   tests/TestSuite_unit_tests_lpm.py | 15 ++++++++++-----
> >   1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/TestSuite_unit_tests_lpm.py
> b/tests/TestSuite_unit_tests_lpm.py
> > index dadb492..7394d19 100644
> > --- a/tests/TestSuite_unit_tests_lpm.py
> > +++ b/tests/TestSuite_unit_tests_lpm.py
> > @@ -83,11 +83,16 @@ class TestUnitTestsLpmIpv6(TestCase):
> >           """
> >           [arch, machine, env, toolchain] = self.target.split('-')
> >           self.verify(arch == "x86_64", "lpm6 request huge memory")
> > -
> > -        hugepage_ori = self.dut.get_total_huge_pages()
> > -        self.dut.set_huge_pages(4096)
> > -        hugepage_num = self.dut.get_total_huge_pages()
> > -        self.verify(hugepage_num >= 4096, "failed to request huge
> memory")
> > +        # lpm ipv6 should leaest 8g huge page
> > +        min_hugepagesz = 8 * 1024 * 1024
> > +
> > +        hugepage_ori = int(self.dut.get_total_huge_pages())
> > +        hugepages_size = int(self.dut.send_expect("awk
> '/Hugepagesize/ {print $2}' /proc/meminfo", "# "))
> > +
> This command can't work on FreeBSD. Again, it's better to let framework
> handle huge allocation/destroy.
> It's hard to each suite handle the difference for distributions.
> 
> > +        if (hugepages_size * hugepage_ori < min_hugepagesz):
> > +            self.dut.set_huge_pages(min_hugepagesz / hugepages_size)
> > +            hugepage_num = self.dut.get_total_huge_pages()
> > +            self.verify(hugepage_num == min_hugepagesz /
> hugepages_size, "failed to request huge memory")
> >
> >           self.dut.send_expect("./app/test/test -n 1 -c ffff",
> "R.*T.*E.*>.*>", 60)
> >           out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)

  reply	other threads:[~2016-09-29  7:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  5:28 xu,huilong
2016-09-29  6:48 ` Liu, Yong
2016-09-29  7:20   ` Xu, HuilongX [this message]
2016-09-29  8:36     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF2A19295B96364286FEB7F3DDA27A46661912BC@SHSMSX101.ccr.corp.intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).