test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
@ 2016-11-25  6:35 Jianbo Liu
  2016-11-29  1:39 ` Xu, HuilongX
  0 siblings, 1 reply; 4+ messages in thread
From: Jianbo Liu @ 2016-11-25  6:35 UTC (permalink / raw)
  To: dts; +Cc: Jianbo Liu

There is no app/test_pci, uses app/test instead.

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 tests/TestSuite_unit_tests_eal.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index d27ba39..07d423c 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -158,7 +158,7 @@ class TestUnitTestsEal(TestCase):
         Run pci autotest.
         """
         # should re-compile test app, this is only a demo. will implementation after framework support
-        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" % self.target, "R.*T.*E.*>.*>" , self.start_test_time)
+        self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target, "R.*T.*E.*>.*>" , self.start_test_time)
         out = self.dut.send_expect("pci_autotest", "RTE>>", self.run_cmd_time)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
-- 
2.5.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
  2016-11-25  6:35 [dts] [PATCH] tests unit_test_eal: fix test_pci unit test Jianbo Liu
@ 2016-11-29  1:39 ` Xu, HuilongX
  2016-11-29  1:55   ` Jianbo Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Xu, HuilongX @ 2016-11-29  1:39 UTC (permalink / raw)
  To: Jianbo Liu, dts

Hi jianbo,
If we run unit pci test case, we must re-compile test app and enable CONFIG_RTE_APP_TEST_RESOURCE_TAR.
We will submit a patch for compile with enable CONFIG_RTE_APP_TEST_RESOURCE_TAR, and change test app name to test_pci.
Thanks  a lot

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
> Sent: Friday, November 25, 2016 2:36 PM
> To: dts@dpdk.org
> Cc: Jianbo Liu
> Subject: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
> 
> There is no app/test_pci, uses app/test instead.
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---
>  tests/TestSuite_unit_tests_eal.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> index d27ba39..07d423c 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -158,7 +158,7 @@ class TestUnitTestsEal(TestCase):
>          Run pci autotest.
>          """
>          # should re-compile test app, this is only a demo. will
> implementation after framework support
> -        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" %
> self.target, "R.*T.*E.*>.*>" , self.start_test_time)
> +        self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
> "R.*T.*E.*>.*>" , self.start_test_time)
>          out = self.dut.send_expect("pci_autotest", "RTE>>",
> self.run_cmd_time)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> --
> 2.5.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
  2016-11-29  1:39 ` Xu, HuilongX
@ 2016-11-29  1:55   ` Jianbo Liu
  2016-11-29  2:31     ` Xu, HuilongX
  0 siblings, 1 reply; 4+ messages in thread
From: Jianbo Liu @ 2016-11-29  1:55 UTC (permalink / raw)
  To: Xu, HuilongX; +Cc: dts

On 29 November 2016 at 09:39, Xu, HuilongX <huilongx.xu@intel.com> wrote:
> Hi jianbo,
> If we run unit pci test case, we must re-compile test app and enable CONFIG_RTE_APP_TEST_RESOURCE_TAR.
> We will submit a patch for compile with enable CONFIG_RTE_APP_TEST_RESOURCE_TAR, and change test app name to test_pci.
> Thanks  a lot
>

Yes. But it depends on the user's requirement.
If he want to enable CONFIG_RTE_APP_TEST_RESOURCE_TAR, he can change
it by specifying a configuration patch with "dts --patch " argument.


>> -----Original Message-----
>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
>> Sent: Friday, November 25, 2016 2:36 PM
>> To: dts@dpdk.org
>> Cc: Jianbo Liu
>> Subject: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
>>
>> There is no app/test_pci, uses app/test instead.
>>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>> ---
>>  tests/TestSuite_unit_tests_eal.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/TestSuite_unit_tests_eal.py
>> b/tests/TestSuite_unit_tests_eal.py
>> index d27ba39..07d423c 100644
>> --- a/tests/TestSuite_unit_tests_eal.py
>> +++ b/tests/TestSuite_unit_tests_eal.py
>> @@ -158,7 +158,7 @@ class TestUnitTestsEal(TestCase):
>>          Run pci autotest.
>>          """
>>          # should re-compile test app, this is only a demo. will
>> implementation after framework support
>> -        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" %
>> self.target, "R.*T.*E.*>.*>" , self.start_test_time)
>> +        self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
>> "R.*T.*E.*>.*>" , self.start_test_time)
>>          out = self.dut.send_expect("pci_autotest", "RTE>>",
>> self.run_cmd_time)
>>          self.dut.send_expect("quit", "# ")
>>          self.verify("Test OK" in out, "Test failed")
>> --
>> 2.5.5
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
  2016-11-29  1:55   ` Jianbo Liu
@ 2016-11-29  2:31     ` Xu, HuilongX
  0 siblings, 0 replies; 4+ messages in thread
From: Xu, HuilongX @ 2016-11-29  2:31 UTC (permalink / raw)
  To: Jianbo Liu; +Cc: dts



> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@linaro.org]
> Sent: Tuesday, November 29, 2016 9:56 AM
> To: Xu, HuilongX
> Cc: dts@dpdk.org
> Subject: Re: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
> 
> On 29 November 2016 at 09:39, Xu, HuilongX <huilongx.xu@intel.com> wrote:
> > Hi jianbo,
> > If we run unit pci test case, we must re-compile test app and enable
> CONFIG_RTE_APP_TEST_RESOURCE_TAR.
> > We will submit a patch for compile with enable
> CONFIG_RTE_APP_TEST_RESOURCE_TAR, and change test app name to test_pci.
> > Thanks  a lot
> >
> 
> Yes. But it depends on the user's requirement.
> If he want to enable CONFIG_RTE_APP_TEST_RESOURCE_TAR, he can change
> it by specifying a configuration patch with "dts --patch " argument.
>
  Yes, I will add a new configuration in dts for configuration compile switch.
  Then dts will scan current test suit list and finish compile, because some case need update compile switch and re-compile dpdk and 
  Restore compile switch for next case, this model too slowly.
 Thanks a lot
> 
> >> -----Original Message-----
> >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
> >> Sent: Friday, November 25, 2016 2:36 PM
> >> To: dts@dpdk.org
> >> Cc: Jianbo Liu
> >> Subject: [dts] [PATCH] tests unit_test_eal: fix test_pci unit test
> >>
> >> There is no app/test_pci, uses app/test instead.
> >>
> >> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> >> ---
> >>  tests/TestSuite_unit_tests_eal.py | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/TestSuite_unit_tests_eal.py
> >> b/tests/TestSuite_unit_tests_eal.py
> >> index d27ba39..07d423c 100644
> >> --- a/tests/TestSuite_unit_tests_eal.py
> >> +++ b/tests/TestSuite_unit_tests_eal.py
> >> @@ -158,7 +158,7 @@ class TestUnitTestsEal(TestCase):
> >>          Run pci autotest.
> >>          """
> >>          # should re-compile test app, this is only a demo. will
> >> implementation after framework support
> >> -        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" %
> >> self.target, "R.*T.*E.*>.*>" , self.start_test_time)
> >> +        self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
> >> "R.*T.*E.*>.*>" , self.start_test_time)
> >>          out = self.dut.send_expect("pci_autotest", "RTE>>",
> >> self.run_cmd_time)
> >>          self.dut.send_expect("quit", "# ")
> >>          self.verify("Test OK" in out, "Test failed")
> >> --
> >> 2.5.5
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-29  2:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-25  6:35 [dts] [PATCH] tests unit_test_eal: fix test_pci unit test Jianbo Liu
2016-11-29  1:39 ` Xu, HuilongX
2016-11-29  1:55   ` Jianbo Liu
2016-11-29  2:31     ` Xu, HuilongX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).