From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V2] filter lldp when sniff packet on tester
Date: Tue, 28 Feb 2017 01:39:45 +0000 [thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A4668D57305@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D67691@SHSMSX103.ccr.corp.intel.com>
Hi yong,
If we use sniff_packets for capture packet , we must update test case, because tcpdump capture packet style different sniff by scapy. I think we only add filter rule in checksum offload case for fileter lldp packet.
Thanks a lot
> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, February 23, 2017 3:07 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V2] filter lldp when sniff packet on tester
>
> Huilong,
> Please try sniff_packets in packet module. LLDP filter has been implemented
> in this function.
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Thursday, February 23, 2017 10:41 AM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V2] filter lldp when sniff packet on tester
> >
> > in new dpdk.org code, fortville nic will auto send lldp packet when
> > the nic setup so should filter lldp packet when sniff packet on tester
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> > tests/TestSuite_checksum_offload.py | 2 +-
> > tests/TestSuite_nvgre.py | 2 +-
> > tests/TestSuite_vxlan.py | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/TestSuite_checksum_offload.py
> > b/tests/TestSuite_checksum_offload.py
> > index 7989c14..1f01d47 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -105,7 +105,7 @@ class TestChecksumOffload(TestCase):
> > self.tester.send_expect("exit()", "#")
> >
> > self.tester.scapy_background()
> > - self.tester.scapy_append('p = sniff(filter="ether src %s",
> > iface="%s", count=%d)' % (sniff_src, rx_interface, len(packets_sent)))
> > + self.tester.scapy_append('p = sniff(filter="ether[12] != 0x88
> > + or
> > ether[13] != 0xcc", iface="%s", count=%d)' % (rx_interface,
> > len(packets_sent)))
> > self.tester.scapy_append('nr_packets=len(p)')
> > self.tester.scapy_append('reslist =
> >
> [p[i].sprintf("%IP.chksum%;%TCP.chksum%;%UDP.chksum%;%SCTP.chksum
> %")
> > for i in range(nr_packets)]')
> > self.tester.scapy_append('import string') diff --git
> > a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py index
> > 015aa9f..f6161e0 100644
> > --- a/tests/TestSuite_nvgre.py
> > +++ b/tests/TestSuite_nvgre.py
> > @@ -575,7 +575,7 @@ class TestNvgre(TestCase):
> > self.tester.send_expect("rm -rf %s" % config.capture_file, "# ")
> > # save the capture packet into pcap format
> > self.tester.scapy_background()
> > - self.tester.scapy_append('p=sniff(iface="%s",count=1,timeout=5)' %
> > self.tester_rx_iface)
> > + self.tester.scapy_append('p=sniff(filter="ether[12] != 0x88
> > + or
> > ether[13 != 0xcc]",iface="%s",count=1,timeout=5)' % self.tester_rx_iface)
> > self.tester.scapy_append('wrpcap(\"%s\", p)' %
> > config.capture_file)
> > self.tester.scapy_foreground()
> >
> > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> > 5fef9d9..6aa1164 100644
> > --- a/tests/TestSuite_vxlan.py
> > +++ b/tests/TestSuite_vxlan.py
> > @@ -446,7 +446,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> > # save the capture packet into pcap format
> > self.tester.scapy_background()
> > self.tester.scapy_append(
> > - 'p=sniff(iface="%s",count=1,timeout=5)' % self.recv_iface)
> > + 'p=sniff(filter="ether[12] != 0x88 or ether[13] !=
> > 0xcc",iface="%s",count=1,timeout=5)' % self.recv_iface)
> > self.tester.scapy_append(
> > 'wrpcap(\"%s\", p)' % config.capture_file)
> > self.tester.scapy_foreground()
> > --
> > 1.9.3
prev parent reply other threads:[~2017-02-28 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 2:40 xu,huilong
2017-02-23 7:06 ` Liu, Yong
2017-02-28 1:39 ` Xu, HuilongX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF2A19295B96364286FEB7F3DDA27A4668D57305@SHSMSX101.ccr.corp.intel.com \
--to=huilongx.xu@intel.com \
--cc=dts@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).