test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, HuilongX" <huilongx.xu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1 2/2] add dyanmic config bonding rss hash test case
Date: Thu, 2 Mar 2017 08:30:48 +0000	[thread overview]
Message-ID: <DF2A19295B96364286FEB7F3DDA27A4668D5857C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <58B7D3F5.9070203@intel.com>

Yes, we only should check testpmd log, because hash function check by other case,
In pmdrss_hash suite, we have five test case to check every hash function and hash key.

> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, March 02, 2017 4:13 PM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1 2/2] add dyanmic config bonding rss hash test
> case
> 
> Huilong,
> My question is that whether only check output log from testpmd is enough
> for function check? Should hash function be validated too?
> 
> On 03/02/2017 04:14 PM, Xu, HuilongX wrote:
> >>> +
> >> >Not sure set and get is enough for validation, hash function not checked
> here.
> > This case only check update slave0 hash function, and slave1 will auto sync
> hash function.
> > So there are two check point.
> > First point: salv0 and slav1 hash function must same Second point:
> > slav0 hash function update successful.

      reply	other threads:[~2017-03-02  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01  9:25 xu,huilong
2017-03-01 13:30 ` Liu, Yong
2017-03-02  8:14   ` Xu, HuilongX
2017-03-02  8:12     ` Liu, Yong
2017-03-02  8:30       ` Xu, HuilongX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF2A19295B96364286FEB7F3DDA27A4668D5857C@SHSMSX101.ccr.corp.intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).