From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 694F7201 for ; Thu, 2 Mar 2017 09:30:54 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2017 00:30:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,230,1484035200"; d="scan'208";a="231378375" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 02 Mar 2017 00:30:53 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Mar 2017 00:30:52 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Mar 2017 00:30:52 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Thu, 2 Mar 2017 16:30:49 +0800 From: "Xu, HuilongX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1 2/2] add dyanmic config bonding rss hash test case Thread-Index: AQHSkm2dDcWlrY5VRE6V6qdMbMa1eKF/dRIAgAG+87D//3qFgIAAitEg Date: Thu, 2 Mar 2017 08:30:48 +0000 Message-ID: References: <1488360320-42799-1-git-send-email-huilongx.xu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62D6C3AC@SHSMSX103.ccr.corp.intel.com> <58B7D3F5.9070203@intel.com> In-Reply-To: <58B7D3F5.9070203@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1 2/2] add dyanmic config bonding rss hash test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 08:30:54 -0000 Yes, we only should check testpmd log, because hash function check by other= case, In pmdrss_hash suite, we have five test case to check every hash function a= nd hash key. > -----Original Message----- > From: Liu, Yong > Sent: Thursday, March 02, 2017 4:13 PM > To: Xu, HuilongX; dts@dpdk.org > Subject: Re: [dts] [PATCH V1 2/2] add dyanmic config bonding rss hash tes= t > case >=20 > Huilong, > My question is that whether only check output log from testpmd is enough > for function check? Should hash function be validated too? >=20 > On 03/02/2017 04:14 PM, Xu, HuilongX wrote: > >>> + > >> >Not sure set and get is enough for validation, hash function not chec= ked > here. > > This case only check update slave0 hash function, and slave1 will auto = sync > hash function. > > So there are two check point. > > First point: salv0 and slav1 hash function must same Second point: > > slav0 hash function update successful.