Re: [dts] [PATCH V1] fix ring dump case failed

["Xu, HuilongX" <huilongx.xu@intel.com>]

Ok, I will chang my comment in test case and send V2 patch


> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, March 02, 2017 4:55 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V1] fix ring dump case failed
> 
> Huilong,
> 
> Just check source code and Fortville driver will create
> Ethernet_type/Fdir/Tunnel ring besides default ring. Ixgbe will create
> Fdir/L2_tn ring.
> Dump sequence maybe different between different drivers. Suggest change
> your comment, this is not cause by igb_uio.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Thursday, March 02, 2017 4:05 PM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V1] fix ring dump case failed
> >
> > when bind igb_uio on NIC. Newest testpmd will creat many ring.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  tests/TestSuite_unit_tests_dump.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_unit_tests_dump.py
> > b/tests/TestSuite_unit_tests_dump.py
> > index a39fcd1..c3515da 100644
> > --- a/tests/TestSuite_unit_tests_dump.py
> > +++ b/tests/TestSuite_unit_tests_dump.py
> > @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
> >          m = re.compile(r"%s" % match_regex, re.S)
> >          result = m.findall(out)
> >
> > -
> > -        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring
> > name failed")
> > +        #when we bind some nic with igb_uio. testpmd init will create
> > 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> > +        #other ring name about nic bus ID and ring type, so will not
> > check. we only check ring_dump function work ok
> > +        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring
> > name failed")
> >
> >      def test_mempool_dump(self):
> >          """
> > --
> > 1.9.3