From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 888F52904 for ; Wed, 28 Jun 2017 07:38:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 22:38:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,274,1496127600"; d="scan'208";a="1187795612" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 27 Jun 2017 22:38:39 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Jun 2017 22:38:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Jun 2017 22:38:38 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.197]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Wed, 28 Jun 2017 13:38:36 +0800 From: "Xu, HuilongX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1 1/3] add re_run parameter Thread-Index: AQHS6+VP+frvHeZUzkKqlXZdB+fhFqIyIXUAgAen80A= Date: Wed, 28 Jun 2017 05:38:35 +0000 Message-ID: References: <1498197394-16220-1-git-send-email-huilongx.xu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62E0D32B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62E0D32B@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1 1/3] add re_run parameter X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 05:38:41 -0000 Hi yong, Thanks a lot for your comments, I will changed it in next version > -----Original Message----- > From: Liu, Yong > Sent: Saturday, June 24, 2017 12:42 AM > To: Xu, HuilongX; dts@dpdk.org > Cc: Xu, HuilongX > Subject: RE: [dts] [PATCH V1 1/3] add re_run parameter >=20 > Huilong, > Rerun is not supposed to be the default action for failed cases. The defa= ult > value for rerun times should be zero, >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > > Sent: Thursday, June 22, 2017 10:57 PM > > To: dts@dpdk.org > > Cc: Xu, HuilongX > > Subject: [dts] [PATCH V1 1/3] add re_run parameter > > > > add a new re_run parameter for failed case re run time. the default > > value is 1. > > > > Signed-off-by: xu,huilong > > --- > > framework/dts.py | 7 +++++-- > > framework/main.py | 5 ++++- > > 2 files changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/framework/dts.py b/framework/dts.py index > > 369599d..48be694 100644 > > --- a/framework/dts.py > > +++ b/framework/dts.py > > @@ -424,7 +424,7 @@ def dts_run_suite(duts, tester, test_suites, target= ): > > def run_all(config_file, pkgName, git, patch, skip_setup, > > read_cache, project, suite_dir, test_cases, > > base_dir, output_dir, verbose, virttype, debug, > > - debugcase, commands): > > + debugcase, re_run, commands): > > """ > > Main process of DTS, it will run all test suites in the config fil= e. > > """ > > @@ -465,6 +465,9 @@ def run_all(config_file, pkgName, git, patch, > > skip_setup, > > if verbose is True: > > logger.set_verbose() > > > > + if re_run < 1: > > + re_run =3D 1 > > + > > logger.log_dir =3D output_dir > > log_handler =3D getLogger('dts') > > log_handler.config_execution('dts') > > @@ -520,7 +523,7 @@ def run_all(config_file, pkgName, git, patch, > > skip_setup, > > > > # init dut, tester crb > > duts, tester =3D dts_crbs_init(crbInsts, skip_setup, > > read_cache, project, base_dir, serializer, virttype) > > - > > + tester.set_re_run(re_run) > > # register exit action > > atexit.register(quit_execution, duts, tester) > > > > diff --git a/framework/main.py b/framework/main.py index > > a018af0..de9d54f 100755 > > --- a/framework/main.py > > +++ b/framework/main.py > > @@ -134,6 +134,9 @@ parser.add_argument('--debug', > > parser.add_argument('--debugcase', > > action=3D'store_true', > > help=3D'enable debug mode in the first case, user > > can further debug') > > +parser.add_argument('--re_run', > > + default=3D1, > > + help=3D'when case failed will re-run times, and > > +this > > value must >=3D 1') > > >=20 > Suggest add "type=3Dint" in re-run argument definition. >=20 > > parser.add_argument('--commands', > > action=3D'append', > > @@ -156,4 +159,4 @@ dts.run_all(args.config_file, args.snapshot, args.g= it, > > args.patch, args.skip_setup, args.read_cache, > > args.project, args.suite_dir, args.test_cases, > > args.dir, args.output, args.verbose,args.virttype, > > - args.debug, args.debugcase, args.commands) > > + args.debug, args.debugcase, args.re_run, args.commands) > > -- > > 1.9.3