test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance
@ 2022-08-23  5:59 Ke Xu
  2022-08-23  5:59 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Ke Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Ke Xu @ 2022-08-23  5:59 UTC (permalink / raw)
  To: dts; +Cc: qi.fu, ke1.xu

Function get_chksum_value_and_verify in test suite TSO case test_tso_tunneling 
 cannot verify checksum error. Duplicated call to packet.read_pcapfile will
 change the packet sequence stored in packet.pktgen.pkts, leading to a wrongly
 organized packet sequence writen to file, and fails the following checksum
 verifying.

The wrongly used methods also lead to a low effeciency. Duplicated call to
 packet.read_pcapfile will lengthen the packet sequence stored in
 packet.pktgen.pkts. Duplicated call to packet.save_pcapfile is also time
 consuming.

There is also a misuse of show method that *.show() will print a packet info,
 but will not return a string. The *.show will return a method object, and the
 following str(out) will turn the method object into a string, so here when use
 out = x.show, checksum looking up in str(out) it is equivalent to that in
 repr(x).

In the first commit, the checksum verifying problem is fixed.

In the second commit, this function is improved that the case running time is
 decresed by 2 minutes.

Ke Xu (2):
  tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify
    error
  tests/tso: modify get_chksum_value_and_verify to improve the
    performance

 tests/TestSuite_tso.py | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-23  6:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220721061314.984469-1-ke1.xu@intel.com>
2022-07-27  3:25 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Fu, Qi
     [not found] ` <20220721061314.984469-2-ke1.xu@intel.com>
2022-07-27  3:26   ` [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the execution efficiency Fu, Qi
2022-08-23  5:59 [dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance Ke Xu
2022-08-23  5:59 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Ke Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).