From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 87CD9A00B9 for ; Mon, 1 Apr 2019 03:14:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43E091B05; Mon, 1 Apr 2019 03:14:13 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 80EF510A3 for ; Mon, 1 Apr 2019 03:14:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 18:14:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,294,1549958400"; d="scan'208";a="312014247" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2019 18:14:09 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 18:14:09 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 18:14:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 09:14:07 +0800 From: "Zhu, WenhuiX" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions Thread-Index: AQHU53c1vsHSKDNc+0eE4jzV79WoxaYmf9FA Date: Mon, 1 Apr 2019 01:14:06 +0000 Message-ID: References: <1553839799-91625-1-git-send-email-wenhuix.zhu@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA542D4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA542D4@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi lijuan, 1. This is not a recent one, it has been there before. 2. The threshold is 2022. When it is greater than 2022, the open/stop port = is required. BR, Wenhui. -----Original Message----- From: Tu, Lijuan=20 Sent: Sunday, March 31, 2019 12:07 PM To: Zhu, WenhuiX ; dts@dpdk.org Cc: Zhu, WenhuiX Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment condi= tions Is this a new issue found in 19.05? if the answer is yes, which commit chan= ged ? As your commets, only 2048 require to open/stop port, does other mtu need t= o do that? > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Thursday, March 28, 2019 11:10 PM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment=20 > conditions >=20 > Set the mtu to 2048. First "stop port_id", then "open port_id" > The second package pkt_size needs to be added HEADER_SIZE['eth'] >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_userspace_ethtool.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 4208e0f..060529e 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# = ") > for mtu in mtus: > self.dut.send_expect("mtu %d %d" % (index, mtu),=20 > "EthApp>") > + self.dut.send_expect("open %s" % index, "EthApp>") > ori_rx_pkts, _ =3D self.strip_portstats(index) > pkt_size =3D mtu + HEADER_SIZE['eth'] > pkt =3D Packet(pkt_len=3Dpkt_size) > pkt.send_pkt(tx_port=3Dintf) > rx_pkts, _ =3D self.strip_portstats(index) > - self.verify(rx_pkts =3D=3D ori_rx_pkts, "Packet match mt= u not > forwarded as expected") > - pkt =3D Packet(pkt_len=3Dmtu + 1) > + self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Packet matc= h=20 > + mtu not > forwarded as expected") > + pkt =3D Packet(pkt_len=3Dmtu + 1 + HEADER_SIZE['eth']) > pkt.send_pkt(tx_port=3Dintf) > rx_pkts_over, _ =3D self.strip_portstats(index) > self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over mt= u=20 > should not be > forwarded") > + self.dut.send_expect("stop %s" % index, "EthApp>") >=20 > self.tester.send_expect("ifconfig %s mtu %d" % (intf,=20 > ori_mtu), "# ") >=20 > -- > 2.17.2