From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4568BA0487 for ; Mon, 29 Jul 2019 08:59:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BD9A1BF25; Mon, 29 Jul 2019 08:59:55 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D04F11BF10 for ; Mon, 29 Jul 2019 08:59:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2019 23:59:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,321,1559545200"; d="scan'208";a="176300772" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 28 Jul 2019 23:59:45 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jul 2019 23:59:45 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jul 2019 23:59:44 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 14:59:42 +0800 From: "Zhu, WenhuiX" To: "Ma, LihongX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio Thread-Index: AQHVRdfn1O9B4X1lg0usROyMUzlk6qbhKk1Q Date: Mon, 29 Jul 2019 06:59:42 +0000 Message-ID: References: <1564377735-117273-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" OK, Thanks for your advice. Thanks, Wenhui. -----Original Message----- From: Ma, LihongX=20 Sent: Monday, July 29, 2019 2:36 PM To: Zhu, WenhuiX ; dts@dpdk.org Cc: Zhu, WenhuiX Subject: RE: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio Hi, wenhui >From the patch, I think the only different of the command between igb_uio a= nd other driver is the "--iova-mode=3Dpa" Driver igb_uio has the param of "--iova-mode=3Dpa" and other did not. So I think maybe you can define a params of it. Eg :=20 self.iova_param =3D "" if self.drivername in ['igb_uio']: self.iova_param =3D "--iova-mode=3Dpa" ......... out =3D self.session_pri.send_expect("./examples/multi_process/hotplug_mp/= %s/hotplug_mp %s --proc-type=3Dauto" % (self.target, self.iova_param), "example>") -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui Sent: Monday, July 29, 2019 1:22 PM To: dts@dpdk.org Cc: Zhu, WenhuiX Subject: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio change test cases based on dpdk bbe29a9bd7ab6feab. Signed-off-by: zhuwenhui --- tests/TestSuite_hotplug_mp.py | 42 ++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/tests/TestSuite_hotplug_mp.py b/tests/TestSuite_hotplug_mp.py = index ff89164..62f1982 100644 --- a/tests/TestSuite_hotplug_mp.py +++ b/tests/TestSuite_hotplug_mp.py @@ -42,19 +42,35 @@ class TestHotplugMp(TestCase): """ Setup primary process and two secondary processes. """ - out =3D self.session_pri.send_expect( - "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type= =3Dauto" - % self.target, "example>") - self.verify("Auto-detected process type: PRIMARY" in out, - "Failed to setup primary process!") - for out in [self.session_sec_1.send_expect( - "./examples/multi_process/hotplug_mp/%s/hotplug_mp= --proc-type=3Dauto" - % self.target, "example>"), - self.session_sec_2.send_expect( - "./examples/multi_process/hotplug_mp/%s/hotplug_mp= --proc-type=3Dauto" - % self.target, "example>")]: - self.verify("Auto-detected process type: SECONDARY" in out, - "Failed to setup secondary process!") + if self.drivername =3D=3D "igb_uio": + out =3D self.session_pri.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplug_mp --iova-= mode=3Dpa --proc-type=3Dauto" + % self.target, "example>") + self.verify("Auto-detected process type: PRIMARY" in out, + "Failed to setup primary process!") + for out in [self.session_sec_1.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplu= g_mp --iova-mode=3Dpa --proc-type=3Dauto" + % self.target, "example>"), + self.session_sec_2.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplu= g_mp --iova-mode=3Dpa --proc-type=3Dauto" + % self.target, "example>")]: + self.verify("Auto-detected process type: SECONDARY" in out= , + "Failed to setup secondary process!") + + else: + out =3D self.session_pri.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-= type=3Dauto" + % self.target, "example>") + self.verify("Auto-detected process type: PRIMARY" in out, + "Failed to setup primary process!") + for out in [self.session_sec_1.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplu= g_mp --proc-type=3Dauto" + % self.target, "example>"), + self.session_sec_2.send_expect( + "./examples/multi_process/hotplug_mp/%s/hotplu= g_mp --proc-type=3Dauto" + % self.target, "example>")]: + self.verify("Auto-detected process type: SECONDARY" in out= , + "Failed to setup secondary process!") =20 def multi_process_quit(self): """ -- 2.17.2