From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D192FA04B6; Tue, 12 Nov 2019 16:34:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E4D32B99; Tue, 12 Nov 2019 16:34:44 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CE1DF2B96 for ; Tue, 12 Nov 2019 16:34:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 07:34:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,296,1569308400"; d="scan'208";a="405632545" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 12 Nov 2019 07:34:39 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 07:34:41 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 07:34:40 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 23:34:38 +0800 From: "Wang, Yinan" To: "Mo, YufengX" , "dts@dpdk.org" Thread-Topic: [dts][PATCH V3 1/3] ethtool_stats: update test plan Thread-Index: AQHVkIK5yY4DJt/AskKStJCfqd4dRaeHu0sw Date: Tue, 12 Nov 2019 15:34:38 +0000 Message-ID: References: <20191101070647.59192-1-yufengx.mo@intel.com> <20191101070647.59192-2-yufengx.mo@intel.com> In-Reply-To: <20191101070647.59192-2-yufengx.mo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V3 1/3] ethtool_stats: update test plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi Yufeng, The test plan you upstreamed can=1B$B!G=1B(Bt work as missing important par= ameters. Please take a look. --latencystats=3DN: enable latency and jitter statistcs monitoring on forwa= rding lcore id N. --bitrate-stats=3DN: set the logical core N to perform bit-rate calculation= . Br, yinan > -----Original Message----- > From: Mo, YufengX > Sent: 2019=1B$BG/=1B(B11=1B$B7n=1B(B1=1B$BF|=1B(B 15:07 > To: dts@dpdk.org; Wang, Yinan > Cc: Mo, YufengX > Subject: [dts][PATCH V3 1/3] ethtool_stats: update test plan >=20 >=20 > use testpmd xstat data as reference data to check proc info tool xstat da= ta. > update test plan content. >=20 > Signed-off-by: yufengmx > --- > test_plans/ethtool_stats_test_plan.rst | 66 ++++++++++++++++++-------- > 1 file changed, 45 insertions(+), 21 deletions(-) >=20 > diff --git a/test_plans/ethtool_stats_test_plan.rst > b/test_plans/ethtool_stats_test_plan.rst > index 13b5909..95f9e7a 100644 > --- a/test_plans/ethtool_stats_test_plan.rst > +++ b/test_plans/ethtool_stats_test_plan.rst > @@ -47,13 +47,20 @@ that DPDK supports. The idea behind this epic is two > fold as following. > - the retrieval of aggregate stats upon request (Top level stats). > - the retrieval of the extended NIC stats. > - grouping of stats logically so they can be retrieved per logical g= rouping. > - - the option to enable/disable the stats groups to retrieve similar = to set > private flags in ethtool. > + - the option to enable/disable the stats groups to retrieve similar = to set > + private flags in ethtool. >=20 > Prerequisites > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > 2xNICs (2 full duplex optical ports per NIC). One on dut, another one on= tester, > -link them together. Update two nics' firmware to latest version. > +link them together. Update two nics' firmware to latest version:: > + > + Tester DUT > + .-------. .-------. > + | port0 | <------------------> | port0 | > + | port1 | <------------------> | port1 | > + '-------' '-------' >=20 > Test cases > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > @@ -64,8 +71,8 @@ bind two ports:: >=20 > ./usertools/dpdk-devbind.py --bind=3Digb_uio 2> >=20 > -Test Case: xstat command set intergrity > ---------------------------------------- > +Test Case: xstat options > +------------------------ >=20 > check ``dpdk-procinfo`` tool support ``xstats`` command options. >=20 > @@ -80,7 +87,11 @@ steps: >=20 > #. boot up ``testpmd``:: >=20 > - .//app/testpmd -c 0x600006 -n 4 -- -i > --port-topology=3Dloop > + .//app/testpmd -c 0x3 -n 4 -- -i --port-topology=3Dloo= p > + > + testpmd> set fwd io > + testpmd> clear port xstats all > + testpmd> start >=20 > #. run ``dpdk-procinfo`` tool:: >=20 > @@ -88,25 +99,30 @@ steps: >=20 > #. check ``dpdk-procinfo`` tool output should contain upper options. >=20 > -Test Case: xstat command > ------------------------- > +Test Case: xstat statistic integrity > +------------------------------------ >=20 > -check if port extended statistics can get right data. > +check if port extended statistics can access by xstat name or xstat id. >=20 > steps: >=20 > #. boot up ``testpmd``:: >=20 > - .//app/testpmd -c 0x600006 -n 4 -- -i > --port-topology=3Dloop > + .//app/testpmd -c 0x3 -n 4 -- -i --port-topology=3Dloo= p > + > + testpmd> set fwd io > + testpmd> clear port xstats all > + testpmd> start >=20 > #. send udp packet of 64/72/128/256/512/1024 size to port 0/1:: >=20 > sendp([Ether()/IP()/UDP()/Raw('\0'*60)], iface=3D) >=20 > -#. run ``dpdk-procinfo`` tool with ``xstats`` option and check if all po= rt have > - a correct data of different size packet:: > +#. run ``dpdk-procinfo`` tool with ``xstats`` option and check if all po= rts > + extended statistics can access by xstat name or xstat id:: >=20 > - .//app/dpdk-procinfo -- -p 3 --xstats > + .//app/dpdk-procinfo -- -p 3 --xstats-id > + .//app/dpdk-procinfo -- -p 3 --xstats-name + name> >=20 > Test Case: xstat-reset command > ------------------------------ > @@ -117,7 +133,11 @@ steps: >=20 > #. boot up ``testpmd``:: >=20 > - .//app/testpmd -c 0x600006 -n 4 -- -i > --port-topology=3Dloop > + .//app/testpmd -c 0x3 -n 4 -- -i --port-topology=3Dloo= p > + > + testpmd> set fwd io > + testpmd> clear port xstats all > + testpmd> start >=20 > #. send udp packet of 64/72/128/256/512/1024 size to port 0/1:: >=20 > @@ -132,24 +152,26 @@ Test Case: xstat single statistic > --------------------------------- >=20 > check if port extended statistic name can be get by statistic id and che= ck > -related data's correctness. > +related data's correctness with testpmd xstat data. >=20 > steps: >=20 > #. boot up ``testpmd``:: >=20 > - .//app/testpmd -c 0x600006 -n 4 -- -i > --port-topology=3Dloop > - > -#. run ``dpdk-procinfo`` tool with ``xstats`` option to get all NIC exte= nded > - statistics parameters of port and use the output display sequence as > parameter > - index in the following search index:: > + .//app/testpmd -c 0x3 -n 4 -- -i --port-topology=3Dloo= p >=20 > - .//app/dpdk-procinfo -- -p 3 --xstats > + testpmd> set fwd io > + testpmd> clear port xstats all > + testpmd> start >=20 > #. send udp packet of 64/72/128/256/512/1024 size to port 0/1:: >=20 > sendp([Ether()/IP()/UDP()/Raw('\0'*60)], iface=3D) >=20 > +#. run test pmd ``show port xstats all`` to get testpmd port xstat data: > + > + testpmd> show port xstats all > + > #. run ``dpdk-procinfo`` tool with ``xstats-id`` option to get the stati= stic > name corresponding with the index id:: >=20 > @@ -158,4 +180,6 @@ steps: > #. run ``dpdk-procinfo`` tool with ``xstats-name`` option to get the sta= tistic > data corresponding with the statistic name:: >=20 > - .//app/dpdk-procinfo -- -p 3 --xstats-name > \ No newline at end of file > + .//app/dpdk-procinfo -- -p 3 --xstats-name + name> > + > +#. compare these proc info tool xstat values with testpmd xstat values. > \ No newline at end of file > -- > 2.21.0