Re: [dts] [‘dts-v1’ 7/9] add some pmd functions for tester to code the testpmd cases

["Jiajia, SunX" <sunx.jiajia@intel.com>]

> -----Original Message-----
> From: Liu, Yong
> Sent: Monday, May 18, 2015 4:46 PM
> To: Xu, HuilongX; Jiajia, SunX; dts@dpdk.org
> Subject: RE: [dts] [‘dts-v1’ 7/9] add some pmd functions for tester to
> code the testpmd cases
> 
> Some additional comments.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xu, HuilongX
> > Sent: Monday, May 18, 2015 4:29 PM
> > To: Jiajia, SunX; dts@dpdk.org
> > Subject: Re: [dts] [‘dts-v1’ 7/9] add some pmd functions for tester
> to
> > code the testpmd cases
> >
> > Hi Jiajia,
> > I have a comments at " def execute_cmd(self, pmd_cmd,
> expected='testpmd> ',
> > timeout=TIMEOUT "
> > Would you check it, thanks  a lot
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of sjiajiax
> > Sent: Monday, May 18, 2015 1:07 PM
> > To: dts@dpdk.org
> > Subject: [dts] [‘dts-v1’ 7/9] add some pmd functions for tester to
> code
> > the testpmd cases
> >
> > Signed-off-by: sjiajiax <sunx.jiajia@intel.com>
> > ---
> >  framework/pmd_output.py | 104
> > +++++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 102 insertions(+), 2 deletions(-)
> >
> > diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> > index 97274a5..642062f 100644
> > --- a/framework/pmd_output.py
> > +++ b/framework/pmd_output.py
> > @@ -32,6 +32,7 @@
> >  import os
> >  import re
> >  import dts
> > +from settings import TIMEOUT
> >
> >
> >  class PmdOutput():
> > @@ -42,6 +43,7 @@ class PmdOutput():
> >
> >      def __init__(self, dut):
> >          self.dut = dut
> > +        self.dut.testpmd = self
> >          self.rx_pkts_prefix = "RX-packets:"
> >          self.rx_missed_prefix = "RX-missed:"
> >          self.rx_bytes_prefix = "RX-bytes:"
> > @@ -87,10 +89,108 @@ class PmdOutput():
> >          return self.command
> >
> >      def start_testpmd(self, cores, param='', eal_param='', socket=0):
> > +        if "--txqflags" not in param:
> > +            param += "  --txqflags=0"
> > +        if socket == 0:
> > +            corelist = '0-3'
> > +        elif socket == 1:
> > +            corelist = '10-13'
> > +        else:
> > +            corelist = '0-3'
> 
> Should not hard code here, cpu may change between platforms.

Yes, I will try to change it in the next version.


> 
> 
> >          core_list = self.dut.get_core_list(cores, socket)
> >          self.coremask = dts.create_mask(core_list)
> > -        command = "./%s/app/testpmd -c %s -n %d %s -- -i %s" \
> > -            % (self.dut.target, self.coremask,
> > self.dut.get_memory_channels(), eal_param, param)
> > +        command = "taskset -c %s ./%s/app/testpmd -c %s -n %d %s --
> -
> > i %s" \
> > +            % (corelist, self.dut.target, self.coremask,
> > self.dut.get_memory_channels(), eal_param, param)
> >          out = self.dut.send_expect(command, "testpmd> ", 120)
> >          self.command = command
> >          return out
> >
> >      maybe we need delete parameter "verify=False" in function
> execute_cmd,
> >      when we used execute_cmd for exec testpmd cmdline, the parameter
> only
> > False.

Yes, I agree it.

> > +
> > +    def execute_cmd(self, pmd_cmd, expected='testpmd> ',
> timeout=TIMEOUT,
> > +                    alt_session=False, verify=False):
> > +        return self.dut.send_expect('%s' % pmd_cmd, expected,
> > timeout=timeout,
> > +                                    alt_session=alt_session,
> > verify=verify)
> > +
> > +    def get_value_from_string(self, key_str, regx_str, string):
> > +        """
> > +        Get some values from the given string by the regular
> expression.
> > +        """
> > +        pattern = r"(?<=%s)%s" % (key_str, regx_str)
> > +        s = re.compile(pattern)
> > +        res = s.search(string)
> > +        if type(res).__name__ == 'NoneType':
> > +            return ' '
> > +        else:
> > +            return res.group(0)
> > +
> > +    def get_detail_from_port_info(self, key_str, regx_str, port):
> > +        """
> > +        Get the detail info from the output of pmd cmd 'show port
> info
> > <port num>'.
> > +        """
> > +        out = self.dut.send_expect("show port info %d" % port,
> "testpmd>
> > ")
> > +        find_value = self.get_value_from_string(key_str, regx_str,
> out)
> > +        return find_value
> > +
> > +    def get_port_mac(self, port_id):
> > +        """
> > +        Get the specified port MAC.
> > +        """
> > +        return self.get_detail_from_port_info("MAC address: ", "([0-
> 9A-
> > F]{2}:){5}[0-9A-F]{2}", port_id)
> > +
> > +    def get_port_connect_socket(self, port_id):
> > +        """
> > +        Get the socket id which the specified port is connectting
> with.
> > +        """
> > +        return self.get_detail_from_port_info("Connect to socket: ",
> > "\d+", port_id)
> > +
> > +    def get_port_memory_socket(self, port_id):
> > +        """
> > +        Get the socket id which the specified port memory is
> allocated on.
> > +        """
> > +        return self.get_detail_from_port_info("memory allocation on
> the
> > socket: ", "\d+", port_id)
> > +
> > +    def get_port_link_status(self, port_id):
> > +        """
> > +        Get the specified port link status now.
> > +        """
> > +        return self.get_detail_from_port_info("Link status: ", "\d+",
> > port_id)
> > +
> > +    def get_port_link_speed(self, port_id):
> > +        """
> > +        Get the specified port link speed now.
> > +        """
> > +        return self.get_detail_from_port_info("Link speed: ", "\d+",
> > port_id)
> > +
> > +    def get_port_link_duplex(self, port_id):
> > +        """
> > +        Get the specified port link mode, duplex or siplex.
> > +        """
> > +        return self.get_detail_from_port_info("Link duplex: ", "\S+",
> > port_id)
> > +
> > +    def get_port_promiscuous_mode(self, port_id):
> > +        """
> > +        Get the promiscuous mode of port.
> > +        """
> > +        return self.get_detail_from_port_info("Promiscuous mode: ",
> "\S+",
> > port_id)
> > +
> > +    def get_port_allmulticast_mode(self, port_id):
> > +        """
> > +        Get the allmulticast mode of port.
> > +        """
> > +        return self.get_detail_from_port_info("Allmulticast mode: ",
> > "\S+", port_id)
> > +
> > +    def get_port_vlan_offload(self, port_id):
> > +        """
> > +        Function: get the port vlan settting info.
> > +        return value:
> > +            'strip':'on'
> > +            'filter':'on'
> > +            'qinq':'off'
> > +        """
> > +        vlan_info = {}
> > +        vlan_info['strip'] = self.get_detail_from_port_info(
> > +            "strip ", '\S+', port_id)
> > +        vlan_info['filter'] = self.get_detail_from_port_info(
> > +            'filter', '\S+', port_id)
> > +        vlan_info['qinq'] = self.get_detail_from_port_info(
> > +            'qinq\(extend\) ', '\S+', port_id)
> > +        return vlan_info
> > --
> > 1.9.0