From: "Jiajia, SunX" <sunx.jiajia@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM
Date: Wed, 27 May 2015 01:36:09 +0000 [thread overview]
Message-ID: <F21F274FCF2C0948830A3ED00345297734E546@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046816DE@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, May 26, 2015 5:07 PM
> To: Jiajia, SunX; dts@dpdk.org
> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM
>
> On 5/25/2015 5:14 PM, Jiajia, SunX wrote:
> > Hi Michael,
> >
> > Please see the comments below.
> >
> >> -----Original Message-----
> >> From: Qiu, Michael
> >> Sent: Monday, May 25, 2015 2:11 PM
> >> To: Jiajia, SunX; dts@dpdk.org
> >> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the
> VM
> >>
> >> On 5/22/2015 5:04 PM, Jiajia, Sun wrote:
> >>> From: sjiajiax <sunx.jiajia@intel.com>
>
> ...
>
> >>> + return 1
> >>> +
> >>> + def check_ports_available(self, pci_bus, pci_id):
> >>> + """
> >>> + Check that whether auto scanned ports ready to use
> >>> + """
> >>> + pci_addr = "%s:%s" % (pci_bus, pci_id)
> >>> + if pci_id == "8086:100e":
> >>> + return False
> >> Why here return false? better to give some comments.
> >>
> >> Also pci_id here should be pci_addr I think.
> > Because the e1000 network is commonly the control port for tester,
> > So it will be ignored defaultly.
>
> Does pci_addr needed here? It do nothing.
Yes, it does nothing, it should be removed, I will change it next version.
>
> Thanks,
> Michael
> >
> >>> + return True
> >>> +
> >>> + def scan_ports(self):
> >>> + """
> >>> + Scan ports information, for vm will always scan
> >>> + """
> >>> + self.scan_ports_uncached()
> >>> +
> >>> + def scan_ports_uncached(self):
> >>> + """
> >>> + Scan ports and collect port's pci id, mac adress, ipv6
> >>
> >
next prev parent reply other threads:[~2015-05-27 1:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 9:03 [dts] [PATCH v2 00/19] *** Enable virtualization test for dts framework *** Jiajia, Sun
2015-05-22 9:03 ` [dts] [PATCH v2 01/19] Abstract the NIC device as the single class NetDevice Jiajia, Sun
2015-05-22 9:03 ` [dts] [PATCH v2 02/19] Add a base module for virtual test Jiajia, Sun
2015-05-22 9:03 ` [dts] [PATCH v2 03/19] Add QEMU KVM module based on virt_base module for KVM test cases Jiajia, Sun
2015-05-22 9:03 ` [dts] [PATCH v2 04/19] Add a module to manage the host resource Jiajia, Sun
2015-05-22 9:03 ` [dts] [PATCH v2 05/19] Add a module to instantiate the VM Jiajia, Sun
2015-05-25 6:10 ` Qiu, Michael
2015-05-25 9:14 ` Jiajia, SunX
2015-05-26 9:07 ` Qiu, Michael
2015-05-27 1:36 ` Jiajia, SunX [this message]
2015-05-22 9:03 ` [dts] [PATCH v2 06/19] Add a third-party module of qemu-guest-agent to manage VM Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 07/19] Move some general functions from dts.py to utils.py and settings.py Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 08/19] Add and move some functions because of the virtual tests and network device instantiation Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 09/19] Change and add some functions to support virtual test Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 10/19] add some exceptions to support framwork to handle virtual test exceptions Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 11/19] Add some codes to support virtual test log Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 12/19] Add some codes to make session to support virtual test Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 13/19] Add some base functions to get the device info in the testpmd Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 14/19] Change some codes to support network device instantiation and virtualization test Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 15/19] Add some codes to support network instantiation in the tester module Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 16/19] Make test_case know its suite name Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 17/19] Add a global virtualization config and a config related to SRIOV KVM suite Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 18/19] Add a test plan of how to test SRIOV on the KVM ENV Jiajia, Sun
2015-05-22 9:04 ` [dts] [PATCH v2 19/19] Add a test suite to verify the SRIOV feature " Jiajia, Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F21F274FCF2C0948830A3ED00345297734E546@SHSMSX104.ccr.corp.intel.com \
--to=sunx.jiajia@intel.com \
--cc=dts@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).