From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8899B5A97 for ; Wed, 27 May 2015 03:38:37 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 26 May 2015 18:38:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,502,1427785200"; d="scan'208";a="735776612" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga002.jf.intel.com with ESMTP; 26 May 2015 18:38:35 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 27 May 2015 09:36:11 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0224.002; Wed, 27 May 2015 09:36:10 +0800 From: "Jiajia, SunX" To: "Qiu, Michael" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH v2 05/19] Add a module to instantiate the VM Thread-Index: AQHQlrGB1EgmBGknOU29zeQhHNJgkZ2PDWNQ Date: Wed, 27 May 2015 01:36:09 +0000 Message-ID: References: <1432285452-14286-1-git-send-email-sunx.jiajia@intel.com> <1432285452-14286-6-git-send-email-sunx.jiajia@intel.com> <533710CFB86FA344BFBF2D6802E6028604680F0A@SHSMSX101.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E60286046816DE@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046816DE@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 01:38:38 -0000 > -----Original Message----- > From: Qiu, Michael > Sent: Tuesday, May 26, 2015 5:07 PM > To: Jiajia, SunX; dts@dpdk.org > Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM >=20 > On 5/25/2015 5:14 PM, Jiajia, SunX wrote: > > Hi Michael, > > > > Please see the comments below. > > > >> -----Original Message----- > >> From: Qiu, Michael > >> Sent: Monday, May 25, 2015 2:11 PM > >> To: Jiajia, SunX; dts@dpdk.org > >> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the > VM > >> > >> On 5/22/2015 5:04 PM, Jiajia, Sun wrote: > >>> From: sjiajiax >=20 > ... >=20 > >>> + return 1 > >>> + > >>> + def check_ports_available(self, pci_bus, pci_id): > >>> + """ > >>> + Check that whether auto scanned ports ready to use > >>> + """ > >>> + pci_addr =3D "%s:%s" % (pci_bus, pci_id) > >>> + if pci_id =3D=3D "8086:100e": > >>> + return False > >> Why here return false? better to give some comments. > >> > >> Also pci_id here should be pci_addr I think. > > Because the e1000 network is commonly the control port for tester, > > So it will be ignored defaultly. >=20 > Does pci_addr needed here? It do nothing. Yes, it does nothing, it should be removed, I will change it next version. >=20 > Thanks, > Michael > > > >>> + return True > >>> + > >>> + def scan_ports(self): > >>> + """ > >>> + Scan ports information, for vm will always scan > >>> + """ > >>> + self.scan_ports_uncached() > >>> + > >>> + def scan_ports_uncached(self): > >>> + """ > >>> + Scan ports and collect port's pci id, mac adress, ipv6 > >> > >