Re: [dts] [PATCH] tests/short_live: fixes the result parsing issue

[Herbert Guan <Herbert.Guan@arm.com>]

Marvin,

Thanks for review.  V2 patch has been submitted just now with one comments:

>> 3) pkill for l2fwd and l3fwd need to wait a while for process quit
>L2fwd and L3fwd will do the same actions after received SIGINT or SIGTERM signal. There's no need to change the signal type.
The signal type logic is not changed in this patch.  While both l2fwd and l3fwd need some time to clean up after they received the signal.  The for loop shall wait about 2 seconds before starting another process of l2fwd/l3fwd.  So "time.sleep(2)" were added after sending pkill.

Thanks,
Herbert

-----Original Message-----
From: Liu, Yong [mailto:yong.liu@intel.com]
Sent: Monday, August 7, 2017 19:59
To: Herbert Guan <Herbert.Guan@arm.com>; dts@dpdk.org; jianbo.liu@linaro.org
Subject: Re: [dts] [PATCH] tests/short_live: fixes the result parsing issue

Thanks Herbert. Some comments below.

On 08/04/2017 03:18 PM, Herbert Guan wrote:
> Fixes below issues:
> 1) corrected the scapy reslut parsing string
> 2) ensure link up for testpmd and l3fwd
Suggest to waiting for LSC event or just wait some seconds for link status updated.

> 3) pkill for l2fwd and l3fwd need to wait a while for process quit
L2fwd and L3fwd will do the same actions after received SIGINT or SIGTERM signal. There's no need to change the signal type.

> Signed-off-by: Herbert Guan<herbert.guan@arm.com>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.