Re: [dts] [PATCH] framework: enhance the tcpdump direction option parsing Some tcpdump versions (such as 4.9.0-5.el7) is providing help message about direction option with both '-P' and '-Q': " [ -Q|-P in|out|inout ]". This format cause option parse fail. This

Re: [dts] [PATCH] framework: enhance the tcpdump direction option parsing Some tcpdump versions (such as 4.9.0-5.el7) is providing help message about direction option with both '-P' and '-Q': " [ -Q|-P in|out|inout ]". This format cause option parse fail. This

[Herbert Guan]

Sorry, this message has problems with subject.  I've corrected it and sent out another mail.

Please ignore this one.


Thanks,
Herbert

-----Original Message-----
From: Herbert Guan [mailto:herbert.guan@arm.com]
Sent: Monday, November 6, 2017 15:55
To: dts@dpdk.org
Cc: Herbert Guan <Herbert.Guan@arm.com>
Subject: [PATCH] framework: enhance the tcpdump direction option parsing Some tcpdump versions (such as 4.9.0-5.el7) is providing help message about direction option with both '-P' and '-Q': " [ -Q|-P in|out|inout ]". This format cause option parse fail. This ...

Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
 framework/packet.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/framework/packet.py b/framework/packet.py index 1907612..4ee51dd 100755
--- a/framework/packet.py
+++ b/framework/packet.py
@@ -787,14 +787,20 @@ def sniff_packets(intf, count=0, timeout=5, filters=[]):
     sniff all packets for certain port in certain seconds
     """
     param = ""
-    direct_param = r"(\s+)\[ -(\w) in\|out\|inout \]"
+    direct_param = r"(\s+)\[ (\S+) in\|out\|inout \]"
     tcpdump_help = subprocess.check_output("tcpdump -h; echo 0",
                                            stderr=subprocess.STDOUT,
                                            shell=True)
     for line in tcpdump_help.split('\n'):
         m = re.match(direct_param, line)
         if m:
-            param = "-" + m.group(2) + " in"
+            opt = re.search("-Q", m.group(2));
+            if opt:
+                param = "-Q" + " in"
+            else:
+                opt = re.search("-P", m.group(2));
+                if opt:
+                    param = "-P" + " in"

     if len(param) == 0:
         print "tcpdump not support direction chioce!!!"
--
1.8.3.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.