[dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

[dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

[pvukkisala]

From: Phanendra Vukkisala <pvukkisala@marvell.com>

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 framework/etgen.py |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/framework/etgen.py b/framework/etgen.py
index 212b9c2..a47d8cd 100644
--- a/framework/etgen.py
+++ b/framework/etgen.py
@@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection):
         out = self.send_expect("set chasId [ixGetChassisID %s]" % self.tclServerIP, "% ")
         self.chasId = int(out.strip())
 
-        self.send_expect("ixClearOwnership [list %s]" % string.join(
+        out = self.send_expect("ixClearOwnership [list %s]" % string.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port']) for item in self.ports], ' '), "% ", 10)
-        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
+        if out.strip()[-1] != '0':
+            return False
+        out = self.send_expect("ixTakeOwnership [list %s] force" % string.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port']) for item in self.ports], ' '), "% ", 10)
+        if out.strip()[-1] != '0':
+            return False
 
         return True
 
-- 
1.7.9.5

Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Friday, August 9, 2019 8:51 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  framework/etgen.py |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/etgen.py b/framework/etgen.py index
> 212b9c2..a47d8cd 100644
> --- a/framework/etgen.py
> +++ b/framework/etgen.py
> @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection):
>          out = self.send_expect("set chasId [ixGetChassisID %s]" %
> self.tclServerIP, "% ")
>          self.chasId = int(out.strip())
> 
> -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> +        out = self.send_expect("ixClearOwnership [list %s]" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port']) for item in
> self.ports], ' '), "% ", 10)
> -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> +        if out.strip()[-1] != '0':
> +            return False
> +        out = self.send_expect("ixTakeOwnership [list %s] force" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port']) for item in
> self.ports], ' '), "% ", 10)
> +        if out.strip()[-1] != '0':
> +            return False
> 
>          return True
> 
> --
> 1.7.9.5

Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

[Chen, Zhaoyan]

Thanks, Vukkisala,

Good fixing on etgen.py, however, we are going to remove the etgen API in future. 
Because there is a new pktgen API developed in DTS framework, 
which support not only IXIA but also TREX (SW). They have unified packet generator API,
so you need to modify nothing in the test suite, if you change the packet generator in test environment.

So we encourage you to try this new unified API for your performance test suite.
We have several documents for you to migrate from old etgen API under doc folder
- migrate_from_etgen_to_pktgen.rst
- pktgen_prog_guide.rst
- trex_known_issue.rst

Furthermore, your fixing seems also valid for the new pktgen API. Could you please generate 1 more patch for it?

BTW, how many test suite you are using with etgen in DTS? What are they?

Any problem, please let me know. Thanks.


Regards,
Zhaoyan Chen


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Monday, August 12, 2019 3:00 PM
> To: pvukkisala@marvell.com; dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com
> Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> > pvukkisala@marvell.com
> > Sent: Friday, August 9, 2019 8:51 PM
> > To: dts@dpdk.org
> > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> > <pvukkisala@marvell.com>
> > Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port
> > ownership
> >
> > From: Phanendra Vukkisala <pvukkisala@marvell.com>
> >
> > Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> > ---
> >  framework/etgen.py |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/framework/etgen.py b/framework/etgen.py index
> > 212b9c2..a47d8cd 100644
> > --- a/framework/etgen.py
> > +++ b/framework/etgen.py
> > @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection):
> >          out = self.send_expect("set chasId [ixGetChassisID %s]" %
> > self.tclServerIP, "% ")
> >          self.chasId = int(out.strip())
> >
> > -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> > +        out = self.send_expect("ixClearOwnership [list %s]" %
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> > +        if out.strip()[-1] != '0':
> > +            return False
> > +        out = self.send_expect("ixTakeOwnership [list %s] force" %
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > +        if out.strip()[-1] != '0':
> > +            return False
> >
> >          return True
> >
> > --
> > 1.7.9.5

Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

[Phanendra Vukkisala]

Hi Zhaoyan Chen,

Thanks, submitted the patch to fix in new pktgen API. 
I'm aware of changes in Introduction of new pktgen APIs in DTS. I yet to switch to new DTS source base, so I'm still using etgen. 

Regards,
Phanendra

-----Original Message-----
From: Chen, Zhaoyan <zhaoyan.chen@intel.com> 
Sent: Monday, August 12, 2019 12:59 PM
To: Tu, Lijuan <lijuan.tu@intel.com>; Phanendra Vukkisala <pvukkisala@marvell.com>; dts@dpdk.org
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood <fmasood@marvell.com>; Mo, YufengX <yufengx.mo@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: [EXT] RE: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership

External Email

----------------------------------------------------------------------
Thanks, Vukkisala,

Good fixing on etgen.py, however, we are going to remove the etgen API in future. 
Because there is a new pktgen API developed in DTS framework, which support not only IXIA but also TREX (SW). They have unified packet generator API, so you need to modify nothing in the test suite, if you change the packet generator in test environment.

So we encourage you to try this new unified API for your performance test suite.
We have several documents for you to migrate from old etgen API under doc folder
- migrate_from_etgen_to_pktgen.rst
- pktgen_prog_guide.rst
- trex_known_issue.rst

Furthermore, your fixing seems also valid for the new pktgen API. Could you please generate 1 more patch for it?

BTW, how many test suite you are using with etgen in DTS? What are they?

Any problem, please let me know. Thanks.


Regards,
Zhaoyan Chen


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Monday, August 12, 2019 3:00 PM
> To: pvukkisala@marvell.com; dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com
> Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port 
> ownership
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of 
> > pvukkisala@marvell.com
> > Sent: Friday, August 9, 2019 8:51 PM
> > To: dts@dpdk.org
> > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala 
> > <pvukkisala@marvell.com>
> > Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port 
> > ownership
> >
> > From: Phanendra Vukkisala <pvukkisala@marvell.com>
> >
> > Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> > ---
> >  framework/etgen.py |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/framework/etgen.py b/framework/etgen.py index 
> > 212b9c2..a47d8cd 100644
> > --- a/framework/etgen.py
> > +++ b/framework/etgen.py
> > @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection):
> >          out = self.send_expect("set chasId [ixGetChassisID %s]" % 
> > self.tclServerIP, "% ")
> >          self.chasId = int(out.strip())
> >
> > -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> > +        out = self.send_expect("ixClearOwnership [list %s]" % 
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> > +        if out.strip()[-1] != '0':
> > +            return False
> > +        out = self.send_expect("ixTakeOwnership [list %s] force" % 
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > +        if out.strip()[-1] != '0':
> > +            return False
> >
> >          return True
> >
> > --
> > 1.7.9.5