test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console
@ 2020-08-20  7:15 Xiao Qimai
  2020-08-20  7:41 ` Xiao, QimaiX
  2020-08-21  3:43 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2020-08-20  7:15 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

*. debug level is lower than info, when enable dts verbose, both info and debug
message will be print and logged twice

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/ssh_connection.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
index afeef1c..e096a9e 100644
--- a/framework/ssh_connection.py
+++ b/framework/ssh_connection.py
@@ -62,7 +62,7 @@ class SSHConnection(object):
     def send_expect(self, cmds, expected, timeout=15, verify=False):
         self.logger.info(cmds)
         out = self.session.send_expect(cmds, expected, timeout, verify)
-        self.logger.debug(out)
+        self.logger.debug(out.replace(cmds, ''))
         if type(self.history) is list:
             self.history.append({"command": cmds, "name": self.name, "output": out})
         return out
@@ -70,7 +70,7 @@ class SSHConnection(object):
     def send_command(self, cmds, timeout=1):
         self.logger.info(cmds)
         out = self.session.send_command(cmds, timeout)
-        self.logger.debug(out)
+        self.logger.debug(out.replace(cmds, ''))
         if type(self.history) is list:
             self.history.append({"command": cmds, "name": self.name, "output": out})
         return out
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console
  2020-08-20  7:15 [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console Xiao Qimai
@ 2020-08-20  7:41 ` Xiao, QimaiX
  2020-08-21  3:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Xiao, QimaiX @ 2020-08-20  7:41 UTC (permalink / raw)
  To: dts

Tested-by: Xiao Qimai <qimaix.xiao@intel.com>

Regards,
Xiao Qimai

> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Thursday, August 20, 2020 3:16 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [PATCH V1] fix enable verbose dts log duplicate info in file and
> console
> 
> *. debug level is lower than info, when enable dts verbose, both info and
> debug message will be print and logged twice
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/ssh_connection.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
> index afeef1c..e096a9e 100644
> --- a/framework/ssh_connection.py
> +++ b/framework/ssh_connection.py
> @@ -62,7 +62,7 @@ class SSHConnection(object):
>      def send_expect(self, cmds, expected, timeout=15, verify=False):
>          self.logger.info(cmds)
>          out = self.session.send_expect(cmds, expected, timeout, verify)
> -        self.logger.debug(out)
> +        self.logger.debug(out.replace(cmds, ''))
>          if type(self.history) is list:
>              self.history.append({"command": cmds, "name": self.name, "output":
> out})
>          return out
> @@ -70,7 +70,7 @@ class SSHConnection(object):
>      def send_command(self, cmds, timeout=1):
>          self.logger.info(cmds)
>          out = self.session.send_command(cmds, timeout)
> -        self.logger.debug(out)
> +        self.logger.debug(out.replace(cmds, ''))
>          if type(self.history) is list:
>              self.history.append({"command": cmds, "name": self.name, "output":
> out})
>          return out
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console
  2020-08-20  7:15 [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console Xiao Qimai
  2020-08-20  7:41 ` Xiao, QimaiX
@ 2020-08-21  3:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-08-21  3:43 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

> *. debug level is lower than info, when enable dts verbose, both info and debug
> message will be print and logged twice
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/ssh_connection.py | 4 ++--

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-21  3:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20  7:15 [dts] [PATCH V1] fix enable verbose dts log duplicate info in file and console Xiao Qimai
2020-08-20  7:41 ` Xiao, QimaiX
2020-08-21  3:43 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).