From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D19A8A05D3 for ; Fri, 26 Apr 2019 10:44:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5E511B12D; Fri, 26 Apr 2019 10:44:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 47BD61B101 for ; Fri, 26 Apr 2019 10:44:03 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3Q8Zx1t007512; Fri, 26 Apr 2019 01:44:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=EDw8440N1Jq3qaXCiX0uIVIUBNRoLYLlyGGrwM8HNU0=; b=MSdcQhDMg4bPCkI5j4E3brazqLor7DeMei/GPnl5qlUnkEtxxuM/SvHQbMajfy9ustrN Ezl4fYNGCX4LnhEIotkhjzVCuV6h+35ry0t9MXc+swrPH6auJYaKxXrPkL+Q1zkukNJ0 2jpPGdagcAtRpKe2XXQ8hhcNBgPumchY3BVbhCEItz1KXG0L6TEW+l4b/edO0L6b9lW6 vh0Wf/4uKxpHoyXHfz5KMGxbDz11A2mc21HgFDFR3y9VDUbk6pMMYdN3pD2Qb3cln1pM y/DR+QdcqgIQPFOw9cOYSn5qK5I5gxhVP1V21/dqBp99+ZwuTA2wipHqgeXJBInOrrOT oA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2s3g4kk128-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2019 01:44:02 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 26 Apr 2019 01:44:00 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.57) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 26 Apr 2019 01:44:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EDw8440N1Jq3qaXCiX0uIVIUBNRoLYLlyGGrwM8HNU0=; b=d6gUGSiCf8zFE7+Y4JBLJyQb/GfKSjTeivSJOe7Y/lBYoOAx/5PwKuqAbHmJ31VCvnYnEPArVAkiccjH8Xq+eY93i9w0gKsY1WIvpCNVYNmY0Xjpyj0kgufdCgwHlsrK/ND8nIu+CzDr022m6nrFpzilKYGmcmKciHcaP9z84ZQ= Received: from MWHPR18MB1615.namprd18.prod.outlook.com (10.173.244.17) by MWHPR18MB1119.namprd18.prod.outlook.com (10.173.124.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Fri, 26 Apr 2019 08:43:58 +0000 Received: from MWHPR18MB1615.namprd18.prod.outlook.com ([fe80::20f1:e0e4:c1ba:ab6b]) by MWHPR18MB1615.namprd18.prod.outlook.com ([fe80::20f1:e0e4:c1ba:ab6b%10]) with mapi id 15.20.1835.010; Fri, 26 Apr 2019 08:43:58 +0000 From: Narala Praneeth Reddy To: "Tu, Lijuan" , "dts@dpdk.org" CC: Faisal Masood , Vijaya Bhaskar Annayyolla Thread-Topic: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 Thread-Index: AQHU+gyBchXay+sTh0GV/b0Z8Xaxu6ZLKxAfgABXIACAAqHrEg== Date: Fri, 26 Apr 2019 08:43:58 +0000 Message-ID: References: <1555997061-21977-1-git-send-email-nareddy@marvell.com>, <8CE3E05A3F976642AAB0F4675D0AD20E0BA6575F@SHSMSX101.ccr.corp.intel.com> , <8CE3E05A3F976642AAB0F4675D0AD20E0BA66033@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA66033@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95a8dd8a-706f-474e-10e3-08d6ca23534c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MWHPR18MB1119; x-ms-traffictypediagnostic: MWHPR18MB1119: x-microsoft-antispam-prvs: x-forefront-prvs: 001968DD50 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(346002)(396003)(136003)(189003)(199004)(13464003)(71190400001)(68736007)(7736002)(33656002)(6506007)(107886003)(8936002)(52536014)(2906002)(11346002)(53546011)(446003)(81166006)(71200400001)(55236004)(54896002)(4326008)(54906003)(99286004)(236005)(110136005)(316002)(76176011)(102836004)(25786009)(7696005)(6606003)(186003)(9686003)(74316002)(53936002)(81156014)(66066001)(26005)(2501003)(6246003)(93886005)(19627405001)(14454004)(3846002)(486006)(229853002)(6116002)(478600001)(6436002)(97736004)(14444005)(73956011)(86362001)(256004)(66556008)(66476007)(5660300002)(66446008)(64756008)(66946007)(476003)(76116006)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR18MB1119; H:MWHPR18MB1615.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: L1fuDZ5/Us5fLEnCzJuLs/J8HO0Ix1o/OBvkWFuxieEcySpQ6kFZDubKIOtIfE8K8vmVRylN45zZowG1V3etAEMkfEh2H1jAhxHt2/UQ+VhoGRbHaKeAgzSIH2jV+p+rsg2wxV/U/NxRGwhpOtYvHzD68DJGVo59AJl+0882EFBeApjX6KA8bvW14W+DKn9CY//YTk+TwD56qVcyEeHIdUkyFmFbHqc9jBZT04WKSEeJQ4dZelpv5+a2yD5eBo1Rru29E9ArNk2Mq52q2FFQ8qiyx0XPQhB3XW1DQSTPviPcv2K59X6SmMWpqp4AX7//TraO0WhW2QpKVqgXuf3AxNFqFIowqwBlJm9txx4fnM8h1S4KgcxhMSF+kCjJdg8Uqc96uFIxoiTXT7TqcpVgFvwWOc0b9zcVK6TBd7B4V3s= Content-Type: multipart/alternative; boundary="_000_MWHPR18MB161574717BAE2F102F862755B93E0MWHPR18MB1615namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 95a8dd8a-706f-474e-10e3-08d6ca23534c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2019 08:43:58.7322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1119 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-26_05:, , signatures=0 Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --_000_MWHPR18MB161574717BAE2F102F862755B93E0MWHPR18MB1615namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable ________________________________ From: Tu, Lijuan Sent: Wednesday, April 24, 2019 10:01 PM To: Narala Praneeth Reddy; dts@dpdk.org Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pty= pe mapping is not supported for cavium_a063 From: Narala Praneeth Reddy [mailto:nareddy@marvell.com] Sent: Wednesday, April 24, 2019 4:27 AM To: Tu, Lijuan ; dts@dpdk.org Cc: Faisal Masood ; Vijaya Bhaskar Annayyolla Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pty= pe mapping is not supported for cavium_a063 Please find inline comments. ________________________________ From: Tu, Lijuan > Sent: Wednesday, April 24, 2019 1:10 AM To: Narala Praneeth Reddy; dts@dpdk.org Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specif= ic ptype mapping is not supported for cavium_a063 External Email ---------------------------------------------------------------------- > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > nareddy@marvell.com > Sent: Monday, April 22, 2019 10:24 PM > To: dts@dpdk.org > Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy > > > Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype > mapping is not supported for cavium_a063 > > From: Praneeth Reddy > > > Marking this test case as not applicable for cavium_a063 > > Signed-off-by: Praneeth Reddy > > --- > conf/test_case_checklist.json | 62 > +++++++++++++++++++++++++++++++++++++++- > tests/TestSuite_ptype_mapping.py | 2 +- > 2 files changed, 62 insertions(+), 2 deletions(-) > > diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.jso= n > index a1aa90b..decc946 100644 > --- a/conf/test_case_checklist.json > +++ b/conf/test_case_checklist.json > @@ -2200,5 +2200,65 @@ > "Bug ID": "", > "Comments": "the nic not support this case" > } > - ] > + ], > + "ptype_mapping_get": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_replace": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_reset": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_update": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ] > } > diff --git a/tests/TestSuite_ptype_mapping.py > b/tests/TestSuite_ptype_mapping.py > index 2771337..6e1fce1 100644 > --- a/tests/TestSuite_ptype_mapping.py > +++ b/tests/TestSuite_ptype_mapping.py > @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase): > Run at the start of each test suite. > """ > self.verify(self.nic in ['fortville_eagle', 'fortville_spirit', > - 'fortville_spirit_single', 'fortville_25g'], > + 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'], [Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything? [Praneeth] ptype_mapping test case get FAIL and mention NIC not supported w= henever complete DTS test suite ran for cavium_a063, inorder to make this t= est case as N/A, did following changes. 1. Added cavium_a063 to support list in TestS= uite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails a= nd moves to next step. 2. Later as I added all ptype_mapping test ca= ses in test_case_checklist.json, ptype_mapping test cases gets skip without= executing. Finally the result will be N/A instead of FAIL. Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063. [Lijuan] it=92s the right way to leverage item 2 to skip the test cases if = your NIC not support them. Cavium_a063 does not support ptype mapping, so i= t should not be added in the support list in TestSuite_ptype_mapping.py, th= at=92s why you get failure. If the cases don=92t be added in checklist, it = will go to test cases which including the verify statement, otherwise it wi= ll skip the test cases. That=92s why you get what you want when you tried item 2, but it doesn=92t = mean we could use item 1 improperly. Remove item 1 and keep item 2 is suita= ble for your purpose. [Praneeth] Ok thanks, for not supported test cases we will skip the test ca= se. > 'ptype mapping test can not support %s nic' % self.nic) > ports =3D self.dut.get_ports() > self.verify(len(ports) >=3D 1, "Insufficient ports for testing") > -- > 1.8.3.1 --_000_MWHPR18MB161574717BAE2F102F862755B93E0MWHPR18MB1615namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable




From: Tu, Lijuan <liju= an.tu@intel.com>
Sent: Wednesday, April 24, 2019 10:01 PM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd speci= fic ptype mapping is not supported for cavium_a063
 

 

 =

From:<= span style=3D"font-size:11.0pt; font-family:"Calibri",sans-serif"= > Narala Praneeth Reddy [mailto:nareddy@marvell.com]
Sent: Wednesday, April 24, 2019 4:27 AM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Cc: Faisal Masood <fmasood@marvell.com>; Vijaya Bhaskar Annayy= olla <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd speci= fic ptype mapping is not supported for cavium_a063

 

= Please find inline comments.

 

From: = Tu, Lijuan <lijuan.tu@intel.com>
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd= specific ptype mapping is not supported for cavium_a063

 

External Email

----------------------------------------------------------------------


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pt= ype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.= com>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy= @marvell.com>
> ---
>  conf/test_case_checklist.json    | 62
> ++++++++++++++= +++++++++++++++= ++++++++++-
>  tests/TestSuite_ptype_mapping.py |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.= json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
>            = ;  "Bug ID": "",
>            = ;  "Comments": "the nic not support this case"
>          }
> -    ]
> +    ],
> +     "ptype_mapping_get": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_replace": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_reset": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_update": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +     ]
>  }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
>          Run at the start= of each test suite.
>          ""&quo= t;
>          self.verify(self= .nic in ['fortville_eagle', 'fortville_spirit',
> -            'f= ortville_spirit_single', 'fortville_25g'],
> +           = ; 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything?=

[Pranee= th] ptype_mapping test case get FAIL and mention NIC not supported whenever= complete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes.
             &n= bsp;                1. Added cavium= _a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping = test cases doesn't get fails and moves to next step.
               =               2. Later as I added = all ptype_mapping test cases in test_case_checklist.json, ptype_mapping tes= t cases gets skip without executing. Finally the result will be N/A instead= of FAIL.
                &nbs= p;      Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063.

[Lijuan] it=92s the right w= ay to leverage item 2 to skip the test cases if your NIC not support them. = Cavium_a063 does not support ptype mapping, so it should not be added in the support list in TestSuite_ptype_mapping.py, tha= t=92s why you get failure. If the cases don=92t be added in checklist, it w= ill go to test cases which including the verify statement, otherwise it wil= l skip the test cases.

That=92s why you get what y= ou want when you tried item 2, but it doesn=92t mean we could use item 1 im= properly. Remove item 1 and keep item 2 is suitable for your purpose.

[Praneeth] Ok thanks, for not supported test cases we will sk= ip the test case.

>=             &nb= sp; 'ptype mapping test can not support %s nic' % self.nic)
>          ports =3D self.d= ut.get_ports()
>          self.verify(len(= ports) >=3D 1, "Insufficient ports for testing")
> --
> 1.8.3.1

--_000_MWHPR18MB161574717BAE2F102F862755B93E0MWHPR18MB1615namp_--