test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code
@ 2021-03-15 10:01 Ling Wei
  2021-03-16  1:37 ` Ling, WeiX
  2021-03-16  2:30 ` Zhao, HaiyangX
  0 siblings, 2 replies; 3+ messages in thread
From: Ling Wei @ 2021-03-15 10:01 UTC (permalink / raw)
  To: dts; +Cc: Ling Wei

Delete self.stop_send_pkts_on_tester() step in tear_down,
because of framework will auto stop pktgen.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_vhost_user_live_migration.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vhost_user_live_migration.py b/tests/TestSuite_vhost_user_live_migration.py
index 915fa596..d5d1af65 100644
--- a/tests/TestSuite_vhost_user_live_migration.py
+++ b/tests/TestSuite_vhost_user_live_migration.py
@@ -449,7 +449,7 @@ class TestVhostUserLiveMigration(TestCase):
     def tear_down(self):
         self.destroy_vm_env()
         # stop send packet on tester
-        self.stop_send_pkts_on_tester()
+        # self.stop_send_pkts_on_tester()
         self.duts[0].send_expect('killall -s INT qemu-system-x86_64', '#')
         self.duts[1].send_expect('killall -s INT qemu-system-x86_64', '#')
         pass
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code
  2021-03-15 10:01 [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code Ling Wei
@ 2021-03-16  1:37 ` Ling, WeiX
  2021-03-16  2:30 ` Zhao, HaiyangX
  1 sibling, 0 replies; 3+ messages in thread
From: Ling, WeiX @ 2021-03-16  1:37 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

> -----Original Message-----
> From: Ling, WeiX <weix.ling@intel.com>
> Sent: Monday, March 15, 2021 06:02 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/vhost_user_live_migration:delete invalid
> code

Tested-by: Wei Ling <weix.ling@intel.com>

[-- Attachment #2: TestVhostUserLiveMigration.log --]
[-- Type: application/octet-stream, Size: 787334 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code
  2021-03-15 10:01 [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code Ling Wei
  2021-03-16  1:37 ` Ling, WeiX
@ 2021-03-16  2:30 ` Zhao, HaiyangX
  1 sibling, 0 replies; 3+ messages in thread
From: Zhao, HaiyangX @ 2021-03-16  2:30 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling Wei
> Sent: Monday, March 15, 2021 18:02
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid
> code
> 
> Delete self.stop_send_pkts_on_tester() step in tear_down, because of
> framework will auto stop pktgen.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>
> ---
>  tests/TestSuite_vhost_user_live_migration.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_user_live_migration.py
> b/tests/TestSuite_vhost_user_live_migration.py
> index 915fa596..d5d1af65 100644
> --- a/tests/TestSuite_vhost_user_live_migration.py
> +++ b/tests/TestSuite_vhost_user_live_migration.py
> @@ -449,7 +449,7 @@ class TestVhostUserLiveMigration(TestCase):
>      def tear_down(self):
>          self.destroy_vm_env()
>          # stop send packet on tester
> -        self.stop_send_pkts_on_tester()
> +        # self.stop_send_pkts_on_tester()

Hi, wei,
If the code should removed, just delete it instead of commentting it, and the comments should be removed too.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-16  2:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 10:01 [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code Ling Wei
2021-03-16  1:37 ` Ling, WeiX
2021-03-16  2:30 ` Zhao, HaiyangX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git