test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Chen, BoX C" <box.c.chen@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>,
	"Chen, LingliX" <linglix.chen@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic
Date: Mon, 22 Mar 2021 08:40:32 +0000	[thread overview]
Message-ID: <SN6PR11MB3101C5B7D1C9E440136B9962D9659@SN6PR11MB3101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <e2b54a2786a849ed99cd913cbed3af1d@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> Sent: March 10, 2021 14:03
> To: Chen, LingliX <linglix.chen@intel.com>; dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Chen Lingli
> > Sent: 2021年3月6日 1:45
> > To: dts@dpdk.org
> > Cc: Chen, LingliX <linglix.chen@intel.com>
> > Subject: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> > foxville_nic
> >
> > From: ChenLingli <linglix.chen@intel.com>
> >
> > updated the rx-offloads for foxville_nic
> >
> > Signed-off-by: ChenLingli <linglix.chen@intel.com>
> > ---
> >  tests/TestSuite_pmdrssreta.py | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_pmdrssreta.py
> > b/tests/TestSuite_pmdrssreta.py index
> > 4dd3a5a5..09dd2f55 100644
> > --- a/tests/TestSuite_pmdrssreta.py
> > +++ b/tests/TestSuite_pmdrssreta.py
> > @@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
> >                  self.pmdout.start_testpmd(
> >                      "all", "--rxq=%d --txq=%d
> > --rx-offloads=0x00080000 " % (queue, queue), socket=self.ports_socket)
> >              else:
> > -                self.pmdout.start_testpmd(
> > -                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> > +                if self.nic == 'foxville':
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)
> 
> What does the offload mean ?
> 

offloads=0x80000 is a feature added later, the igc pmd did not do relevant adaptation.
It's DPDK bug, please reject this patch.

> > +                else:
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d
> > + --rx-offloads=0x00080000" % (queue, queue),
> > + socket=self.ports_socket)
> >
> >              for iptype, rsstype in list(iptypes.items()):
> >                  self.dut.send_expect("set verbose 8", "testpmd> ")
> > --
> > 2.25.1


      reply	other threads:[~2021-03-22  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 17:44 Chen Lingli
2021-03-05  9:49 ` Chen, LingliX
2021-03-10  6:02 ` Tu, Lijuan
2021-03-22  8:40   ` Chen, BoX C [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3101C5B7D1C9E440136B9962D9659@SN6PR11MB3101.namprd11.prod.outlook.com \
    --to=box.c.chen@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=linglix.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).