From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0056.outbound.protection.outlook.com [157.56.112.56]) by dpdk.org (Postfix) with ESMTP id AA4ED2FDD for ; Thu, 29 Oct 2015 10:58:11 +0100 (CET) Received: from VI1PR05MB1582.eurprd05.prod.outlook.com (10.164.86.16) by VI1PR05MB1582.eurprd05.prod.outlook.com (10.164.86.16) with Microsoft SMTP Server (TLS) id 15.1.306.13; Thu, 29 Oct 2015 09:58:10 +0000 Received: from VI1PR05MB1582.eurprd05.prod.outlook.com ([10.164.86.16]) by VI1PR05MB1582.eurprd05.prod.outlook.com ([10.164.86.16]) with mapi id 15.01.0306.003; Thu, 29 Oct 2015 09:58:10 +0000 From: Raslan Darawsheh To: "Xu, HuilongX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 1/6] framework: crb :add some parameters and check_Mellanox_pci function to identify mellanox device Thread-Index: AQHREH3w843ExTKm50eynoTaC3FvTZ6Bt7TwgABnFDCAAAy30IAABZGA Date: Thu, 29 Oct 2015 09:58:09 +0000 Message-ID: References: <1445926076-31279-1-git-send-email-rasland@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.225.180.234] x-microsoft-exchange-diagnostics: 1; VI1PR05MB1582; 5:uEpkJIRs38nD0+WztiLFolEQ+fu06MjGNkZRHwCJlJaBKYroxwaItoBKY02GGFBtY53cERGH3XWqzd7IcbffG+S3eclElZbZpuhCeerQUQc9YM9/yVVHq0E6A7gEUbDYWhoDiQXkck6GJ82exvRgdQ==; 24:DsLKyQv189c4rDlUupdaEx4p7zw85wIIy2ntgp1PseCYkstflmd3Ar9la8Z6/rRF2zRS6smMM3Os1nQny5J5xb50hNo/8JeBBYwD++lnrsw=; 20:dy9nLIIEkFMNI6OWOOJAInBBjtKBnx8DIt5GznI9qlmNOR2cqCXy+BemXYBO67IH4WHuvkV3BxL4CSkjC9MlnA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB1582; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(34787635062028); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046)(102215026); SRVR:VI1PR05MB1582; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1582; x-forefront-prvs: 0744CFB5E8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(199003)(377454003)(189002)(93886004)(5001960100002)(77096005)(5002640100001)(87936001)(189998001)(11100500001)(5003600100002)(33656002)(2900100001)(5008740100001)(10400500002)(92566002)(74316001)(102836002)(2501003)(2950100001)(5004730100002)(5007970100001)(81156007)(19580395003)(106116001)(66066001)(40100003)(122556002)(50986999)(54356999)(76176999)(101416001)(105586002)(106356001)(76576001)(86362001)(5001770100001)(97736004)(19580405001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1582; H:VI1PR05MB1582.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2015 09:58:10.0506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1582 Cc: "rdarawsheh@asaltech.com" Subject: Re: [dts] [PATCH 1/6] framework: crb :add some parameters and check_Mellanox_pci function to identify mellanox device X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 09:58:12 -0000 Hi Xu, HuilongX, I think you need to double check the patch, since in this patch it doesn't = change anything to this function.=20 Kindest regards=20 Raslan Darawsheh -----Original Message----- From: Xu, HuilongX [mailto:huilongx.xu@intel.com]=20 Sent: Thursday, October 29, 2015 10:48 AM To: Raslan Darawsheh ; dts@dpdk.org Cc: rdarawsheh@asaltech.com Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and chec= k_Mellanox_pci function to identify mellanox device Hi Darawsheh, Your changed can't work on FreeBSD OS, but function "get_session_output" in= crb.py need work on FreeBSD os. Thanks a lot > -----Original Message----- > From: Raslan Darawsheh [mailto:rasland@mellanox.com] > Sent: Thursday, October 29, 2015 4:05 PM > To: Xu, HuilongX; dts@dpdk.org > Cc: rdarawsheh@asaltech.com > Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and=20 > check_Mellanox_pci function to identify mellanox device >=20 > Hi Xu, HuilongX , >=20 > From what I changed it seems that it's only executed over the linux OS. > And there are an already "lspci" command executed inside the function. > Can you explain more ? > Kindest regards > Raslan Darawsheh >=20 > -----Original Message----- > From: Xu, HuilongX [mailto:huilongx.xu@intel.com] > Sent: Thursday, October 29, 2015 4:01 AM > To: Raslan Darawsheh ; dts@dpdk.org > Cc: rdarawsheh@asaltech.com > Subject: RE: [dts] [PATCH 1/6] framework: crb :add some parameters and=20 > check_Mellanox_pci function to identify mellanox device >=20 >=20 > Hi darawsheh, > Pls see my comments as below., thanks a lot > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Raslan=20 > > Darawsheh > > Sent: Tuesday, October 27, 2015 2:08 PM > > To: dts@dpdk.org > > Cc: rdarawsheh@asaltech.com > > Subject: [dts] [PATCH 1/6] framework: crb :add some parameters and=20 > > check_Mellanox_pci function to identify mellanox device > > > > From: Raslsn Darawsheh > > > > Signed-off-by: Raslsn Darawsheh > > --- > > framework/crb.py | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/framework/crb.py b/framework/crb.py index=20 > > fcbd7d9..0acec3b 100644 > > --- a/framework/crb.py > > +++ b/framework/crb.py > > @@ -33,7 +33,7 @@ import time > > import dts > > import re > > import os > > -from settings import TIMEOUT, IXIA > > +from settings import TIMEOUT, IXIA, NICS > > > > """ > > CRB (customer reference board) basic functions and handlers @@=20 > > -54,6 > > +54,9 @@ class Crb(object): > > self.skip_setup =3D False > > self.serializer =3D serializer > > self.ports_info =3D None > > + self.isMellanox =3D False > > + self.mellanoxPortCount =3D 0 > > + self.mellanoxCardType =3D None > > > > def send_expect(self, cmds, expected, timeout=3DTIMEOUT, > > alt_session=3DFalse, verify=3DFalse): > > @@ -79,6 +82,19 @@ class Crb(object): > > > > return self.session.send_command(cmds, timeout) > > > > + def check_Mellanox_pci(self,pci_bus,pci_id): > > + """ > > + check if the PCI is Mellanox device or not > > + its used to set a flag to handle Mellanox ports differently > > + """ > > + out =3D self.send_expect("lspci -nn | grep -i " + pci_bus, "#= ") > > + if "Mell" in out: > > + self.isMellanox =3DTrue > > + if NICS['ConnectX_4'] in out: > > + self.mellanoxCardType =3D "cx4" > > + else: > > + self.mellanoxCardType =3D "cx3" > > + > > def get_session_output(self, timeout=3DTIMEOUT): > > """ > > Get session output message before timeout @@ -196,6 +212,11=20 > > @@ class Crb(object): > > rexp =3D r"([\da-f]{2}:[\da-f]{2}.\d{1}) .*Eth.*?ernet > > .*?([\da- f]{4}:[\da-f]{4})" > > pattern =3D re.compile(rexp) > > match =3D pattern.findall(out) > Could you not changed this function? because it not about dts feature=20 > It only a ssh session function, when you exec "lspci" command, freebsd=20 > os not support. > So some case will failed on freebesd. > > + out =3D self.send_expect( > > + "lspci -nn ", "# ", alt_session=3DTrue) > > + rexp =3D r"([\da-f]{2}:[\da-f]{2}.\d{1}) Network .*?([\da- > > f]{4}:[\da-f]{4})" > > + pattern =3D re.compile(rexp) > > + match +=3D pattern.findall(out) > > self.pci_devices_info =3D [] > > for i in range(len(match)): > > self.pci_devices_info.append((match[i][0],=20 > > match[i][1])) > > -- > > 1.8.3.1