From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0305E43033; Fri, 11 Aug 2023 13:16:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C355740F16; Fri, 11 Aug 2023 13:16:10 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2091.outbound.protection.outlook.com [40.107.94.91]) by mails.dpdk.org (Postfix) with ESMTP id D917640E03 for ; Fri, 11 Aug 2023 13:16:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFcIVtvSBoTmZ9KRi/Uw8FJ6dTO+B9H9Cb74FEBM6gVRpt7hW8S3BvtSQo+ndix5uvBf3jZxP4SjJ+zdZq5XTeRgj84Iom5arSPimCNMoSKSzwfIRPLxz1lYF62Ulkl5NJ2/fcXAGzWV4ipFyjMLm48jZ+xVmdCl/kUx1myaOp6CZqlX3zW04GBdQhGWE5iR1RU4hW3mptLo0P7Dy7QG0nSIE0FsBzfmGItM8ogGn4T1N4dP8MgCYuDHBIzdNsNk5tsaFr9lCyexZbAa2jObIEDDbk9nPTkkrQqAXVf1QOD1yhHW9eeWsIbe224IfD8W+xUKUeflr9SSydigeuEJyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q051m2O0HCCxnthWmg3C/XCuzol/GWWNj0ppTyt+f00=; b=H9JpXM6modzVmZZYZ7Syz1UZ4ZnzrOb9bGgY1hv6IMe2zB/dk63FvY6mFRu/Sfo9DwmLz6Nxzu9vgrkYjP1z/uTHRnAhUXzCRMp3jE4fvLSu0Eq7jZeiDShz9f3NILLBKo0LOvo3LQROwFa4QI6JzhzWNWn4oAFX0jOVBD1Y6AJiJ4bcZQd123A5IxEEKZ1Pdzr7PODC17pIkjGg8oFS9/qaxL1HrKwy1MQPWenvlX5U4XuGzNWtJvW5JHmlpi8iUQ1F2sN5aqpgZRq5alTYvZW2RZyqIDuYIx1IkBHBCL6q83qLCBRQHyPUsUGhgFRvGUQV2CqA6myZAsnwfXVWJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q051m2O0HCCxnthWmg3C/XCuzol/GWWNj0ppTyt+f00=; b=uka6Vo/lkPhW23xoWGXFXBpgHYbC5UaCWAGWk1dPED92MhIA4BnAgG1Fp6wiRqKGp6dqT7RC+wjJKHgtUAy6gGEJEqEOCAJwM8jhTgy7o9n9wxAGRlj9+7R3em1DsWTpPqgpbZrKIKa+RsKtLk2vzOUOZxPiJ4Z3F/KDA95lVt4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) by PH0PR13MB5876.namprd13.prod.outlook.com (2603:10b6:510:168::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Fri, 11 Aug 2023 11:16:05 +0000 Received: from BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::3a7d:2ee9:4391:9ef6]) by BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::3a7d:2ee9:4391:9ef6%4]) with mapi id 15.20.6678.020; Fri, 11 Aug 2023 11:16:05 +0000 Date: Fri, 11 Aug 2023 13:15:57 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: dts@dpdk.org Cc: oss-drivers@corigine.com, Qin Ke , Dano Teixeira Subject: Re: [PATCH] tests/firmware_version: add case of nfp driver Message-ID: References: <20230703191629.31297-1-niklas.soderlund@corigine.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230703191629.31297-1-niklas.soderlund@corigine.com> X-ClientProxiedBy: GVYP280CA0003.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:fa::18) To BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4804:EE_|PH0PR13MB5876:EE_ X-MS-Office365-Filtering-Correlation-Id: ead23e9a-0f36-44d3-83e0-08db9a5c5aaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V84XXWQK2Vx+RHSusq6wwj+ARLbsY1L/InT0NsX2jDOjFt6sVox0o72JF1q220hau/4R4lMwUDaVfnNb7W9dtvHhEQ5kP3BVdlmDA0GPPQK/pQAOlI4M+4/So7u3L5huqen15Ky7So8136HFxnCSBScuJt6x3M2EgbKbuz71AkORRxAn+4ukIupGHNMpcKJyPegGAz+iFuHAXSdZrPswIiFdEo4iX0DuOmVL2nbjZ1nIFpvY08VCb4OYzwIuKwtzhMVyfpUcCucd9WLBYp6UVYw3A0pTiIJ2jYwvYuT58XYDvvgtrK+zNKn6u0ywjJaaUWxDTRNoAJRpVnMqaf4kI++WlN/YBCQgUP5pW57ebditzgxmfo2vAZjpjnQMPnMDeBIgaKH7fDF5M2rIalSEDu3PU8VJCUk6d+wLnltYunRCOw1wXIRBvkbRdPUCOOFlWnZ35ucInyBzqEf5kxZ/A0jzNa0lapKqZsC/0VQXVMAleN9qAvpHYoRmF/V7sOCGoSLItTBa5l8e3ZxZTMvSo/hUsf8jkxQOiOzfZVkmlGBflIfiPZrMjTCHsohtokHgowJ7XNANbh1jbIkRWj1I0I1DzuZU5ZeDhZagXzT/JzlCPevkhAU4ztA1PHIH/foGrFs4ix7tQcXKvKzQbNCuE0/MQmaJWMQgFrBHqfgidUxlXYWMEPaDbZbN70NGJpckpu3b2kgn2xJZYKPPnP2gCg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(39830400003)(376002)(346002)(366004)(186006)(1800799006)(451199021)(6916009)(41300700001)(8936002)(5660300002)(26005)(107886003)(53546011)(6506007)(66476007)(316002)(66556008)(66946007)(4326008)(8676002)(2906002)(54906003)(38350700002)(9686003)(6486002)(6512007)(478600001)(86362001)(38100700002)(52116002)(6666004)(83380400001)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVZweWNTZzBpWFlxUzRIY2hvTEdpdDZEMVUySFNOcUVOaUtJODdKYTBzNExp?= =?utf-8?B?UStUM1hIaVh5a2l6MGdncTcvOUI4dTBTSjFWa3hoRDdXNlp3NjQ2UXZxeEJH?= =?utf-8?B?V00vbzZON29vVGJ5OHNheFZKSDNMczdEOHVQS2J1blZFU3lKTmdFVWExbHRa?= =?utf-8?B?VFRrR3d0SFZkSUZUSWJUYTNrRy81RGYrTFY0RGFHRzR5T25iYW1vSHN0Nkwx?= =?utf-8?B?VHR1TWw3c0xSc2tTS09EbFh0citTNG1VN0kwQUVxUnFSejZxd054U1VWOWkv?= =?utf-8?B?NmNTYm5PQTUyY2tibCtITjBRNEtUWGZNUmpxcUswc3ZBSFpQZUNIRE4vTXZU?= =?utf-8?B?cVRUWlBIdjI1ZlVLQktDcVhiTlhhRVVsZjczaUo3K01JeDlYM0VHQnJKdWIy?= =?utf-8?B?ZE9pWURvUnBvQlY2a1BWZ1pXcXRhMkFBaWRSTWxRTG9MdTNZTzR3eFo4cDdD?= =?utf-8?B?Q01CVEVZazlOSXVPU1RCTnZVbTdlUDZKc0NMZHB2SmdLbmFlZXkrbTE2VEox?= =?utf-8?B?NGRBZ2o3eGhYdzhZbW1sNStNY3gySkt2KzREbTNEYlRRb1N4UW1NL2NlbDNR?= =?utf-8?B?SitqMkdzNG54dHZPVzZjSFNwY0NCaDRuSzF5TDcxK01Ma2VvTzBURGJRYlNp?= =?utf-8?B?L01nRGczT0QvaUVvc3V1K1lHZUlTQXNROXV3b1cwMStHc0FKZ01wMkhWcG5V?= =?utf-8?B?ZnU2WjJrdUJhWFUxRytWZnBFY3Btdy9PT2NXRmJvcUZxcURjdHdsT1lBTUVJ?= =?utf-8?B?MTJXajJRMjk3VThtdU5iL2pwREJlSGJqR1haM3BTMGkvK1NocG5Ga2Vpd0tQ?= =?utf-8?B?WUh5OEszYlRHNzNRWFRQeThhaTVFZCtCUnBiM0ZDWkRrMG9TWFd3R0JJZlU4?= =?utf-8?B?djM2bnJVaTJmVk0zRCtTeG5PTDd2TXNEa3dwRitzL1ZJSzQrUzh0MFpFV2pQ?= =?utf-8?B?KzhxQTRxM3RZTUdFcFJaOFlGM0tHazFDWU1vc1dMNEVZa1gvcXp5SmlPUThF?= =?utf-8?B?a3lNYUQwWHFtdXAyall6NzJrRjVva2VONittUFQyVXZIYXpoMTV6ZDJNNjN4?= =?utf-8?B?aVhhak1BUk1ZTDU3STJ0RFM3TGwrYSthbmVPdy9sOUJVcWxPdnExaTlGUFla?= =?utf-8?B?Y08xZ3FxMVZBblRWcjRiSzY1b3RxVGtVUEMvbE1YNVBrb0JZSS8ra2lDY1Vx?= =?utf-8?B?ZnN3UlpXRFczc1hDVEsxc3hCZkpCRWw2SlptRXRWT05mRUZ0L2trWFArUUNR?= =?utf-8?B?OHc1aDlCelp1VDh2SC9GREZ6WTA3S2JRZk0xZGZEQnJJYmFPSVFXUFdGNzJh?= =?utf-8?B?MlBmK3BEdmdLQllFakwvUXAxZjZsT1RrNitUS2h2dUZDdFNQajdjMFFUc3BH?= =?utf-8?B?MGFTcS9McXpOVnhFZzVGRmMvR0tCL3N1Wk1iZEh3dGx6aDQvYmEraGg2cmJT?= =?utf-8?B?cndNcWlOcm9uWExnb0lpNnlOMUsrUS9oTlBhTnNCSVMrWVp0VnBoeEpjelp2?= =?utf-8?B?L2crcm0zeUJac3pGb2txTnJNbWlqMmhidXlML0FyRXR0Nis4RzZSQVJZU3do?= =?utf-8?B?RDVxWkxncHNEdTJ2ZFI3VXRYZmFhQVV1T2FrNmtnRjUycWNtMEJlVkV1bXNy?= =?utf-8?B?NFFuU3loK1RPM2dPNWlCdklFbGQrSTVFOFh0eHVpdUo2aXNKWlJsUG9weDk0?= =?utf-8?B?c0d3ZVREbHB6S2RjNjRROVdram9QU2lMZ3duQi9pazNWQ0tZRXd4eDdoTUVZ?= =?utf-8?B?bWtZYWNQRThjZE9XQktWektkT01XMHdMNGJEN3kyV3dBV2xIdEhucmJsSkRp?= =?utf-8?B?UXhCY1dyc3AvRXc0eW9WVFAzUkJOMnJyZXh5akJIRTAxOFU4WWFkZ29EVU1Z?= =?utf-8?B?b0huL2FYTTE3K1puTnhtVHhZNkhkRDVQd09HeFcvRDN1TmZOQllmamcxdTA5?= =?utf-8?B?cGwzcDl3ekhQd3duUVZJS0FKU2NZWjhtRnM5U1dBZExZZmo1bFZpUC9TWkZF?= =?utf-8?B?WHJqZEE3T3dkMTlYYnl5WGs1d3prUDR0T1NPeGtJaFllOUJwWURMOS9kaDlB?= =?utf-8?B?dWlZbWdYeW9VK1ZFRnMrellYUWhFelNNczFQb01aMEY5VWNSeURpazMvOHJV?= =?utf-8?B?SHdHdm9zb2lIc0VYTy8vaExwWjNWSlkrNEQ0WDZGV3NsT2d1YWh4aG5yQmZp?= =?utf-8?B?U2c9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: ead23e9a-0f36-44d3-83e0-08db9a5c5aaa X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4804.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 11:16:05.3090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6sxmfu5tvQ7ZJsYZcV49V8nJEijUQv6NwrkWat9HlVGlAMCedHKXghZlK3py6UUspylDFruFm/NcO2MVIsiDF73QJUgZjHnguQIK+4HXViU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5876 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Hi all, A gentle ping on this patch. On 2023-07-03 21:16:29 +0200, Niklas Söderlund wrote: > From: Qin Ke > > Add case of nfp driver to check related firmware version and format. > > Signed-off-by: Qin Ke > Acked-by: Dano Teixeira > Reviewed-by: Niklas Söderlund > --- > tests/TestSuite_firmware_version.py | 44 +++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/tests/TestSuite_firmware_version.py b/tests/TestSuite_firmware_version.py > index a5215c40441b..0e26b519ed19 100644 > --- a/tests/TestSuite_firmware_version.py > +++ b/tests/TestSuite_firmware_version.py > @@ -140,6 +140,50 @@ class TestFirmwareVersion(TestCase): > None, > ) > > + elif self.kdriver == "nfp": > + # Get the version information from output and cfg file > + ( > + exp_vnic_version, > + exp_nsp_version, > + exp_mip, > + exp_app, > + ) = expected_version_info > + vnic_version, nsp_version, mip, app = version_info.split() > + > + self.check_format( > + exp_nsp_version, > + nsp_version, > + "nsp_version", > + r"^\d{1,4}\.\d{1,4}$", > + None, > + ) > + > + self.check_firmware_version(exp_nsp_version, nsp_version) > + > + self.check_format( > + exp_vnic_version, > + vnic_version, > + "vnic_version", > + r"^((\d{1,4}\.\d{1,4}\.\d{1,4}\.\d{1,4})|\*)$", > + None, > + ) > + > + self.check_format( > + exp_mip, > + mip, > + "mip", > + r"^(tc|sriov|nic)-.*$", > + None, > + ) > + > + self.check_format( > + exp_app, > + app, > + "app", > + r"(flower|nic|unknown)", > + None, > + ) > + > else: > self.verify(False, f"Test: case fails on {self.kdriver} driver") > > -- > 2.41.0 > -- Kind Regards, Niklas Söderlund