test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vm_power_manager: change coremask
Date: Wed, 3 Feb 2021 06:51:55 +0000	[thread overview]
Message-ID: <adad212f837b437ba2b5f0e73046edf9@intel.com> (raw)
In-Reply-To: <20210203030954.16375-1-weix.xie@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: 2021年2月3日 11:10
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/vm_power_manager: change coremask
> 
> according to dpdk commit b49c677, adjust the coremask given to
> vm_power_manager.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vm_power_manager.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vm_power_manager.py
> b/tests/TestSuite_vm_power_manager.py
> index 00910ebd..854e1617 100644
> --- a/tests/TestSuite_vm_power_manager.py
> +++ b/tests/TestSuite_vm_power_manager.py
> @@ -94,7 +94,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          self.path = self.vm_dut.apps_name['guest_cli']
>          self.guest_cmd = self.path + "-c 0xf -n 4 -- --vm-name=%s --vcpu-
> list=0,1,2,3" % self.vm_name
>          self.vm_power_dir = self.vm_dut.apps_name['vm_power_manager']
> -        mgr_cmd = self.vm_power_dir + "-c 0x7 -n 4"
> +        mgr_cmd = self.vm_power_dir + "-c 0x1ff -n 4"

check  cores is necessary before using these cores.
dpdk commit b49c677 said  " 
    When vm_power_manager is started, it takes over power management on
    all cores. This should be limited to cores defined in the core mask.

    When initialising, if a core is not on the coremask, skip it.
    Applies to both initialisation and exit."
So, please go through script, don't missing any other places. The cores that not on core mask will be not taken over by app.

>          out = self.dut.send_expect(mgr_cmd, "vmpower>", 120)
>          self.dut.send_expect("add_vm %s" % self.vm_name, "vmpower>")
>          self.dut.send_expect("add_channels %s all" % self.vm_name, "vmpower>")
> --
> 2.17.1


      parent reply	other threads:[~2021-02-03  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  3:09 Xie wei
2021-02-03  3:06 ` Xie, WeiX
2021-02-03  6:51 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adad212f837b437ba2b5f0e73046edf9@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).