test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated
@ 2020-12-29  1:51 Xie wei
  2020-12-29  1:51 ` [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2020-12-29  1:51 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

Update i40e driver to 2.13.10.
vf_vlan_rx: while vlan set filter on, the pkts with random vlan id 1-4095 shall not be received.
add_pvid_vf: while ip link set pf_intf vf 0 vlan 0, the pkts with random vlan id 1-4095 shall not be received.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_vlan.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index a5754117..28650143 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -107,6 +107,9 @@ class TestVfVlan(TestCase):
         self.host_intf0 = self.dut.ports_info[self.used_dut_port_0]['intf']
         tester_port = self.tester.get_local_port(self.used_dut_port_0)
         self.tester_intf0 = self.tester.get_interface(tester_port)
+        # get driver version
+        out = self.dut.send_expect("ethtool -i %s | awk -F':' 'NR==2{print $2}'" % self.host_intf0, "# ")
+        self.driver_version = out.replace(" ", "")
 
         self.dut.generate_sriov_vfs_by_port(
             self.used_dut_port_0, 1, driver=driver)
@@ -273,7 +276,7 @@ class TestVfVlan(TestCase):
         self.vm0_testpmd.execute_cmd("start")
 
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e" or self.kdriver == 'ice':
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
             self.verify("received" in out, "Failed to received vlan packet!!!")
         else:
             self.verify(
@@ -395,7 +398,7 @@ class TestVfVlan(TestCase):
 
         # send packet with vlan
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e" or self.kdriver == 'ice':
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
             self.verify(
                 "received 1 packets" in out, "Received mismatched vlan packet while vlan filter on")
         else:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify script to match i40e driver updated
  2020-12-29  1:51 [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated Xie wei
@ 2020-12-29  1:51 ` Xie wei
  2020-12-29  1:57   ` Xie, WeiX
  2020-12-29  1:56 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
  2020-12-29  2:11 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xie wei @ 2020-12-29  1:51 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

Update i40e driver to 2.13.10.
vf_add_pvid: remove vlan, the pkts with random vlan id 1-4095 shall not be received.
vf_vlan_rx: remove vlan, the pkts with vlan 1 shall not be received.
vf_vlan_strip: disable strip, the pkts with random vlan tag shall not be received.
vf_vlan_filter: disable filter, the pkts with random vlan tag shall not be received.
vf_vlan_promisc: disable filter and strip, the pkts with random vlan tag shall not be received.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 0420cfa1..68f16096 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -94,6 +94,10 @@ class TestKernelpfIavf(TestCase):
         self.tester_intf1 = self.tester.get_interface(tester_port1)
         self.l3fwdpower_name = self.dut.apps_name['l3fwd-power'].strip().split('/')[-1]
 
+        # get driver version
+        out = self.dut.send_expect("ethtool -i %s | awk -F':' 'NR==2{print $2}'" % self.host_intf, "# ")
+        self.driver_version = out.replace(" ", "")
+
     def set_up(self):
 
         if self.running_case == "test_vf_mac_filter":
@@ -416,8 +420,12 @@ class TestKernelpfIavf(TestCase):
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, "fail to tester received vlan packet!!!")
-        self.verify(self.vf_mac in out, "Failed to received vlan packet!!!")
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, "fail to tester received vlan packet!!!")
+            self.verify(self.vf_mac in out, "Failed to received vlan packet!!!")
+        else:
+            self.verify(len(receive_pkt) == 1, "fail to tester received vlan packet!!!")
+            self.verify(self.vf_mac not in out, "Received vlan packet!!!")
 
     def send_and_getout(self, vlan=0, pkt_type="UDP"):
 
@@ -481,7 +489,10 @@ class TestKernelpfIavf(TestCase):
 
         # send vlan 1 packet, vf can receive packet
         out = self.send_and_getout(vlan=1, pkt_type="VLAN_UDP")
-        self.verify(self.vf_mac in out, "received vlan 1 packet!!!")
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
+            self.verify(self.vf_mac in out, "received vlan 1 packet!!!")
+        else:
+            self.verify(self.vf_mac not in out, "Received vlan 1 packet!!!")
 
     def test_vf_vlan_insertion(self):
         self.vm_testpmd.start_testpmd("all")
@@ -526,7 +537,10 @@ class TestKernelpfIavf(TestCase):
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
+        else:
+            self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
 
     def test_vf_vlan_filter(self):
         random_vlan = random.randint(2, MAX_VLAN)
@@ -560,7 +574,10 @@ class TestKernelpfIavf(TestCase):
         time.sleep(1)
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, 'Failed to received vlan packet!!!')
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, 'Failed to received vlan packet!!!')
+        else:
+            self.verify(len(receive_pkt) == 1, 'Failed to received vlan packet!!!')
 
     def test_vf_without_jumboframe(self):
         self.tester.send_expect('ifconfig %s mtu %s' % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), '#')
@@ -911,7 +928,10 @@ class TestKernelpfIavf(TestCase):
         self.scapy_send_packet(self.vf_mac, self.tester_intf, vlan_flags=True, count=10)
         out = self.vm_dut.get_session_output()
         packets = len(re.findall('received 1 packets', out))
-        self.verify(packets == 10, "Not receive expected packet")
+        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
+            self.verify(packets == 10, "Not receive expected packet")
+        else:
+            self.verify(packets == 0, "Receive expected packet")
 
         # send 10 untagged packets, and check 10 untagged packets received
         self.scapy_send_packet(self.vf_mac, self.tester_intf, count=10)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated
  2020-12-29  1:51 [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated Xie wei
  2020-12-29  1:51 ` [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
@ 2020-12-29  1:56 ` Xie, WeiX
  2020-12-29  2:11 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-12-29  1:56 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, December 29, 2020 9:51 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match
> i40e driver updated

[-- Attachment #2: TestVfVlan.log --]
[-- Type: application/octet-stream, Size: 384010 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify script to match i40e driver updated
  2020-12-29  1:51 ` [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
@ 2020-12-29  1:57   ` Xie, WeiX
  0 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-12-29  1:57 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, December 29, 2020 9:51 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify script to
> match i40e driver updated

[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 1816137 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated
  2020-12-29  1:51 [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated Xie wei
  2020-12-29  1:51 ` [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
  2020-12-29  1:56 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
@ 2020-12-29  2:11 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-12-29  2:11 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> Update i40e driver to 2.13.10.
> vf_vlan_rx: while vlan set filter on, the pkts with random vlan id 1-4095 shall
> not be received.
> add_pvid_vf: while ip link set pf_intf vf 0 vlan 0, the pkts with random vlan
> id 1-4095 shall not be received.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Applied the series.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-29  2:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29  1:51 [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify script to match i40e driver updated Xie wei
2020-12-29  1:51 ` [dts] [dst][PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
2020-12-29  1:57   ` Xie, WeiX
2020-12-29  1:56 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
2020-12-29  2:11 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git