From: "Mo, YufengX" <yufengx.mo@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>,
"Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V2 1/3] framework: check the python version
Date: Thu, 22 Oct 2020 02:30:10 +0000 [thread overview]
Message-ID: <ba4ced3374f24db38dbd7ca2645cbe6c@intel.com> (raw)
In-Reply-To: <ebf013f1d92e4d74bee1dd49b8dac3a2@intel.com>
So, checking python version > 3.6.0 is what you want to do?
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Thursday, October 22, 2020 9:18 AM
> To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
>
> DTS only support Python3 now, it doesn't support Python2. But it requires Python minus version. E.g. Python3.4 is not supported, it
> requires version larger than 3.6x.
>
> > +def check_crb_python_version(crb):
> > + cmd = 'python3 -V'
>
> It seems you are telling python version for python 3. If you are using python3, how can it tell you python2.
>
> > + out = crb.send_expect(cmd, '#', 5)
> > + pat = "Python (\d+).(\d+).(\d+)"
> > + result = re.findall(pat, out)
> > + if not result or int(result[0][0]) < 3:
> > + crb.logger.warning(
> > + ("WARNING: Tester node python version is lower than python 3, "
> > + "it is deprecated for use in DTS, "
> Python2 have been replaced by Python2 in DTS, so the message is not reasonable.
>
> > + "and will not work in future releases."))
> > + crb.logger.warning("Please use Python 3 instead")
> > +
> > +
> > +def check_dts_python_version():
> > + if sys.version_info.major < 3:
> > + print(RED(
> > + ("WARNING: Dts running node python version is lower than python 3, "
> > + "it is deprecated for use in DTS, "
> > + "and will not work in future releases.")), file=sys.stderr)
> > + print(RED("Please use Python 3 instead"), file=sys.stderr)
> > --
> > 2.21.0
next prev parent reply other threads:[~2020-10-22 2:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 7:14 [dts] [PATCH V2 0/3] " yufengmx
2020-10-14 7:14 ` [dts] [PATCH V2 1/3] " yufengmx
2020-10-22 1:18 ` Tu, Lijuan
2020-10-22 2:30 ` Mo, YufengX [this message]
2020-10-22 2:53 ` Tu, Lijuan
2020-10-22 6:36 ` Ma, LihongX
2020-10-14 7:14 ` [dts] [PATCH V2 2/3] " yufengmx
2020-10-14 7:14 ` [dts] [PATCH V2 3/3] " yufengmx
2020-10-14 7:25 ` Ma, LihongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba4ced3374f24db38dbd7ca2645cbe6c@intel.com \
--to=yufengx.mo@intel.com \
--cc=dts@dpdk.org \
--cc=lihongx.ma@intel.com \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).