From: bugzilla@dpdk.org
To: dts@dpdk.org
Subject: [Bug 931] Trex config file (yaml) will break dts with valid yaml
Date: Mon, 31 Jan 2022 21:33:46 +0000 [thread overview]
Message-ID: <bug-931-433@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=931
Bug ID: 931
Summary: Trex config file (yaml) will break dts with valid yaml
Product: DTS
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: framework
Assignee: dts@dpdk.org
Reporter: ohilyard@iol.unh.edu
Target Milestone: ---
framework/crb.py:503 (check_trex_process_existed)
```
if 'config_file' in conf_info:
config_file = conf_info['config_file']
else:
config_file = '/etc/trex_cfg.yaml'
fd = open(config_file, 'r')
output = fd.read()
fd.close()
prefix = re.search("prefix\s*:\s*(\S*)", output)
if prefix is not None:
self.trex_prefix = prefix.group(1)
```
This will break if quotes are used even though 'prefix: "trex1"' and 'prefix:
trex1' are semantically equivalent. An actual yaml parser should be used to
extract this information to avoid this fragility.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-01-31 21:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-931-433@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).