test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size
@ 2023-04-26 10:22 Dukai Yuan
  2023-04-27 10:06 ` Ling, WeiX
  2023-04-28  0:40 ` lijuan.tu
  0 siblings, 2 replies; 3+ messages in thread
From: Dukai Yuan @ 2023-04-26 10:22 UTC (permalink / raw)
  To: dts; +Cc: Dukai Yuan

Secure Copy (scp) is used to verify whether the vm2vm established connection successful.
1MB file size is too small, which may cause verification failure.
So,change file size from 1MB to 10MB.

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 .../TestSuite_vm2vm_virtio_net_perf_cbdma.py  | 28 +++++++++----------
 tests/TestSuite_vswitch_sample_cbdma.py       |  2 +-
 tests/virtio_common.py                        |  4 +--
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
index 8fece79f..176a25af 100644
--- a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
+++ b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
@@ -475,7 +475,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -528,7 +528,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -547,7 +547,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -741,7 +741,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -871,12 +871,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -961,12 +961,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1143,12 +1143,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1180,12 +1180,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=1)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1269,12 +1269,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=8)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
diff --git a/tests/TestSuite_vswitch_sample_cbdma.py b/tests/TestSuite_vswitch_sample_cbdma.py
index 783275f2..feb3b4f2 100644
--- a/tests/TestSuite_vswitch_sample_cbdma.py
+++ b/tests/TestSuite_vswitch_sample_cbdma.py
@@ -649,7 +649,7 @@ class TestVswitchSampleCBDMA(TestCase):
             self.vm0_pmd = PmdOutput(self.vm_dut[0])
             self.vm1_pmd = PmdOutput(self.vm_dut[1])
             self.BC.config_2_vms_ip()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         iperfdata = self.BC.check_iperf_result_between_2_vms()
         return iperfdata
diff --git a/tests/virtio_common.py b/tests/virtio_common.py
index cf1bbe43..eec8999b 100644
--- a/tests/virtio_common.py
+++ b/tests/virtio_common.py
@@ -87,7 +87,7 @@ class basic_common(object):
         fp.write(data)
         fp.close()
 
-        # scp file from tester on VM0
+        # scp file from tester to VM0
         out = self.test_case.vm_dut[0].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.tester_ip, timeout=5
         )
@@ -95,7 +95,7 @@ class basic_common(object):
             self.test_case.vm_dut[0].send_command("yes", timeout=3)
         self.test_case.vm_dut[0].send_command(self.tester_passwd, timeout=3)
 
-        # scp file from VM0 on VM1
+        # scp file from VM0 to VM1
         out = self.test_case.vm_dut[1].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.vm0_ip, timeout=5
         )
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size
  2023-04-26 10:22 [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size Dukai Yuan
@ 2023-04-27 10:06 ` Ling, WeiX
  2023-04-28  0:40 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: Ling, WeiX @ 2023-04-27 10:06 UTC (permalink / raw)
  To: Yuan, DukaiX, dts; +Cc: Yuan, DukaiX

> -----Original Message-----
> From: Dukai Yuan <dukaix.yuan@intel.com>
> Sent: Wednesday, April 26, 2023 6:23 PM
> To: dts@dpdk.org
> Cc: Yuan, DukaiX <dukaix.yuan@intel.com>
> Subject: [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma &
> vswitch_sample_cbdma: Optimize the Secure Copy file size
> 
> Secure Copy (scp) is used to verify whether the vm2vm established
> connection successful.
> 1MB file size is too small, which may cause verification failure.
> So,change file size from 1MB to 10MB.
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
> ---

Acked-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size
  2023-04-26 10:22 [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size Dukai Yuan
  2023-04-27 10:06 ` Ling, WeiX
@ 2023-04-28  0:40 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-04-28  0:40 UTC (permalink / raw)
  To: dts, Dukai Yuan; +Cc: Dukai Yuan

On Wed, 26 Apr 2023 18:22:56 +0800, Dukai Yuan <dukaix.yuan@intel.com> wrote:
> Secure Copy (scp) is used to verify whether the vm2vm established connection successful.
> 1MB file size is too small, which may cause verification failure.
> So,change file size from 1MB to 10MB.
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-28  0:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-26 10:22 [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size Dukai Yuan
2023-04-27 10:06 ` Ling, WeiX
2023-04-28  0:40 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).