test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
@ 2021-03-23 15:11 sunqin
  2021-03-25  3:25 ` Sun, QinX
  2021-03-25  6:28 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: sunqin @ 2021-03-23 15:11 UTC (permalink / raw)
  To: dts; +Cc: sunqin

Confirm with developer that the design of dpdk is changed for VF,

the VLAN ID needs to be set before VF receives VLAN packets.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 5 +++++
 1 file changed, 5 insertions(+)
 mode change 100755 => 100644 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py

diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
old mode 100755
new mode 100644
index 6490dcbf..cadea5d8
--- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
+++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
@@ -7886,6 +7886,11 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
             self.pmd_output.quit()
             self.launch_testpmd(symmetric=symmetric)
             self.pmd_output.execute_cmd("start")
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 3 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
+        self.pmd_output.execute_cmd('rx_vlan add 7 0')
 
     def test_mac_ipv4_gtpu_ipv4(self):
         self.switch_testpmd(symmetric=False)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
  2021-03-23 15:11 [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
@ 2021-03-25  3:25 ` Sun, QinX
  2021-03-25  6:28 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Sun, QinX @ 2021-03-25  3:25 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Tuesday, March 23, 2021 11:11 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf

Tested-by: Sun Qin <qinx.sun@intel.com>

[-- Attachment #2: TestCVLAdvancedIAVFRSSGTPU.log --]
[-- Type: application/octet-stream, Size: 5543032 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
  2021-03-23 15:11 [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
  2021-03-25  3:25 ` Sun, QinX
@ 2021-03-25  6:28 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-03-25  6:28 UTC (permalink / raw)
  To: Sun, QinX, dts; +Cc: Sun, QinX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of sunqin
> Sent: 2021年3月23日 23:11
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
> 
> Confirm with developer that the design of dpdk is changed for VF,
> 
> the VLAN ID needs to be set before VF receives VLAN packets.
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>
> ---
>  tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 5 +++++
>  1 file changed, 5 insertions(+)
>  mode change 100755 => 100644
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> 
> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> old mode 100755
> new mode 100644
> index 6490dcbf..cadea5d8
> --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> @@ -7886,6 +7886,11 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
>              self.pmd_output.quit()
>              self.launch_testpmd(symmetric=symmetric)
>              self.pmd_output.execute_cmd("start")
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 7 0')

A little confused, you add this in a common function, and this function will be called by most of cases, not only related to vlan, furthermore, the function will be added multiple time in runtime.
> 
>      def test_mac_ipv4_gtpu_ipv4(self):
>          self.switch_testpmd(symmetric=False)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-25  6:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 15:11 [dts] [PATCH V1] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
2021-03-25  3:25 ` Sun, QinX
2021-03-25  6:28 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git