test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 1/2] test_plans/ice_iavf_fdir: update dts code for gtpu rule changes
@ 2023-04-12  7:26 Weiyuan Li
  2023-04-12  7:26 ` [dts][PATCH V1 2/2] tests/ice_iavf_fdir: " Weiyuan Li
  0 siblings, 1 reply; 4+ messages in thread
From: Weiyuan Li @ 2023-04-12  7:26 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

According to dpdk commit 16b8e92d49 (ethdev: use extension header for GTP PSC item) modify script adapt to dpdk changes.
Because fixed support for this input set in this commit, this validate was removed from negative case.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 test_plans/ice_iavf_fdir_test_plan.rst | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test_plans/ice_iavf_fdir_test_plan.rst b/test_plans/ice_iavf_fdir_test_plan.rst
index 16412acd..b6ceded2 100644
--- a/test_plans/ice_iavf_fdir_test_plan.rst
+++ b/test_plans/ice_iavf_fdir_test_plan.rst
@@ -1238,7 +1238,6 @@ Note: some of the error messages may be differernt.
 
 8. Invalid value of input set::
 
-    flow validate 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x12345678 / gtp_psc qfi is 0x100 / end actions queue index 1 / end
     flow validate 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / gtp_psc qfi is 0x5 / end actions queue index 2 / end
     flow validate 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / end actions queue index 1 / end
 
@@ -4203,7 +4202,6 @@ Subcase 3: Invalid parameters of GTPU input set
 
 1. Invalid value of teid and qfi::
 
-    flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x12345678 / gtp_psc qfi is 0x100 / end actions queue index 1 / end
     flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / gtp_psc qfi is 0x5 / end actions queue index 2 / end
     flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / end actions queue index 1 / end
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/ice_iavf_fdir: update dts code for gtpu rule changes
  2023-04-12  7:26 [dts][PATCH V1 1/2] test_plans/ice_iavf_fdir: update dts code for gtpu rule changes Weiyuan Li
@ 2023-04-12  7:26 ` Weiyuan Li
  2023-04-12  7:55   ` Huang, ZhiminX
  2023-04-23  8:12   ` lijuan.tu
  0 siblings, 2 replies; 4+ messages in thread
From: Weiyuan Li @ 2023-04-12  7:26 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

According to dpdk commit 16b8e92d49 (ethdev: use extension header for GTP PSC item) modify script adapt to dpdk changes.
Because fixed support for this input set in this commit, this validate was removed from negative case.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_ice_iavf_fdir.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/TestSuite_ice_iavf_fdir.py b/tests/TestSuite_ice_iavf_fdir.py
index 5370ea8e..ba231915 100644
--- a/tests/TestSuite_ice_iavf_fdir.py
+++ b/tests/TestSuite_ice_iavf_fdir.py
@@ -9573,7 +9573,6 @@ class TestICEIAVFFdir(TestCase):
     def test_l2_ethertype(self):
         self.multirules_process(vectors_l2_ethertype)
 
-    @skip_unsupported_pkg("comms")
     def test_negative_case(self):
         """
         negative cases
@@ -9590,7 +9589,6 @@ class TestICEIAVFFdir(TestCase):
             ],
             "invalid mark id": "flow create 0 ingress pattern eth / ipv4 src is 192.168.0.20 dst is 192.168.0.21 proto is 255 ttl is 2 tos is 4 / end actions passthru / mark id 4294967296 / end",
             "invalid parameters of GTPU input set": [
-                "flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x12345678 / gtp_psc qfi is 0x100 / end actions queue index 1 / end",
                 "flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / gtp_psc qfi is 0x5 / end actions queue index 2 / end",
                 "flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 / end actions queue index 1 / end",
             ],
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1 2/2] tests/ice_iavf_fdir: update dts code for gtpu rule changes
  2023-04-12  7:26 ` [dts][PATCH V1 2/2] tests/ice_iavf_fdir: " Weiyuan Li
@ 2023-04-12  7:55   ` Huang, ZhiminX
  2023-04-23  8:12   ` lijuan.tu
  1 sibling, 0 replies; 4+ messages in thread
From: Huang, ZhiminX @ 2023-04-12  7:55 UTC (permalink / raw)
  To: Li, WeiyuanX, dts; +Cc: Li, WeiyuanX

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Wednesday, April 12, 2023 3:26 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/ice_iavf_fdir: update dts code for gtpu rule
> changes
> 
> According to dpdk commit 16b8e92d49 (ethdev: use extension header for GTP
> PSC item) modify script adapt to dpdk changes.
> Because fixed support for this input set in this commit, this validate was
> removed from negative case.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Acked-by: Zhimin Huang <zhiminx.huang@intel.com >



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/ice_iavf_fdir: update dts code for gtpu rule changes
  2023-04-12  7:26 ` [dts][PATCH V1 2/2] tests/ice_iavf_fdir: " Weiyuan Li
  2023-04-12  7:55   ` Huang, ZhiminX
@ 2023-04-23  8:12   ` lijuan.tu
  1 sibling, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2023-04-23  8:12 UTC (permalink / raw)
  To: dts, Weiyuan Li; +Cc: Weiyuan Li

On Wed, 12 Apr 2023 15:26:12 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> According to dpdk commit 16b8e92d49 (ethdev: use extension header for GTP PSC item) modify script adapt to dpdk changes.
> Because fixed support for this input set in this commit, this validate was removed from negative case.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-04-23  8:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12  7:26 [dts][PATCH V1 1/2] test_plans/ice_iavf_fdir: update dts code for gtpu rule changes Weiyuan Li
2023-04-12  7:26 ` [dts][PATCH V1 2/2] tests/ice_iavf_fdir: " Weiyuan Li
2023-04-12  7:55   ` Huang, ZhiminX
2023-04-23  8:12   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).