test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] pktgen_ixia: fix a issue taking ownership failed
@ 2021-05-17 21:46 Lijuan Tu
  2021-05-26  6:24 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lijuan Tu @ 2021-05-17 21:46 UTC (permalink / raw)
  To: dts; +Cc: Lijuan Tu

DTS has to take ownership of an ixia port, then can operate it.
If the port is owned by other user, DTS has to take ownership forcedly.
It seems DTS intend to do above but with wrong code implement.

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 framework/pktgen_ixia.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py
index 80c5cb5..0273f3a 100644
--- a/framework/pktgen_ixia.py
+++ b/framework/pktgen_ixia.py
@@ -610,13 +610,13 @@ class Ixia(SSHConnection):
                 for item in self.ports]),
             "% ", 10)
         if out.strip()[-1] != '0':
-            return False
-        out = self.send_expect("ixTakeOwnership [list %s] force" % ' '.join(
+            self.logger.info("Force to take ownership:")
+            out = self.send_expect("ixTakeOwnership [list %s] force" % ' '.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
                 for item in self.ports]),
             "% ", 10)
-        if out.strip()[-1] != '0':
-            return False
+            if out.strip()[-1] != '0':
+                return False
 
         return True
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] pktgen_ixia: fix a issue taking ownership failed
  2021-05-17 21:46 [dts] [PATCH] pktgen_ixia: fix a issue taking ownership failed Lijuan Tu
@ 2021-05-26  6:24 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-05-26  6:24 UTC (permalink / raw)
  To: dts

> DTS has to take ownership of an ixia port, then can operate it.
> If the port is owned by other user, DTS has to take ownership forcedly.
> It seems DTS intend to do above but with wrong code implement.
> 
> Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-26  6:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 21:46 [dts] [PATCH] pktgen_ixia: fix a issue taking ownership failed Lijuan Tu
2021-05-26  6:24 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git