test suite reviews and discussions
 help / color / mirror / Atom feed
From: Angela Czubak <aczubak@caviumnetworks.com>
To: dts@dpdk.org
Subject: Re: [dts] TestSuite_shutdown_api.py, test_enable_disablejumbo and MTU questions
Date: Thu, 13 Apr 2017 18:08:38 +0200	[thread overview]
Message-ID: <d4de7330-fc99-985f-8f72-1a8a5fced5fa@caviumnetworks.com> (raw)
In-Reply-To: <af570de9-cba2-8ffd-52b8-725680ea7de5@caviumnetworks.com>

Ok, partially answering to myself: max-pkt-len is different than MTU, 
there is no call to rte_eth_dev_set_mtu when calling "port config all 
max-pkt-len". It is truly setting max_rx_pkt_len of 
port->dev_conf.rxmode in init_port_config (and then the device is 
reconfigured with rte_eth_dev_configure when starting the port).

This somehow explains, that decreasing by 4 in send_packet might be 
connected to the fact that NIC may or may not take FCS into frame length.

So now I only don't know why HEADER_SIZE['eth'] is 18 (for sure) and why 
powerville, springville and kawela_4 are treated differently.

On 12.04.2017 19:48, Angela Czubak wrote:
> Hi,
>
>
> I was reading TestSuite_shutdown_api.py and have some questions about 
> test_enable_disablejumbo.
>
> First of all, what are the expectations when it comes to max-pkt-len? 
> I mean, self.dut.send_expect("port config all max-pkt-len %d" % 
> jumbo_size, "testpmd> ") (and jumbo_size=2048) calls 
> rte_eth_dev_set_mtu. How should this function interpret MTU? It 
> believe it is not clearly stated, however for many drivers MTU is 
> length of the IP header + its payload. Is there a DPDK convention 
> saying otherwise? I mean, in send_packet_method padding is calculated 
> subtracting both IP header size and ether header size. I just want to 
> know where the border of dropping a packet should lie.
>
> Secondly, why HEADER_SIZE['eth'] is equal 18? Does it take into 
> account FCS? Are is there any other reason? And why rx_bytes_exp and 
> tx_bytes_exp is decreased by at least 4? (send_packet method).
>
> Last but not least, why for powerville, psringville or kawela_4 
> jumbo_size is increased by 4? This happens as well in 
> test_enable_disablejumbo.
>
> Thanks in advance for the response.
>
>
> Regards,
>
> Angela Czubak
>

  reply	other threads:[~2017-04-13 16:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 17:48 Angela Czubak
2017-04-13 16:08 ` Angela Czubak [this message]
2017-04-20  6:01   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4de7330-fc99-985f-8f72-1a8a5fced5fa@caviumnetworks.com \
    --to=aczubak@caviumnetworks.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).