test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 2/2] tests/vdev_primary_secondary: modify testsuite by DPDK change
@ 2022-03-10  8:39 Wei Ling
  2022-03-11  1:26 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Ling @ 2022-03-10  8:39 UTC (permalink / raw)
  To: dts; +Cc: Wei Ling

By DPDK change(commit 1c839246f9), no need to modify DPDK code to test,
so delete modify DPDK code steps in testsuite.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_vdev_primary_secondary.py | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/tests/TestSuite_vdev_primary_secondary.py b/tests/TestSuite_vdev_primary_secondary.py
index 093cd57c..d436d840 100644
--- a/tests/TestSuite_vdev_primary_secondary.py
+++ b/tests/TestSuite_vdev_primary_secondary.py
@@ -77,7 +77,6 @@ class TestVdevPrimarySecondary(TestCase):
         self.dut.send_expect("killall -s INT %s" % self.testpmd_name, "#")
         self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
 
-
     def setup_vm_env(self):
         """
         Create testing environment
@@ -103,7 +102,6 @@ class TestVdevPrimarySecondary(TestCase):
 
         return True
 
-
     def launch_testpmd(self):
         """
         launch testpmd
@@ -118,7 +116,6 @@ class TestVdevPrimarySecondary(TestCase):
         self.dut.send_expect("set fwd txonly", "testpmd> ", 120)
         self.dut.send_expect("start", "testpmd> ", 120)
 
-
     def launch_examples(self):
         example_cmd_auto = self.app_symmetric_mp_path + " -l 0 -n %d --proc-type=auto -- -p 3 --num-procs=%d --proc-id=0"
         example_cmd_secondary = self.app_symmetric_mp_path + " -l 1 -n %d --proc-type=secondary -- -p 3 --num-procs=%d --proc-id=1"
@@ -128,19 +125,7 @@ class TestVdevPrimarySecondary(TestCase):
         time.sleep(3)
         self.vhost_secondary.send_expect(final_cmd_secondary, "Lcore", 120)
 
-
     def prepare_symmetric_mp(self):
-        self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/main.c .", "#")
-        self.vm_dut.send_expect(
-                "sed -i '/.offloads = DEV_RX_OFFLOAD_CHECKSUM,/d' ./examples/multi_process/symmetric_mp/main.c", "#")
-        self.vm_dut.send_expect(
-                "sed -i 's/ETH_MQ_RX_RSS,/ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#")
-        out = self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
-        self.verify("Error" not in out, "compilation symmetric_mp error")
-
-
-    def restore_symmetric_mp_env(self):
-        self.vm_dut.send_expect("\cp ./main.c ./examples/multi_process/symmetric_mp/", "#", 15)
         out = self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
         self.verify("Error" not in out, "compilation symmetric_mp error")
 
@@ -148,7 +133,6 @@ class TestVdevPrimarySecondary(TestCase):
         self.vm_dut.close_session(self.vhost_first)
         self.vm_dut.close_session(self.vhost_secondary)
 
-
     def test_Virtio_primary_and_secondary_process(self):
         # start testpmd
         self.launch_testpmd()
@@ -175,7 +159,6 @@ class TestVdevPrimarySecondary(TestCase):
         """
         Run after each test case.
         """
-        self.restore_symmetric_mp_env()
         self.close_session()
         self.vm_dut.kill_all()
         self.dut.kill_all()
@@ -184,8 +167,6 @@ class TestVdevPrimarySecondary(TestCase):
         self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
         time.sleep(2)
 
-
-
     def tear_down_all(self):
         """
         Run after each test suite.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts][PATCH V1 2/2] tests/vdev_primary_secondary: modify testsuite by DPDK change
  2022-03-10  8:39 [dts][PATCH V1 2/2] tests/vdev_primary_secondary: modify testsuite by DPDK change Wei Ling
@ 2022-03-11  1:26 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2022-03-11  1:26 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> -----Original Message-----
> From: Wei Ling <weix.ling@intel.com>
> Sent: 2022年3月10日 16:40
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/vdev_primary_secondary: modify testsuite by
> DPDK change
> 
> By DPDK change(commit 1c839246f9), no need to modify DPDK code to test, so
> delete modify DPDK code steps in testsuite.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>

Series applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-11  1:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10  8:39 [dts][PATCH V1 2/2] tests/vdev_primary_secondary: modify testsuite by DPDK change Wei Ling
2022-03-11  1:26 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).