test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/perf_virtio_user: write throughput value to report when case is failed
Date: Tue, 3 Mar 2020 01:58:54 +0000	[thread overview]
Message-ID: <d9e6cb98de08473ca14596e5131f864c@intel.com> (raw)
In-Reply-To: <1583173758-5410-1-git-send-email-lihongx.ma@intel.com>

Tested-by:ma,lihong<lihongx.ma@intel.com>

Regards,
Ma,lihong

-----Original Message-----
From: Ma, LihongX 
Sent: Tuesday, March 3, 2020 2:29 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts][PATCH V1] tests/perf_virtio_user: write throughput value to report when case is failed

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_perf_virtio_user_loopback.py | 5 +++--
 tests/TestSuite_perf_virtio_user_pvp.py      | 3 +--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_perf_virtio_user_loopback.py b/tests/TestSuite_perf_virtio_user_loopback.py
index 0fb97dd..822e6d9 100644
--- a/tests/TestSuite_perf_virtio_user_loopback.py
+++ b/tests/TestSuite_perf_virtio_user_loopback.py
@@ -142,6 +142,8 @@ class TestPerfVirtioUserLoopback(TestCase):
         """
         results = 0.0
         results_row = []
+        out = self.vhost.send_expect("show port stats all", "testpmd>", 60)
+        time.sleep(5)
         for i in range(10):
             out = self.vhost.send_expect("show port stats all", "testpmd>", 60)
             time.sleep(5)
@@ -261,7 +263,6 @@ class TestPerfVirtioUserLoopback(TestCase):
                     row_dict0['status'] = 'PASS'
                 else:
                     row_dict0['status'] = 'FAIL'
-                self.verify(row_dict0['status'] == 'PASS', 'The throughput is not in correct range')
                 row_dict1 = dict(name="Throughput", value=result_throughput, unit="Mpps", delta=delta)
                 row_dict2 = dict(name="Txd/Rxd", value=row_in["TXD/RXD"], unit="descriptor")
                 row_dict3 = dict(name="frame_size", value=row_in["Frame Size"], unit="bytes") @@ -274,7 +275,7 @@ class TestPerfVirtioUserLoopback(TestCase):
                                '{0:s}_{1}.json'.format(
                                    self.nic, self.suite_name)), 'w') as fp:
             json.dump(self.json_obj, fp)
-        self.verify("Fail" not in status_result, "Exceeded Gap")
+        self.verify("FAIL" not in status_result, "Exceeded Gap")
 
     def test_perf_loopback_packed_ring_inorder_mergeable(self):
         """
diff --git a/tests/TestSuite_perf_virtio_user_pvp.py b/tests/TestSuite_perf_virtio_user_pvp.py
index 2073426..344dba5 100644
--- a/tests/TestSuite_perf_virtio_user_pvp.py
+++ b/tests/TestSuite_perf_virtio_user_pvp.py
@@ -358,7 +358,6 @@ class TestVirtioSingleCorePerf(TestCase):
                     row_dict0['status'] = 'PASS'
                 else:
                     row_dict0['status'] = 'FAIL'
-                self.verify(row_dict0['status'] == 'PASS', 'The throughput is not in correct range')
                 row_dict1 = dict(name="Throughput", value=result_throughput, unit="Mpps", delta=delta)
                 row_dict2 = dict(name="Txd/Rxd", value=row_in["TXD/RXD"], unit="descriptor")
                 row_dict3 = dict(name="frame_size", value=row_in["Frame Size"], unit="bytes") @@ -371,7 +370,7 @@ class TestVirtioSingleCorePerf(TestCase):
                                '{0:s}_{1}.json'.format(
                                    self.nic, self.suite_name)), 'w') as fp:
             json.dump(self.json_obj, fp)
-        self.verify("Fail" not in status_result, "Exceeded Gap")
+        self.verify("FAIL" not in status_result, "Exceeded Gap")
 
     def tear_down(self):
         """
--
2.7.4


  reply	other threads:[~2020-03-03  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 18:29 lihong
2020-03-03  1:58 ` Ma, LihongX [this message]
2020-03-03  7:39 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9e6cb98de08473ca14596e5131f864c@intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).