From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0081.outbound.protection.outlook.com [104.47.41.81]) by dpdk.org (Postfix) with ESMTP id F2E449E3 for ; Tue, 18 Apr 2017 16:01:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SaHlNAL/KPRK5d1X6PXM8l/k6TrTx5kfb3Wm/AFL3Mk=; b=e67GGpJ1n4/RIMx7WRs9MEUB1gZcXmZDApZ7SnsfjFjBblNex8Quv4iWhIpobg9bjplvqAhBDsnPsAO9FuA3ixH2nM0T9PFGqvlL6ypDTFeZJa5c6hJ8cTX9fdxWFkhWnQKEdf/ms4gHpFB/N4XhUT8el04J9fyM7DHJW9IcnNc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.11] (31.172.191.173) by CO2PR0701MB806.namprd07.prod.outlook.com (10.141.246.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Tue, 18 Apr 2017 14:01:38 +0000 From: Angela Czubak References: <789e7895-275d-c674-fac6-47076f8705d3@caviumnetworks.com> To: dts@dpdk.org, "Liu, Yong" Message-ID: Date: Tue, 18 Apr 2017 16:01:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <789e7895-275d-c674-fac6-47076f8705d3@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM5PR0202CA0011.eurprd02.prod.outlook.com (10.173.87.21) To CO2PR0701MB806.namprd07.prod.outlook.com (10.141.246.24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb1c9f68-573a-4105-3ac2-08d486636f11 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CO2PR0701MB806; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB806; 3:urjdn+GK2E86Gd/UvQ1kNhaftaslEKLlBC6FTWuUe9EbGYvEvFgoR1lKHq+xTpR3TgYO3nBsZaRw6j+cJMSAJv02nBP8OmhjzsGGCLsO2I4n1qmf/3p05sWb4iJum5nn1aRXFn5VqagSNXHVCvIclvuu0TM+9zj9AgUnVqKIs/cA0Rr/kvEeMWuelhVL4mNxzn6cBImFzadW9s0o/95RZXFqHAr8NZ5Zngbm/mzCjwAM7SJPdRlPILQO1/uYaowTJDUklidRmKZ7kqn1pZ3b7kz7aDWquTVA/RbpOyknRRBPszzdEtB86lb3arYgMsmTMS4KWoy38s/3x/hgM6Pp2A==; 25:iUYJT83rA2NmfoV1EbkagxG+XHvdLiJDJOtyr+QE2/I3LnA42Tw2sPRS3MsL2kriT4KnxMyS5uevjo3b1UE44a9SB4IP8dxgJs6ymrT+9/7veKqOqRI1HJsnWiAXjDruhx8jBrnEGkrbG+dSKh9Nd3btYZK+17BkqDkfiScYJXiFzemLJRI+3x2uCKtI8J67knOZX5Q491htX9Nelv5eDsklg3DtvQclvTtsyFbWJUL+AF2LAF5BisMT1bAld66+bY/UoQgVvNPThLnXoWxxdGRVY/dhmfISBBTKmfPyaie4yV0is7Bi6EEZQAw8d7Kc0oxnmimz1CDBV1Gvjaarh+NCgsyStNHtqjk8LUwZMMdWnEJO6z8ZFC8awTXxCY00b1lIwwiBdrZKnO+ayBx66G62xX+pu7KO/zNN4aX0lBnZePnw/+q05A50R2E7lt0NqfW0pyD6DTHh40Pq5LjT7w== X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB806; 31:2z4yxYSECjwLK3lPSE1nTFLLXJPTbgPjkRF4/GFW/ljzK8yoE+6MSpyk9kBtEIH/LOytUIlh/mPhS+NBICBLSuR9Bvs7yhwSj0BVI9AO4HXxBt/+pAu5F+o2B+kvtVfhjQ2N5o7crNCddjFuHbKf00CEDZ5ReYXuU31+yiRfFeF1iCBaLGuMbsUN2SrYktwLvyqtLbOy+z/e0UrQpvKYu5Uu3tnD7lyqjEHxOy72P5BU1/n5DujZwsCtAtOoCYs4cXPOZeWXNfgnZkf0Up3MuA==; 20:9P16PGrR3VC2/B4Gh94O9tFI0WI5zi4Xsi5ikd8cgE3p/8q7xFYEBuqxBsJscpRvvxvCZR60NYankeAhFWQMm9NuSsObQiqGTxRU0AleYIPeMZLaTjqdUUNmfvpNr+4KMS32l8+txUMqrbmWzMveaTAB0BnBTu1yZBRaxwz6BA75cpH1BbYNV3UM0G1Tw+QD4H9Y/hct8g+AtMThc93ROn6Sb+46VBu3Km/2n2fRUnuKSrpprycYvJciFFDoDRkAepsQhV10siIhXCx3mHn8P25SIaUtb6CCpqr+EDDH1RoZIelNBvylZpc26L1+ENzkqxBWTpWXSM6vQkUgXH9krMfVT6ErhBeHQfF1VCu+XNKOMACK94tmT0ip5nVTfWmoXiIBQx9pcfrv+tbx+zPfxRun3GF31PBK1uolzbYC4ZYkgVOsOfd/WWDHD+FPVZ+4ylhPsYtG5wBwcvdEhZCIlA5kK+3UT+q9cd6rxylCvbMJ1IGVAaX63bkaO3TkY03xafO7LvK7vzqKnho2AGS9NpmRm23UaVF6Bc1uf3q10KdS7FDYjz0QxF+UjE/jARokXBWIq1IKPBU4GlEKC541TU5U/Ddg9IAbuMPvrzqdxyA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(127540120423786); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(3002001)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123555025)(20161123564025)(6072148); SRVR:CO2PR0701MB806; BCL:0; PCL:0; RULEID:; SRVR:CO2PR0701MB806; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB806; 4:LfkdDmIDBITQ7PMdVVAbtAfacvZ03Q7UIcqfaZQCwpEbD6c6SOHRACAfFqd/fOIZUFctCunZ7R6nwQXVCQc/IILfyQ/DyX+QhbQerAiJBbhXvBiFK+7NnByXEir6865lgYjmo0bkJRJoU3356+KNShkPkcD/tE8xAKUtEvM3p0W/FmAgjbpvmGoyfw5IH2UnaV8IMabbAONIjE0slXUy/Am9U75RUQ+vLQwfV3FaxYa2MFdIQIKP26WDuzZmjAxsqltbFKeWEhbN1SzZx7nFe20CVntgMQ1VuTnTSARHm9fhFMxtA8TC6cJQ07T32ZgyY9BbmnSpnIxFqxQA9VGe7CmdzonyKo7Oh1/uiyS58dYqh/3eL9qYiDqvMk7/wOnH21OtMkZ7DdBm6T0YVWjyLCcBa8hNzpstqDehenlCOF7/UiZX500W+B/lg2Er1Vcb2r+ICo5XlsY2xENtHT7+CSyhOODq+jIvVUZPfeyzPbfnUwdMfYK5GAGeFo4kJKM3H/Bc2WJimEe3hCMqW0Ig5dFZ3kNVoZHxfH0URdX2Ez8uy92XCBaLblP//meX8b9ccCg08B3OdfVRhpeitkrXjd0IN7Jp0oHHInGMvLNT/fGgIapOrnFZlM85Db3+2WEsKXCLPZIGBR3sHdHQXmTrglED6z6h98qKOcBdrML/WXsPdcWYKLd5RT3UBvIeNUcSLWgJ8qYskTjewonCUGdimHTGmXCEFKOo49fipEaGvf9h0NKVqonN8KkZkVUH4qCa X-Forefront-PRVS: 028166BF91 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39850400002)(39450400003)(39410400002)(39400400002)(24454002)(13464003)(377454003)(6916009)(2950100002)(31686004)(42882006)(189998001)(4001350100001)(305945005)(64126003)(50466002)(7736002)(6666003)(83506001)(2906002)(65956001)(47776003)(66066001)(65806001)(229853002)(77096006)(50986999)(6486002)(81166006)(54356999)(5660300001)(33646002)(575784001)(230700001)(110136004)(38730400002)(53546009)(25786009)(42186005)(3846002)(6116002)(23746002)(31696002)(2473003)(76176999)(8676002)(36756003)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR0701MB806; H:[10.0.0.11]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR0701MB806; 23:N4A2JQ3cwjk5I94M6G7y0+ls0APgVMZtNOOk?= =?Windows-1252?Q?pwPvWW678KLL29JqnIVXpP2SWgyWRzzpKgOplxk6IulhTnWPC1QAM2xu?= =?Windows-1252?Q?I1PnJDOiCurJZA6tdw6bRnbR/FOYzLzaeMO26EaR8ZlkkxEPowBCIcNw?= =?Windows-1252?Q?O4LRNU/LsIOvIko+bc9Pw3TFIvmEutjQGlpxMTG5YlksEMeX/71gYq+3?= =?Windows-1252?Q?ANO8Ja99g+K7JRDqBA219D8nhqzwKnbaGc5ufOoex8fyyPfaz0he0D6u?= =?Windows-1252?Q?rwQsAF4De1etMSJmTI0nebx4ibGceEzfTUAZHiR8aTmOi8ZjTOprZJ0e?= =?Windows-1252?Q?1vl7jg0eZ2fKAwkcOxI3gsVfRMkTEv860w0a67RukC9vJHFxExEF7hdv?= =?Windows-1252?Q?XO3MqW9sXZ1YluQHbKsmcbc9erp08G+EtKnJa1jSsyQNeIetiDHKgv5y?= =?Windows-1252?Q?1E+dI7uv2I5dv8EhIz+WjWc+ZMWuwhNHVw4Od1seNSjDYP3VNar9cFvU?= =?Windows-1252?Q?iI212nYGDd7sssIZ4+xRIa7hxSBk7K3BuKGRctV7zDEh6wN0ZwqL0Dyp?= =?Windows-1252?Q?Hx0teGoDbTqedXA+stM2CYRWMkULqgkrb8+RuNjSLIT7QGdZZsVySWHQ?= =?Windows-1252?Q?BLIEO6YTP2uKbchcCcYT9izKYKLSkeoQHPxd0yrNzkJj38ZJRMP+ipwO?= =?Windows-1252?Q?gMNGDVDnQp1SXnJFmmtEc7nJaBXujJB8wjiFy/m722vv/rPq8qBYVaNa?= =?Windows-1252?Q?Zd+qsTj0E+kjtEnOjRyClcdNJlxDcY9rzE4xo8/qPE82c+6LJ22LJ5kL?= =?Windows-1252?Q?6+iUsTSBVZ/5BNT4N8yNIM+bPxHTm+b8IvamFLPPnPRsElmA150gqfs/?= =?Windows-1252?Q?7x0DtDWgj/mEzYoAkC1EZx6g/FZ7noD8Qe3rIl9Atrbo5fQf28YNnsvs?= =?Windows-1252?Q?QZqwlXV/HUloQnA0sMRjpHLHZ3Yg0bUeGyx9IKoVz+iGuBC2xzlV6w2g?= =?Windows-1252?Q?1tN69x7FBPCFVaB8f7wFPAQvXAXr1NwPB6z08joiespR6E+DQiVcJCBg?= =?Windows-1252?Q?E95Zb4a1HShAlA7CYeg/uEfvepOtJ7M8xLz9uC04+cMDJFYCzOBBk/OR?= =?Windows-1252?Q?0sngRndaHnZ75kwKPFojbF5pGVi2L8dDKIf/oqXrIJivmNcpemOmOJMN?= =?Windows-1252?Q?5w5U4USsFk7m4TEkIIaHBK0+gjfPvuPvzn06a3TzkPHn+rR9s7rSwffQ?= =?Windows-1252?Q?WHpYeForL5fv7JSraNpSBpOr05IXtUA1Di2ZVXBjsHMsZ4Uxsuzx8fdA?= =?Windows-1252?Q?h6hOwv1rOx5M0H6UBi6zMxbwxOXUleCrEheH9mMjDvCV0KISney0/sQj?= =?Windows-1252?Q?AIdNQ67QZlvcOZIub0MizrSifbNYGFlfSw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB806; 6:ZHp6jVGWLwojBh5pm1/hxmfoOREhQYqGPwQJqoTjnxzhKUZy1YxjPzoMKEohfhbOsgNov84GEkUmGz/f7NwA2nFZZmJXppr+V2ZirVL9JdJ8MKOb3wrdn27/vbEyttUJA8rfUwM2tfECmWBg/kWp6M9pUKza+Prq9Bflm+d/IREcEqLOAXhLjbC1d70WI6q/ovvFxfmTo1EpQtoUYCspPqumfvGvhTmaIN1/CF63Bp3tzLob1HGZB++ImFx86MKcotyluKUVEcci3dq9fRhejYkTtCzjObd7SNUcHPecZ9XzbkYJyTuCe7pppuPJRVjDE6rV89GDpZq8wBCQFIqIKTJGepVnjTy9CR7FNdeWYCJpVST+A/maeouq89uBsnYSsf0nz8+tG7zzc6CSqjD+iuvxY/nphj7iI6kIlzSvtH6sNNvv1EpjVRmsEaLGCA3DOf4Kyj/Fj10wCIKC4YAROQ==; 5:KSEKqhpS1JaSD6sawxPNkdzKKEBZk/EO2RRWd2TwxA54ii/sQ6VTwVV5AqlT6/RQxfbpGCpTlnt6Jt0t/N4iBrSxKif6W8ZafR7tE1potwBdSut24DY1enQgcDQRgmxPYES70TABnAf8ryD2TYqfOA==; 24:C6q2Yp/WwP4l0uYmhsnXtiKdxivcMIXsvbI0pQUBj02fLY8UhslIw+j1YuiieAZ1kfsLfNjOB1Uw4voBJTh66rytc5PSCPVTxxHr9FTXTXQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB806; 7:rHlL3TfpWSTsvr3yHTTYGpZrmTs3SkmSKaKH4s3IIeqbFIWAg6O5tyQuD2M8tMrNshi/SEQZLN1Vh8LWFrO5e5WzsXnTRjIkNOeKtenpmcaedFouKIGg+sizDM4301lggwPoYpuPoJzCo+l9aOGcksC5osc050U5RP3TKKsPRL3i1iWMogO65TADJb60tnEfyEyEvQXxdJECApKIfJbzNr1tiXdix+jpp5zp/2aDHcmEAT4hZujxxXrYTal1zKtVphKbOjdFPiO0j10rUURl9PoE12+RoQsin15hH4i+2wO+xkJVsADWuHEagUEXvva33+xH3Yd9gPsAojZ0keSq/A== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2017 14:01:38.1761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0701MB806 Subject: [dts] Fwd: Re: [PATCH v2 02/28] framework dut and project_dpdk: using correct available binding scripts X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 14:01:42 -0000 Hi, do you want me to change the approach? I could choose the script based on the rte_version.h, however, right now it seems to be more complicated as the preprocessor constants' names change with the version (once it was for instance RTE_VER_MAJOR, RTE_VER_MINOR, RTE_VER_PATCH_LEVEL and currently it is RTE_VER_YEAR, RTE_VER_MONTH, RTE_VER_MINOR). I do not use the version number anywhere, just want to find exisiting binding scripts. Will the knowledge of the version number be useful in the future? Or is there any other reason to change that piece of code? Thanks, Angela On 17.04.2017 08:35, Liu, Yong wrote: > Hi Angela, > I guess you're trying to make DTS compact with different versions of DPDK. Normally we handle that by creating tag on DTS code. > There's alternative way to do that. We can get dpdk version from rte_version.h and then tools name will be explicit. > > Thanks, > Marvin > > >> -----Original Message----- >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Angela Czubak >> Sent: Tuesday, April 11, 2017 1:09 AM >> To:dts@dpdk.org >> Cc: Angela Czubak >> Subject: [dts] [PATCH v2 02/28] framework dut and project_dpdk: using >> correct available binding scripts >> >> Below patch makes scripts look for correct DPDK binding script, >> checking whether 'usertools' or 'tools' directory is present and which >> script exist in 'tools' directory ('dpdk-devbind.py' or >> 'dpdk_nic_bind.py') >> >> Signed-off-by: Angela Czubak >> --- >> framework/dut.py | 21 ++++++++++++++++++--- >> framework/project_dpdk.py | 20 ++++++++++++++++++-- >> 2 files changed, 36 insertions(+), 5 deletions(-) >> >> diff --git a/framework/dut.py b/framework/dut.py >> index 9cbdaf7..4ce5c3a 100644 >> --- a/framework/dut.py >> +++ b/framework/dut.py >> @@ -377,8 +377,15 @@ class Dut(Crb): >> if current_nic == 0: >> self.logger.info("Not nic need bind driver: %s" % driver) >> return >> - >> - self.send_expect('usertools/dpdk-devbind.py %s' % binding_list, >> '# ') >> + op = self.send_command("ls") >> + if "usertools" in op: >> + self.send_expect('usertools/dpdk-devbind.py %s' % >> binding_list, '# ') >> + else: >> + op = self.send_command("ls tools") >> + if "dpdk_nic_bind.py" in op: >> + self.send_expect('tools/dpdk_nic_bind.py %s' % >> binding_list, '# ') >> + else: >> + self.send_expect('tools/dpdk-devbind.py %s' % >> binding_list, '# ') >> >> def unbind_interfaces_linux(self, nics_to_bind=None): >> """ >> @@ -402,7 +409,15 @@ class Dut(Crb): >> self.logger.info("Not nic need unbind driver") >> return >> >> - self.send_expect('usertools/dpdk-devbind.py %s' % binding_list, >> '# ', 30) >> + op = self.send_command("ls") >> + if "usertools" in op: >> + self.send_expect('usertools/dpdk-devbind.py %s' % >> binding_list, '# ') >> + else: >> + op = self.send_command("ls tools") >> + if "dpdk_nic_bind.py" in op: >> + self.send_expect('tools/dpdk_nic_bind.py %s' % >> binding_list, '# ') >> + else: >> + self.send_expect('tools/dpdk-devbind.py %s' % >> binding_list, '# ') >> >> def get_ports(self, nic_type='any', perf=None, socket=None): >> """ >> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py >> index a0cb4c2..50740f8 100644 >> --- a/framework/project_dpdk.py >> +++ b/framework/project_dpdk.py >> @@ -314,7 +314,15 @@ class DPDKdut(Dut): >> binding_list += '%s ' % (port_info['pci']) >> current_nic += 1 >> >> - self.send_expect('usertools/dpdk-devbind.py %s' % binding_list, >> '# ') >> + op = self.send_command("ls") >> + if "usertools" in op: >> + self.send_expect('usertools/dpdk-devbind.py %s' % >> binding_list, '# ') >> + else: >> + op = self.send_command("ls tools") >> + if "dpdk_nic_bind.py" in op: >> + self.send_expect('tools/dpdk_nic_bind.py %s' % >> binding_list, '# ') >> + else: >> + self.send_expect('tools/dpdk-devbind.py %s' % >> binding_list, '# ') >> >> def unbind_interfaces_linux(self, nics_to_bind=None): >> """ >> @@ -329,7 +337,15 @@ class DPDKdut(Dut): >> binding_list += '%s ' % (port_info['pci']) >> current_nic += 1 >> >> - self.send_expect('usertools/dpdk-devbind.py %s' % binding_list, >> '# ', 30) >> + op = self.send_command("ls") >> + if "usertools" in op: >> + self.send_expect('usertools/dpdk-devbind.py %s' % >> binding_list, '# ') >> + else: >> + op = self.send_command("ls tools") >> + if "dpdk_nic_bind.py" in op: >> + self.send_expect('tools/dpdk_nic_bind.py %s' % >> binding_list, '# ') >> + else: >> + self.send_expect('tools/dpdk-devbind.py %s' % >> binding_list, '# ') >> >> def build_dpdk_apps(self, folder, extra_options=''): >> """ >> -- >> 2.7.4