From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0064.outbound.protection.outlook.com [104.47.37.64]) by dpdk.org (Postfix) with ESMTP id 9D1E82BD1 for ; Mon, 10 Apr 2017 19:08:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KnwPrpJIFFuy9g4KcMkvGEHGX6OXjfYwjkFWjDlPFpo=; b=BdKOXEGC8WFTAzkSrGLxhXSiB5MPCnFN+vJ+Bhcx8BkIUhy/2IHYqgFEL2BII6Sq10EAQ1EC3Hf6AJ5QvVGLzFB8PgKKBshMbBoTRUevsR6ff/L6Liej+pau9Y+BY5yt8nsbRITnsSodOdfjxsncD65uMuNrNR9/OXA8fYyCW6g= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.11] (31.172.191.173) by SN2PR0701MB815.namprd07.prod.outlook.com (10.160.16.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Mon, 10 Apr 2017 17:08:41 +0000 To: dts@dpdk.org References: <1491501092-14278-1-git-send-email-aczubak@caviumnetworks.com> <1491501092-14278-10-git-send-email-aczubak@caviumnetworks.com> From: Angela Czubak Message-ID: Date: Mon, 10 Apr 2017 19:08:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491501092-14278-10-git-send-email-aczubak@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM5PR0602CA0004.eurprd06.prod.outlook.com (10.175.46.142) To SN2PR0701MB815.namprd07.prod.outlook.com (10.160.16.149) X-MS-Office365-Filtering-Correlation-Id: eafbf7aa-e8c3-4ec7-8fab-08d480343d46 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:SN2PR0701MB815; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB815; 3:IOQqH6qXrya6JD0iAzSC3C/TnMfsHFVi412F4iSNpBrNVixBIG4adTucvdBhMQLnMFLeRbI3y1li++c2l28kC0uWS3V3PvjcE2Ls68SM+0Li3JTE/p/ov3b15zHzpbbKWFVK4OYdr+ROI1n38VIBaVmMPFUjbF2QDdqHtiOwHGJO1VOfyCfNJrPESTmhKBDWFTXOeV7VHO6z3oj3lwsRByOnQ/YQStv+FXBwJoJNvI23vhGiec1Z0tEZzVosBEyDM2O1vms0yak7tF3oYDj6pjZD/u5hMpmndOmxe1JV6Mhl4jf6d+9Gru4KLINjkeD4pJvm4tJXrxXQOkh2tthCbg==; 25:mqWDeMch9jsSclZBI8u8bQE/Q92uevLuTNacevqx44tHc2IgwjjYhxUaj+y1g4julc9x5K5PtBvHo9ZKoMXusOmDu1RE27b7kgg0JDHlCKNxqRMJGYkQzZuWFoNoVJQ3bVq6AkV1p/MavtZmqyMFFp28EXgnNFO2q0A2EIrbdPQfknzKSWYTIcV/47b3cpFNv0IStnHL2Dul5n+qFsrUwj9uSqGvsuoD5HBwIbO3VtUCiD7QC2hu7PxyUjfIgqPMC5EALyqquYt8NvMvdJbXXETij7xAsZ0HkNtLzaxJstD4tjQjrY3iBDaZ+WSDNAMinhiRCXKQ7Bltw8YoZj6sYVMVp2d3v7bWmnjFJtpAf8gRM+8f7mMFNqliTpHaDQJ96RzTxswYFs9Qmjm5t9x4E88Aif8S+4euf0qlNBjc76hrHRR65bLO/1FWd7951Zy7TeuUeizfwIUZwJznNmpXyw== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB815; 31:QAoWDddPGnBAb0taNFhBUuiffmVjj8jVdaF5nMZQ0GGuuB2ccG9pOvt/HhUjytuTbHOgf71BOJ3VytXUsvZUamTvN7aY/hQYCCMPpvDMgDTMmNCNJFYygxLjAcTyzUyuCplTOu0iVk1b9kenGZdgEx5v2jWn9Id+CWOERTchpw1lvE2YNrlB0Hd17JwejkiPUjwU0b6FGDVl2FsjF4RXsI6PQzFKUvVbJdam2qfpLzRy4SSlSnqDbJUi6Uv+K9qyfRakxjkC14R95mXh82tP5A==; 20:V62DbR7miVqS/yjkoTt/l+hRISr4lgoynpG1QZxwZ7hEw3YQSpasyGixepmrvGCnSoN+vuCi6I5MSfN9tRMTuFnAgYaH5Ojv0DPi0f4rp/NUcewVg9FBlNeEHPICyvmydsTad3N5qn0Ou4ZMwcQ4UVRl6ObdMA++ZhQHfv/ZN7SIXmAd8/Ert7TMJwiBGRp7bqzNHwI6dZ8ZZgNe012dmBrt3UrNQ8s78Vxj8AOKkkB0xOmhpqEU9UTx8k3kid1eaiKIIhNf0tzu9d65VFxzJ0QHPretw72IHxQHk05KmNVOlSX/H7kTTrnyh6BzjuPpn4EafE26hIXbpA5Nb7b41UFQX+SFvnAmCIcLMHKP9bsXhM9Z6pQOL/+c0kTlHCgK/CN6ClO5Ywn5AvSdKwYcd/SOR3LaO+ReKU6FiuQVN5i/BTcR06dkkqiS0MnOQBqif4/abTzsvfwR+mF8YVyWvPEsWyuw54ufdimx0P6j14FRyHE2mGwXzwLfShqE5IJlRNfNbkEkdwj/Er58HheLJI6MkA4x7XUz+JVcuMDyQhdYT9hpTaaBvF1MojGPVeZNdB7GhORuWjc7bi8tc+YWCsNDfYflCFyj/F6vb14xGv0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:SN2PR0701MB815; BCL:0; PCL:0; RULEID:; SRVR:SN2PR0701MB815; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB815; 4:XNBT91VP4sydHyvsyc6z5SdZTmkZ6AeuONoyYbss7SKK+Qn5a0PZMUbakW0gn7mMZNxTz8DWzCGqHpO2LKks8KL2bLPKOKsMni/2MMcWV1r+Ibp26t+DyW2gOSut/70spSKlL3TRUXJxO+8/75bkaW2wpRinext8Ta2A7/jRiM9pHAoAkck+B+vzPHuACOiK8uwuKoYBOr0OpAkd0aNOnLIlNNb5OGnyzp6EH5+Rdu18IlkJye2fbE9vy2JWe0vXowBkZaXKBP913RXo6hxyPx/lBI4PiKA4eZciKDUoqiXtCZpiz/jEKGCveKR+45Q6Jha1eBXHAjOv3pyJJpooLB+Kwya3Yy+MHxGBesX9X7Fi7TEnr9ShYATBR5fqjsud7z3YVSPj9LciPUp4ttW8n7pFEfu8ls4BDpSIgx8alw01IrjDHi9kG8Pzlpg06/9FfHAjBok5/bn6uzoriiUBfe6AX0krevrOjNnanIs4S7jMGY3nDun8eW+HjTBL4k35r1SeDxb+fUtpfHR8rdizd/znY9o+BasI2tXQkmoVDiovUNV+YQg2xpTrQO46bis+/zTtTWsnrlPKUgOwiuf4U224J9dWxxWgOrfo50kGmv8DzXSkcCLvhmozCzlEAgdlQJwvSbB0ldUshmOp8SLspt3R2p6MI95PC2lq5Kj7LiTSatITDKMXW2c8VYSJczod X-Forefront-PRVS: 027367F73D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39850400002)(39410400002)(39840400002)(39450400003)(39400400002)(24454002)(6486002)(2361001)(42186005)(31686004)(3846002)(81166006)(2351001)(65826007)(76176999)(54356999)(50986999)(230700001)(90366009)(36756003)(5660300001)(33646002)(6116002)(77096006)(8676002)(110136004)(38730400002)(2906002)(189998001)(64126003)(6246003)(6666003)(50466002)(83506001)(2950100002)(6916009)(53936002)(229853002)(305945005)(25786009)(31696002)(42882006)(47776003)(4001350100001)(65956001)(7736002)(53546009)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB815; H:[10.0.0.11]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR0701MB815; 23:PMAW5yIYxsOgOChMkwglY1StTdsPw9482TJw?= =?Windows-1252?Q?G2gclmPDDskOUCiupEXlkMNhW/hGlA7adFYVGlkzW1G6Rm9ZM8NwOKNN?= =?Windows-1252?Q?m2sUgXkNv9GExA2nK62kJSU+XHHqXKhF+0lRkQ3DdFBkU3ZOn2MYG8xW?= =?Windows-1252?Q?iRo284hcAR0sSq1iqhGpqn1MhSlXZUz0nqo4y814xV66BFFMBefIZ9sF?= =?Windows-1252?Q?GrAg9aC/zOUpQAQSseB7jlCOH7ii3CfIsvB8eFwZq8OaVp7fKIwyzz4q?= =?Windows-1252?Q?4oW6zmmU/Qsw/5ANp/0gOdX0xVPSE8IezsHSBrgAxGf2f5RTgZzjajDp?= =?Windows-1252?Q?i3MRiIsUWGwUGP9fw79+2cKUyhxlOVYsXKb/TbxFv/TJGNZfSpErS+Cc?= =?Windows-1252?Q?vN4mXGDArUf6tZQAR5zH/02XSmlwtIuIF35PkbSqo7Dnw3sU74dhMgwp?= =?Windows-1252?Q?Z6w8vVTyOgaJk6xW/5xnRloygL1kquH1EGzXhoYh10F5tGaCBVJJQtpH?= =?Windows-1252?Q?9bqPsbmN1m23JvozkF1C+Ny+TcyZ0O4P35QdJdtghHw0lDPz4LdV7M+b?= =?Windows-1252?Q?qq0t+UfYLzzJjNGEThqckaEVyEFjuiiDhdeG4Tmnp5W0jdsa6FDArcZz?= =?Windows-1252?Q?PooZgjqn/vN3nnvMsS4Gb/xqmmeMEf1gj/BPcSP9+DCuWZSKPZGT1e2t?= =?Windows-1252?Q?KDu0Z1QCvEWKxIgqivsOWeDiZ+P7CkCVyqvzJOIzQqpxsc7Lg8QH2E+t?= =?Windows-1252?Q?FRPC5Ai2VoeAAQrzD2uAEFEYeU9C8WDHT6evScKQxMk+cqD2G4YvUjQS?= =?Windows-1252?Q?HzsS6i/fUnyChEW+xHEpeAxYef4i7bGtH39scI0/8rZrqUNDgPMUyYZb?= =?Windows-1252?Q?OmCydOetItSERNYiJOrwt7MkzgYbxDOOzEUjxRTSMiGngYkfnZByWcEH?= =?Windows-1252?Q?PVyNE4iOYiaKq29/ofIGknFIDnYi3Gj9fl5PjC8FZIoT88dwWURRLjSc?= =?Windows-1252?Q?Ysln9f15St6uPf5H5NpTUfMolMSnyzNQHNUM97l21ehQmah1z6IEmiG5?= =?Windows-1252?Q?ta4tfmdTyk/jMzhKk2Q1p1eZQaGPptrNXD4sd6Lil+es97jsYd67Jug0?= =?Windows-1252?Q?PN2sZQ3phER4456ndumkg+ARKfihqJOu3WEbcVAMwVCH4/1/CN+mEVES?= =?Windows-1252?Q?eGG/oOZmZJz2/XkJD6Ox3Bb+AVi/U/+vBb5C+wrLrmd8LZfhqIFbzuqa?= =?Windows-1252?Q?cC0/77QSfVTaP1rEuJmQbvJJ0fDs+wAZ97U6N7QR7UdKZMkychrFTDYk?= =?Windows-1252?Q?8CAFrWdeoQA9dtBIVHDvrdq4sH96waHPMq5nlqOT5qlMVno=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB815; 6:Iqnt/GcCHVobmTn7xNdlCJzG8AQRicrQPHLoz7j318G1qfKbyRq7PxC70JgH3lUyoA6FDI2IWdT8+/XVoOrU89Cn8vk6uMJu4vc2+Fi+IOGVT9pEFZAjp+svYy0MGnncGHF9jkeF9NWHWe4lv0deH1UHr3TSDO6tPQtli3pzZ6CNvw0iCkI45I7kJw/dQYPvRELEqNL3QvVPXS1wk1ouY+SzqOUlV6wvb5oKLK+OSYp7j4AIHlB80rTWTACSyHBaSHg5GNb7i0CbcGjkD8Pm7d3jZwpjpmFzhLl8q/tn6OK0LN88GQS6yiFJ2zsDJdKarSsB9kI1eWLC/dJJi7QigOJQGXkluEKjHT3LQJWPxfJAZBQh8+2MSAEJ+BIYH8xCSNoDdKyGlZabpnmKkpGZ+8fZ9TkvCdA3lspQNccvsDPLqSG2u86YNaXPBhd2TWZpBPJUSIKS+DAI9fio7qtl1Q==; 5:35dQ7bZTJy8fMnkLXSYG+p2XRHEi+gJuWBMPU8lvQReaebjYSt5BrkF23dnwczsAKj3cRODDiZmm0EIXCE33TwkyQFjG+aZ5if+NScjxR+lswW1Ui6Cs5BVF1p/eIyYn1h8KJ0q01Sk+i+2A6nJ35Q==; 24:m5mORccg72O8XsXRk6akmHlfMFyfqd5VnOnBjc07X8y35ElNDvPl4NgKDstxXMB4vbH2jpJqmH+2olr2ilTJR2L1Vg/MwrR6yDC7dcdu6Gc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB815; 7:Oy8hU7fhKhfZgr7mN31027DQe+4P1Pq0wzB+40xgLIRtFfkGueNcse54xr3lww/dRGN2Q6CIqeTj1jzMZP1sfDsXH9fPpi6/FM2ek271cBcQKkweEdl/gAUjtBIAjHbQ2sjzE8rPL54V8530MYL4roI74XYI6YuBZo8tyI3bTajzHQb/dbZypvhu0A62ydKA9i+LQ86VkqkOQ/fkWBJfDYqxTbEZTtBtywjG/xGvNXLOlbZ1crjpPLn5a5Np4UYsbBZy8Sc1qVZSK0+a843A0bwfLDxRc4d/qAiUh0UyyZnAB9nuXGGe3pMhU6f4JdrepKzVHOWY4m133NfvQIgLYA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2017 17:08:41.6396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB815 Subject: Re: [dts] [PATCH 09/26] tests: Modified tests to take cavium nics into account X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 17:08:44 -0000 On 06.04.2017 19:51, Angela Czubak wrote: > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py > index 66219f5..b616ed5 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -332,25 +332,26 @@ class TestShutdownApi(TestCase): > jumbo_size = 2048 > self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket) > self.dut.send_expect("port stop all", "testpmd> ", 100) > - self.dut.send_expect("vlan set strip off all", "testpmd> ") > - self.dut.send_expect("port config all max-pkt-len %d" % jumbo_size, "testpmd> ") > - for port in self.ports: > - self.dut.send_expect("rx_vlan add 1 %d" % port, "testpmd> ") > - self.dut.send_expect("set fwd mac", "testpmd>") > - self.dut.send_expect("port start all", "testpmd> ", 100) > - self.dut.send_expect("start", "testpmd> ") > + out = self.dut.send_expect("vlan set strip off all", "testpmd> ") > + if "fail" not in out: > + self.dut.send_expect("port config all max-pkt-len %d" % jumbo_size, "testpmd> ") > + for port in self.ports: > + self.dut.send_expect("rx_vlan add 1 %d" % port, "testpmd> ") > + self.dut.send_expect("set fwd mac", "testpmd>") > + self.dut.send_expect("port start all", "testpmd> ", 100) > + self.dut.send_expect("start", "testpmd> ") > > - if self.nic in ['magnolia_park', 'niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']: > - # nantic vlan length will not be calculated > - vlan_jumbo_size = jumbo_size + 4 > - else: > - vlan_jumbo_size = jumbo_size > + if self.nic in ['magnolia_park', 'niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']: > + # nantic vlan length will not be calculated > + vlan_jumbo_size = jumbo_size + 4 > + else: > + vlan_jumbo_size = jumbo_size > > - self.check_forwarding(pktSize=vlan_jumbo_size - 1, vlan=True) > - self.check_forwarding(pktSize=vlan_jumbo_size, vlan=True) > - self.check_forwarding(pktSize=vlan_jumbo_size + 1, received=False, vlan=True) > + self.check_forwarding(pktSize=vlan_jumbo_size - 1, vlan=True) > + self.check_forwarding(pktSize=vlan_jumbo_size, vlan=True) > + self.check_forwarding(pktSize=vlan_jumbo_size + 1, received=False, vlan=True) > > - self.dut.send_expect("stop", "testpmd> ") > + self.dut.send_expect("stop", "testpmd> ") > > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all hw-vlan off", "testpmd> ") Actually, found a bug: setting MTU should be done outside the 'if "fail" not in out' clause, so that if NIC does not support setting VLAN stripping off, it still is tested with the desired max-pkt-len. It will be fixed in v2.