From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65AD2A0A0C; Thu, 1 Jul 2021 10:49:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37C4E40141; Thu, 1 Jul 2021 10:49:36 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 82BB040040 for ; Thu, 1 Jul 2021 10:49:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10031"; a="230147684" X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="230147684" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 01:49:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="626295399" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 01 Jul 2021 01:49:33 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 1 Jul 2021 01:49:32 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 1 Jul 2021 16:49:30 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Thu, 1 Jul 2021 16:49:30 +0800 From: "Tu, Lijuan" To: "ohilyard@iol.unh.edu" CC: "dts@dpdk.org" Thread-Topic: [PATCH] framework/config: fix issue with string values Thread-Index: AQHXacMgcOF0ao5O7E65g3+ynvG2Eqst2G0w Date: Thu, 1 Jul 2021 08:49:30 +0000 Message-ID: References: <20210625130753.18155-1-ohilyard@iol.unh.edu> In-Reply-To: <20210625130753.18155-1-ohilyard@iol.unh.edu> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] framework/config: fix issue with string values X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: ohilyard@iol.unh.edu > Sent: 2021=1B$BG/=1B(B6=1B$B7n=1B(B25=1B$BF|=1B(B 21:08 > To: Tu, Lijuan > Cc: dts@dpdk.org; Owen Hilyard > Subject: [PATCH] framework/config: fix issue with string values >=20 > From: Owen Hilyard >=20 > String values were ran through 'eval' like everything else as part of par= sing > config files. This will work the first time if there are quotes around th= e value, but > if the --update-expected flag is passed, it will re-write the config file= without > quotes around the string value. This then cause an error when the value i= s > 'eval'ed again, since it will now be evaluated as a variable. >=20 > Signed-off-by: Owen Hilyard Applied, thanks