test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Owen Hilyard <ohilyard@iol.unh.edu>, David Liu <dliu@iol.unh.edu>,
	"dts@dpdk.org" <dts@dpdk.org>, Aaron Conole <aconole@redhat.com>,
	"Thomas Monjalon" <thomas@monjalon.net>
Subject: Re: [dts] [PATCH] Revert "Strip prompt by default in send_expect"
Date: Wed, 2 Jun 2021 07:41:47 +0000
Message-ID: <ee541902cb2548ef939983f4c1aa98d3@intel.com> (raw)
In-Reply-To: <CAJFAV8xhJiS70=_6anWvx7z0fcTxEyZMqsudRRxP7snOKM+NFQ@mail.gmail.com>



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 2021年6月2日 15:36
> To: Tu, Lijuan <lijuan.tu@intel.com>
> Cc: Owen Hilyard <ohilyard@iol.unh.edu>; David Liu <dliu@iol.unh.edu>;
> dts@dpdk.org; Aaron Conole <aconole@redhat.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dts] [PATCH] Revert "Strip prompt by default in send_expect"
> 
> On Wed, May 26, 2021 at 2:23 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Wed, May 12, 2021 at 10:14 AM Lijuan Tu <lijuan.tu@intel.com> wrote:
> > >
> > > This reverts commit f498f50a62e30f6f8fb9c4e1a759e3d35861b978.
> > > As it casued some cases failed:
> > >   * flow_classify_softnic
> > >       * test_ipv4_acl_jump
> > >       * test_ipv4_acl_table
> > >       * test_ipv6_hash_jump
> > >   * unit_tests_loopback
> > >       * test_link_mode
> > >       * test_loopback_mode
> > >   * distributor
> > >       * maximum_workers
> >
> > Any update on having both worlds (UNH lab and those tests) coexist?
> >
> > I see an exhaustive list of tests that are broken with the new behavior.
> > Another approach to reverting the whole change is to pass
> > trim_whitespace= in the affected tests.
> > Was this idea considered?

Yes, we have accepted the idea, and patch was ready and passed our internal testing, but we found a new test suite power_bidirection_channel that also broken, and are working on fixing it.
> 
> Ping.
> 
> 
> --
> David Marchand


      reply	other threads:[~2021-06-02  7:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 16:12 Lijuan Tu
2021-05-12  8:19 ` Tu, Lijuan
2021-05-26 12:23 ` David Marchand
2021-05-26 14:24   ` Owen Hilyard
2021-06-02  7:36   ` David Marchand
2021-06-02  7:41     ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee541902cb2548ef939983f4c1aa98d3@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dliu@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=ohilyard@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git