test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2] remove reload ice and add pkg check
@ 2021-03-26  5:08 Zhimin Huang
  2021-03-26  5:08 ` [dts] [PATCH V1 1/2] remove reload ice code Zhimin Huang
  2021-03-26  5:08 ` [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice Zhimin Huang
  0 siblings, 2 replies; 6+ messages in thread
From: Zhimin Huang @ 2021-03-26  5:08 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

To support framework add pkg check and all reload ice code should be removed:

 1.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code

 2.flexible pf and vf suite add pkg check,remove reload ice code

Zhimin Huang (2):
  remove reload ice code
  tests/flexible: add pkg check and remove reload ice

 tests/TestSuite_cvl_dcf_acl_filter.py       | 16 ----------------
 tests/TestSuite_cvl_limit_value_test.py     | 15 ---------------
 tests/TestSuite_flexible_rxd.py             | 26 +++++++++++++-------------
 tests/TestSuite_iavf_flexible_descriptor.py | 21 +++++++++++++--------
 4 files changed, 26 insertions(+), 52 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/2] remove reload ice code
  2021-03-26  5:08 [dts] [PATCH V1 0/2] remove reload ice and add pkg check Zhimin Huang
@ 2021-03-26  5:08 ` Zhimin Huang
  2021-03-30  1:39   ` Tu, Lijuan
  2021-03-26  5:08 ` [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice Zhimin Huang
  1 sibling, 1 reply; 6+ messages in thread
From: Zhimin Huang @ 2021-03-26  5:08 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 tests/TestSuite_cvl_dcf_acl_filter.py   | 16 ----------------
 tests/TestSuite_cvl_limit_value_test.py | 15 ---------------
 2 files changed, 31 deletions(-)

diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py b/tests/TestSuite_cvl_dcf_acl_filter.py
index 826da9c..1d516fc 100644
--- a/tests/TestSuite_cvl_dcf_acl_filter.py
+++ b/tests/TestSuite_cvl_dcf_acl_filter.py
@@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase):
         self.testpmd_status = "close"
         #bind pf to kernel
         self.bind_nics_driver(self.dut_ports, driver="ice")
-        #move comms package to package folder
-        self.suite_config = rfc.get_suite_config(self)
-        comms_package_location = self.suite_config["comms_package_file_location"]
-        package_location = self.suite_config["package_file_location"]
-        self.dut.send_expect("cp %s %s" % (comms_package_location, package_location), "# ")
-        self.re_load_ice_driver()
         #set vf driver
         self.vf_driver = 'vfio-pci'
         self.dut.send_expect("modprobe uio", "# ")
@@ -784,16 +778,6 @@ class CVLDCFACLFilterTest(TestCase):
             port.bind_driver(self.vf_driver)
         time.sleep(15)
 
-    def re_load_ice_driver(self):
-        """
-        remove and reload the ice driver
-        """
-        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
-        self.dut.send_expect("rmmod ice", "# ", 60)
-        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
-        self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 15)
-        self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ", 15)
-
     def set_up(self):
         """
         Run before each test case.
diff --git a/tests/TestSuite_cvl_limit_value_test.py b/tests/TestSuite_cvl_limit_value_test.py
index 77ce016..b806474 100644
--- a/tests/TestSuite_cvl_limit_value_test.py
+++ b/tests/TestSuite_cvl_limit_value_test.py
@@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase):
         self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0])
         self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1])
 
-    def re_load_ice_driver(self):
-        """
-        remove and reload the ice driver
-        """
-        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
-        self.dut.send_expect("rmmod ice", "# ", 15)
-        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
-        time.sleep(5)
-
     def config_testpmd(self):
         self.pmd_output.execute_cmd("set fwd rxonly")
         self.pmd_output.execute_cmd("set verbose 1")
@@ -813,12 +804,6 @@ class TestCvlLimitValue(TestCase):
     def test_max_rule_number(self):
         #bind pf to kernel
         self.bind_nics_driver(self.dut_ports, driver="ice")
-        #move comms package to package folder
-        self.suite_config = rfc.get_suite_config(self)
-        comms_package_location = self.suite_config["comms_package_file_location"]
-        package_location = self.suite_config["package_file_location"]
-        self.dut.send_expect("cp %s %s" % (comms_package_location, package_location), "# ")
-        self.re_load_ice_driver()
         #set vf driver
         self.vf_driver = 'vfio-pci'
         self.dut.send_expect('modprobe vfio-pci', '#')
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice
  2021-03-26  5:08 [dts] [PATCH V1 0/2] remove reload ice and add pkg check Zhimin Huang
  2021-03-26  5:08 ` [dts] [PATCH V1 1/2] remove reload ice code Zhimin Huang
@ 2021-03-26  5:08 ` Zhimin Huang
  2021-03-26  5:26   ` Huang, ZhiminX
  1 sibling, 1 reply; 6+ messages in thread
From: Zhimin Huang @ 2021-03-26  5:08 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.flexible pf and vf suite add decorator to support pkg check

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 tests/TestSuite_flexible_rxd.py             | 26 +++++++++++++-------------
 tests/TestSuite_iavf_flexible_descriptor.py | 21 +++++++++++++--------
 2 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/tests/TestSuite_flexible_rxd.py b/tests/TestSuite_flexible_rxd.py
index 648173e..45eb603 100644
--- a/tests/TestSuite_flexible_rxd.py
+++ b/tests/TestSuite_flexible_rxd.py
@@ -32,11 +32,12 @@
 
 
 import time
-from test_case import TestCase
+from test_case import TestCase, skip_unsupported_pkg, check_supported_nic
 from flexible_common import FlexibleRxdBase
 import rte_flow_common as rfc
 
 class TestFlexibleRxd(TestCase, FlexibleRxdBase):
+    supported_nic = ['columbiaville_100g', 'columbiaville_25g', 'columbiaville_25gx2', 'foxville']
 
     def preset_compilation(self):
         """
@@ -65,17 +66,11 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):
         [self.dut.send_expect(cmd, "#", 15, alt_session=True) for cmd in cmds]
         self.dut.build_install_dpdk(self.dut.target)
 
+    @check_supported_nic(supported_nic)
     def set_up_all(self):
         """
         run at the start of each test suite.
         """
-        support_nics = [
-            "columbiaville_25g",
-            "columbiaville_100g",
-            "foxville",
-        ]
-        self.verify(self.nic in support_nics,
-            "flexible rxd only supports CVL NIC.")
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
@@ -85,17 +80,12 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):
         self.pci = self.dut.ports_info[0]['pci']
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         self.init_base(self.pci, self.dst_mac, 'pf')
-        self.ddp_dir = "/lib/firmware/updates/intel/ice/ddp/"
-        self.suite_config = rfc.get_suite_config(self)
-        self.os_default_pkg = self.suite_config["os_default_package_file_location"]
-        self.comms_pkg = self.suite_config["comms_package_file_location"]
 
     def tear_down_all(self):
         """
         Run after each test suite.
         """
         self.restore_compilation()
-        self.replace_pkg(pkg='comms')
 
     def set_up(self):
         """
@@ -111,60 +101,70 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):
         time.sleep(2)
         self.dut.kill_all()
 
+    @skip_unsupported_pkg('os default')
     def test_check_single_VLAN_fields_in_RXD_8021Q(self):
         """
         Check single VLAN fields in RXD (802.1Q)
         """
         self.check_single_VLAN_fields_in_RXD_8021Q()
 
+    @skip_unsupported_pkg('os default')
     def test_check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag(self):
         """
         Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag
         """
         self.check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag()
 
+    @skip_unsupported_pkg('os default')
     def test_check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag(self):
         """
         Check double VLAN fields in RXD (802.1Q) 2 VLAN tags
         """
         self.check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag()
 
+    @skip_unsupported_pkg('os default')
     def test_check_double_VLAN_fields_in_RXD_8021ad(self):
         """
         Check double VLAN fields in RXD (802.1ad)
         """
         self.check_double_VLAN_fields_in_RXD_8021ad()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv4_fields_in_RXD(self):
         """
         Check IPv4 fields in RXD
         """
         self.check_IPv4_fields_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv6_fields_in_RXD(self):
         """
         Check IPv6 fields in RXD
         """
         self.check_IPv6_fields_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv6_flow_field_in_RXD(self):
         """
         Check IPv6 flow field in RXD
         """
         self.check_IPv6_flow_field_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_TCP_fields_in_IPv4_in_RXD(self):
         """
         Check TCP fields in IPv4 in RXD
         """
         self.check_TCP_fields_in_IPv4_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_TCP_fields_in_IPv6_in_RXD(self):
         """
         Check TCP fields in IPv6 in RXD
         """
         self.check_TCP_fields_in_IPv6_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv4_IPv6_TCP_fields_in_RXD_on_specific_queues(self):
         """
         Check IPv4, IPv6, TCP fields in RXD on specific queues
diff --git a/tests/TestSuite_iavf_flexible_descriptor.py b/tests/TestSuite_iavf_flexible_descriptor.py
index 3bfd5b9..41d227a 100644
--- a/tests/TestSuite_iavf_flexible_descriptor.py
+++ b/tests/TestSuite_iavf_flexible_descriptor.py
@@ -35,11 +35,12 @@ import time
 import traceback
 
 
-from test_case import TestCase
+from test_case import TestCase, skip_unsupported_pkg, check_supported_nic
 from flexible_common import FlexibleRxdBase
 
 
 class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
+    supported_nic = ['columbiaville_100g', 'columbiaville_25g', 'columbiaville_25gx2', 'foxville']
 
     def preset_compilation(self):
         """
@@ -100,17 +101,11 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
         except Exception as e:
             self.logger.info(traceback.format_exc())
 
+    @check_supported_nic(supported_nic)
     def set_up_all(self):
         """
         run at the start of each test suite.
         """
-        support_nics = [
-            "columbiaville_25g",
-            "columbiaville_100g",
-            "foxville",
-        ]
-        self.verify(self.nic in support_nics,
-            "flexible rxd only supports CVL NIC.")
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
         self.preset_compilation()
@@ -139,18 +134,21 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
         time.sleep(2)
         self.dut.kill_all()
 
+    @skip_unsupported_pkg('os default')
     def test_check_single_VLAN_fields_in_RXD_8021Q(self):
         """
         Check single VLAN fields in RXD (802.1Q)
         """
         self.check_single_VLAN_fields_in_RXD_8021Q()
 
+    @skip_unsupported_pkg('os default')
     def test_check_single_VLAN_fields_in_RXD_8021ad(self):
         """
         Check single VLAN fields in RXD (802.1ad)
         """
         self.check_single_VLAN_fields_in_RXD_8021ad()
 
+    @skip_unsupported_pkg('os default')
     def test_check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag(self):
         """
         Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag
@@ -163,42 +161,49 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
         """
         self.check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag()
 
+    @skip_unsupported_pkg('os default')
     def test_check_double_VLAN_fields_in_RXD_8021ad(self):
         """
         Check double VLAN fields in RXD (802.1ad)
         """
         self.check_double_VLAN_fields_in_RXD_8021ad()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv4_fields_in_RXD(self):
         """
         Check IPv4 fields in RXD
         """
         self.check_IPv4_fields_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv6_fields_in_RXD(self):
         """
         Check IPv6 fields in RXD
         """
         self.check_IPv6_fields_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv6_flow_field_in_RXD(self):
         """
         Check IPv6 flow field in RXD
         """
         self.check_IPv6_flow_field_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_TCP_fields_in_IPv4_in_RXD(self):
         """
         Check TCP fields in IPv4 in RXD
         """
         self.check_TCP_fields_in_IPv4_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_TCP_fields_in_IPv6_in_RXD(self):
         """
         Check TCP fields in IPv6 in RXD
         """
         self.check_TCP_fields_in_IPv6_in_RXD()
 
+    @skip_unsupported_pkg('os default')
     def test_check_IPv4_IPv6_TCP_fields_in_RXD_on_specific_queues(self):
         """
         Check IPv4, IPv6, TCP fields in RXD on specific queues
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice
  2021-03-26  5:08 ` [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice Zhimin Huang
@ 2021-03-26  5:26   ` Huang, ZhiminX
  0 siblings, 0 replies; 6+ messages in thread
From: Huang, ZhiminX @ 2021-03-26  5:26 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Friday, March 26, 2021 1:08 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove
> reload ice
> 
Tested-by: Huang Zhimin <zhiminx.huang@intel.com>

[-- Attachment #2: TestFlexibleRxd.log --]
[-- Type: application/octet-stream, Size: 965431 bytes --]

[-- Attachment #3: TestIavfFlexibleDescriptor.log --]
[-- Type: application/octet-stream, Size: 338905 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] remove reload ice code
  2021-03-26  5:08 ` [dts] [PATCH V1 1/2] remove reload ice code Zhimin Huang
@ 2021-03-30  1:39   ` Tu, Lijuan
  2021-03-30  2:19     ` Huang, ZhiminX
  0 siblings, 1 reply; 6+ messages in thread
From: Tu, Lijuan @ 2021-03-30  1:39 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年3月26日 13:08
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1 1/2] remove reload ice code
> 
> *.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  tests/TestSuite_cvl_dcf_acl_filter.py   | 16 ----------------
>  tests/TestSuite_cvl_limit_value_test.py | 15 ---------------
>  2 files changed, 31 deletions(-)
> 
> diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py
> b/tests/TestSuite_cvl_dcf_acl_filter.py
> index 826da9c..1d516fc 100644
> --- a/tests/TestSuite_cvl_dcf_acl_filter.py
> +++ b/tests/TestSuite_cvl_dcf_acl_filter.py
> @@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase):
>          self.testpmd_status = "close"
>          #bind pf to kernel
>          self.bind_nics_driver(self.dut_ports, driver="ice")
> -        #move comms package to package folder
> -        self.suite_config = rfc.get_suite_config(self)
> -        comms_package_location =
> self.suite_config["comms_package_file_location"]
> -        package_location = self.suite_config["package_file_location"]
> -        self.dut.send_expect("cp %s %s" % (comms_package_location,
> package_location), "# ")
> -        self.re_load_ice_driver()

this is part of set_up_all, so I thought the suite is designed for comms package, but I saw you remove the replace, is that mean, the suite is also qualified to test other ddp packages, e.g. OS package.
Could you please explain, why do the changes. Thanks.

>          #set vf driver
>          self.vf_driver = 'vfio-pci'
>          self.dut.send_expect("modprobe uio", "# ") @@ -784,16 +778,6 @@ class
> CVLDCFACLFilterTest(TestCase):
>              port.bind_driver(self.vf_driver)
>          time.sleep(15)
> 
> -    def re_load_ice_driver(self):
> -        """
> -        remove and reload the ice driver
> -        """
> -        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
> -        self.dut.send_expect("rmmod ice", "# ", 60)
> -        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
> -        self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 15)
> -        self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ", 15)
> -
>      def set_up(self):
>          """
>          Run before each test case.
> diff --git a/tests/TestSuite_cvl_limit_value_test.py
> b/tests/TestSuite_cvl_limit_value_test.py
> index 77ce016..b806474 100644
> --- a/tests/TestSuite_cvl_limit_value_test.py
> +++ b/tests/TestSuite_cvl_limit_value_test.py
> @@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase):
>          self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0])
>          self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1])
> 
> -    def re_load_ice_driver(self):
> -        """
> -        remove and reload the ice driver
> -        """
> -        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
> -        self.dut.send_expect("rmmod ice", "# ", 15)
> -        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
> -        time.sleep(5)
> -
>      def config_testpmd(self):
>          self.pmd_output.execute_cmd("set fwd rxonly")
>          self.pmd_output.execute_cmd("set verbose 1") @@ -813,12 +804,6 @@
> class TestCvlLimitValue(TestCase):
>      def test_max_rule_number(self):
>          #bind pf to kernel
>          self.bind_nics_driver(self.dut_ports, driver="ice")
> -        #move comms package to package folder
> -        self.suite_config = rfc.get_suite_config(self)
> -        comms_package_location =
> self.suite_config["comms_package_file_location"]
> -        package_location = self.suite_config["package_file_location"]
> -        self.dut.send_expect("cp %s %s" % (comms_package_location,
> package_location), "# ")
> -        self.re_load_ice_driver()
>          #set vf driver
>          self.vf_driver = 'vfio-pci'
>          self.dut.send_expect('modprobe vfio-pci', '#')
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] remove reload ice code
  2021-03-30  1:39   ` Tu, Lijuan
@ 2021-03-30  2:19     ` Huang, ZhiminX
  0 siblings, 0 replies; 6+ messages in thread
From: Huang, ZhiminX @ 2021-03-30  2:19 UTC (permalink / raw)
  To: Tu, Lijuan, dts

For the current framework design, the dts not to replace pkg for regression.
After we tested, cvl_limit_value_test and cvl_dcf_acl_filter suites support os/comms/wireless pkg.
so remove it.

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, March 30, 2021 9:39 AM
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: RE: [dts] [PATCH V1 1/2] remove reload ice code
> 
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> > Sent: 2021年3月26日 13:08
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1 1/2] remove reload ice code
> >
> > *.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> > ---
> >  tests/TestSuite_cvl_dcf_acl_filter.py   | 16 ----------------
> >  tests/TestSuite_cvl_limit_value_test.py | 15 ---------------
> >  2 files changed, 31 deletions(-)
> >
> > diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py
> > b/tests/TestSuite_cvl_dcf_acl_filter.py
> > index 826da9c..1d516fc 100644
> > --- a/tests/TestSuite_cvl_dcf_acl_filter.py
> > +++ b/tests/TestSuite_cvl_dcf_acl_filter.py
> > @@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase):
> >          self.testpmd_status = "close"
> >          #bind pf to kernel
> >          self.bind_nics_driver(self.dut_ports, driver="ice")
> > -        #move comms package to package folder
> > -        self.suite_config = rfc.get_suite_config(self)
> > -        comms_package_location =
> > self.suite_config["comms_package_file_location"]
> > -        package_location = self.suite_config["package_file_location"]
> > -        self.dut.send_expect("cp %s %s" % (comms_package_location,
> > package_location), "# ")
> > -        self.re_load_ice_driver()
> 
> this is part of set_up_all, so I thought the suite is designed for comms
> package, but I saw you remove the replace, is that mean, the suite is also
> qualified to test other ddp packages, e.g. OS package.
> Could you please explain, why do the changes. Thanks.
> 
> >          #set vf driver
> >          self.vf_driver = 'vfio-pci'
> >          self.dut.send_expect("modprobe uio", "# ") @@ -784,16
> +778,6
> > @@ class
> > CVLDCFACLFilterTest(TestCase):
> >              port.bind_driver(self.vf_driver)
> >          time.sleep(15)
> >
> > -    def re_load_ice_driver(self):
> > -        """
> > -        remove and reload the ice driver
> > -        """
> > -        ice_driver_file_location =
> self.suite_config["ice_driver_file_location"]
> > -        self.dut.send_expect("rmmod ice", "# ", 60)
> > -        self.dut.send_expect("insmod %s" % ice_driver_file_location,
> "# ", 60)
> > -        self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 15)
> > -        self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ",
> 15)
> > -
> >      def set_up(self):
> >          """
> >          Run before each test case.
> > diff --git a/tests/TestSuite_cvl_limit_value_test.py
> > b/tests/TestSuite_cvl_limit_value_test.py
> > index 77ce016..b806474 100644
> > --- a/tests/TestSuite_cvl_limit_value_test.py
> > +++ b/tests/TestSuite_cvl_limit_value_test.py
> > @@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase):
> >          self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0])
> >          self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1])
> >
> > -    def re_load_ice_driver(self):
> > -        """
> > -        remove and reload the ice driver
> > -        """
> > -        ice_driver_file_location =
> self.suite_config["ice_driver_file_location"]
> > -        self.dut.send_expect("rmmod ice", "# ", 15)
> > -        self.dut.send_expect("insmod %s" % ice_driver_file_location,
> "# ", 60)
> > -        time.sleep(5)
> > -
> >      def config_testpmd(self):
> >          self.pmd_output.execute_cmd("set fwd rxonly")
> >          self.pmd_output.execute_cmd("set verbose 1") @@ -813,12
> > +804,6 @@ class TestCvlLimitValue(TestCase):
> >      def test_max_rule_number(self):
> >          #bind pf to kernel
> >          self.bind_nics_driver(self.dut_ports, driver="ice")
> > -        #move comms package to package folder
> > -        self.suite_config = rfc.get_suite_config(self)
> > -        comms_package_location =
> > self.suite_config["comms_package_file_location"]
> > -        package_location = self.suite_config["package_file_location"]
> > -        self.dut.send_expect("cp %s %s" % (comms_package_location,
> > package_location), "# ")
> > -        self.re_load_ice_driver()
> >          #set vf driver
> >          self.vf_driver = 'vfio-pci'
> >          self.dut.send_expect('modprobe vfio-pci', '#')
> > --
> > 1.8.3.1
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-30  2:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  5:08 [dts] [PATCH V1 0/2] remove reload ice and add pkg check Zhimin Huang
2021-03-26  5:08 ` [dts] [PATCH V1 1/2] remove reload ice code Zhimin Huang
2021-03-30  1:39   ` Tu, Lijuan
2021-03-30  2:19     ` Huang, ZhiminX
2021-03-26  5:08 ` [dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove reload ice Zhimin Huang
2021-03-26  5:26   ` Huang, ZhiminX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git