test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes
@ 2021-02-25  1:58 Ling Wei
  2021-02-25  2:17 ` Ling, WeiX
  2021-03-02  5:11 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Ling Wei @ 2021-02-25  1:58 UTC (permalink / raw)
  To: dts; +Cc: Ling Wei

v1:
Add allow pci params when start testpmd.

v2:
Fix spelling mistakes backed to backend.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_vhost_virtio_user_interrupt.py | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py b/tests/TestSuite_vhost_virtio_user_interrupt.py
index 9f89c460..29693f43 100644
--- a/tests/TestSuite_vhost_virtio_user_interrupt.py
+++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
@@ -127,17 +127,21 @@ class TestVirtioUserInterrupt(TestCase):
         testcmd = self.app_testpmd_path + " "
         vdev = ["net_vhost0,iface=vhost-net,queues=1,client=0"]
         para = " -- -i --rxq=1 --txq=1"
+        allow_pci = [self.pci_info]
+        if dmas:
+            for item in self.used_cbdma:
+                allow_pci.append(item)
         if len(pci) == 0:
             if dmas:
                 vdev = ["net_vhost0,iface=vhost-net,queues=1,dmas=[%s]" % dmas]
-                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, vdevs=vdev)
+                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=allow_pci, vdevs=vdev)
             else:
-                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=[self.pci_info], vdevs=vdev)
+                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=allow_pci, vdevs=vdev)
         else:
             if dmas:
                 vdev = ["net_vhost0,iface=vhost-net,queues=1,client=0,dmas=[%s]" % dmas]
                 para = " -- -i"
-                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=pci, prefix='vhost', vdevs=vdev)
+                eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=allow_pci, prefix='vhost', vdevs=vdev)
             else:
                 eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost, prefix='vhost', no_pci=True, vdevs=vdev)
         cmd_vhost_user = testcmd + eal_params + para
@@ -217,7 +221,7 @@ class TestVirtioUserInterrupt(TestCase):
             self.dut.send_expect('./usertools/dpdk-devbind.py -u %s' % self.device_str, '# ', 30)
             self.dut.send_expect('./usertools/dpdk-devbind.py --force --bind=ioatdma  %s' % self.device_str, '# ', 60)
 
-    def test_split_ring_virtio_user_interrupt_with_vhost_net_as_backed(self):
+    def test_split_ring_virtio_user_interrupt_with_vhost_net_as_backend(self):
         """
         Check the virtio-user interrupt can work when use vhost-net as backend
         """
@@ -238,7 +242,7 @@ class TestVirtioUserInterrupt(TestCase):
         self.check_interrupt_log(status="waked up")
         self.dut.send_expect("killall -s INT ping", "#")
 
-    def test_split_ring_virtio_user_interrupt_with_vhost_user_as_backed(self):
+    def test_split_ring_virtio_user_interrupt_with_vhost_user_as_backend(self):
         """
         Check the virtio-user interrupt can work when use vhost-user as backend
         """
@@ -263,7 +267,7 @@ class TestVirtioUserInterrupt(TestCase):
         self.vhost.send_expect("quit", "#", 20)
         self.check_virtio_side_link_status("down")
 
-    def test_packed_ring_virtio_user_interrupt_with_vhost_user_as_backed(self):
+    def test_packed_ring_virtio_user_interrupt_with_vhost_user_as_backend(self):
         """
         Check the virtio-user interrupt can work when use vhost-user as backend
         """
@@ -277,7 +281,7 @@ class TestVirtioUserInterrupt(TestCase):
             time.sleep(3)
             self.check_interrupt_log(status="waked up")
 
-    def test_packed_ring_virtio_user_interrupt_with_vhost_net_as_backed(self):
+    def test_packed_ring_virtio_user_interrupt_with_vhost_net_as_backend(self):
         """
         Check the virtio-user interrupt can work when use vhost-net as backend
         """
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes
  2021-02-25  1:58 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes Ling Wei
@ 2021-02-25  2:17 ` Ling, WeiX
  2021-03-02  5:11 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Ling, WeiX @ 2021-02-25  2:17 UTC (permalink / raw)
  To: Ling, WeiX, dts

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Thursday, February 25, 2021 09:59 AM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci
> params when start testpmd and fix spelling mistakes


[-- Attachment #2: TestVhostUserInterrupt.log --]
[-- Type: application/octet-stream, Size: 41729 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes
  2021-02-25  1:58 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes Ling Wei
  2021-02-25  2:17 ` Ling, WeiX
@ 2021-03-02  5:11 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-03-02  5:11 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> v1:
> Add allow pci params when start testpmd.
> 
> v2:
> Fix spelling mistakes backed to backend.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-02  5:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25  1:58 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:add allow pci params when start testpmd and fix spelling mistakes Ling Wei
2021-02-25  2:17 ` Ling, WeiX
2021-03-02  5:11 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git