test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xia, YanX" <yanx.xia@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xia, YanX" <yanx.xia@intel.com>
Subject: Re: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule
Date: Wed, 31 Mar 2021 06:02:51 +0000	[thread overview]
Message-ID: <fcbc5426747d4452b99f288e350af4f8@intel.com> (raw)
In-Reply-To: <20210330081828.18432-1-yanx.xia@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xia Yan
> Sent: 2021年3月30日 16:18
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create
> rule
> 
> it's not work if execute validate rule before execute create rule, so put validate
> after create rule.
> 
> Signed-off-by: Xia Yan <yanx.xia@intel.com>

Why do this, it violates test plan:

validate the rules first before create it in each case.
All the rules that can be validated correctly should be created successfully.
The rules can't be validated correctly shouldn't be created successfully.


      parent reply	other threads:[~2021-03-31  6:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:18 Xia Yan
2021-03-30  8:59 ` Chen, LingliX
2021-03-31  6:02 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcbc5426747d4452b99f288e350af4f8@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yanx.xia@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).